> On Dec 4, 2019, at 1:15 PM, Kumar Srinivasan wrote:
>
> Hi Nikola,
>
> It looks ok to me, I will leave it to Henry and Alan to bless this.
>
> IMHO: I think we should fix it correctly now than later, I don't think it is
> all that
> difficult AFAICT all the launcher has to do is identify
On 2019-12-04 07:09, Langer, Christoph wrote:
Hi,
thanks for your comments.
The reason why I want to have (at least basic) internal debugging information
is to have helpful callstacks in hs_err files on crashes.
We go to rather great length to provide this in our testing. The bundles
Hi Nikola,
It looks ok to me, I will leave it to Henry and Alan to bless this.
IMHO: I think we should fix it correctly now than later, I don't think it
is all that
difficult AFAICT all the launcher has to do is identify "--module==", then
the next argument is the first index.
Kumar
On Tue,
Looks good, assuming the change between 03 and 04 is to fix "no new line..."
Naoto
On 12/4/19 11:38 AM, Yang, Letu wrote:
Hi Naoto,
Can you review and approve the webrev? Thanks!
https://cr.openjdk.java.net/~xliu/8234288/webrev.04/
Letu
On 11/23/19, 6:09 PM, "naoto.s...@oracle.com"
Hi Naoto,
Looks very good, and a few comments...
CompactNumberFormat.java:
144: "each singular and plural patterns" -> "each singular and plural
pattern"
148: "Should the pattern include" -> "If the pattern includes"
336: Add a "." at the end of the sentence
407/417: If the plural
Hi Naoto,
Can you review and approve the webrev? Thanks!
https://cr.openjdk.java.net/~xliu/8234288/webrev.04/
Letu
On 11/23/19, 6:09 PM, "naoto.s...@oracle.com" wrote:
Looks good.
Naoto
On 11/22/19 9:55 PM, Yang, Letu wrote:
> Hi Naoto,
>
> Added it in the
This looks good to me, assuming the i18n people are ok with using "Turkey Time"
instead of some other designation.
Thanks,
Paul
On 11/25/19, 10:44 AM, "core-libs-dev on behalf of Yang, Letu"
wrote:
Fixed in https://cr.openjdk.java.net/~xliu/8234288/webrev.04/ Thanks!
From:
thanks,
Vicente
On 12/4/19 2:20 PM, Joe Darcy wrote:
Looks fine Vicente; thanks,
-Joe
On 12/4/2019 11:19 AM, Vicente Romero wrote:
Hi,
Please review the addition of some pack200 tests to the problem list.
They fail as the records patch adds new members to some visitors. But
there is less
Looks fine Vicente; thanks,
-Joe
On 12/4/2019 11:19 AM, Vicente Romero wrote:
Hi,
Please review the addition of some pack200 tests to the problem list.
They fail as the records patch adds new members to some visitors. But
there is less point on fixing them as pack200 will be removed.
diff
Hi,
Please review the addition of some pack200 tests to the problem list.
They fail as the records patch adds new members to some visitors. But
there is less point on fixing them as pack200 will be removed.
diff -r 92385cd2429d test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt Wed Dec
Hi Naoto,
Looks good. I understand you'll update the webrev (with the added
statement to readObject) once the CSR is approved.
ResourceBundleGenerator.java might have been accidentally touched as
there's no change there.
I wonder if you need to guard the pluralRules input since you're
Hi Martin,
this makes sense. This is the right way to force alignment. I do not like
the platform code in the shared file but do not think this is a big deal.
+#if defined (_WIN32) && defined (_MSC_VER)
Why do you think we need _MSC_VER too? Is OpenJDK on Windows even buildable
with anything
Oh well, this sentence in [0] says it all.
"It is not possible to create an .exe or .dll that contains debug information.
Debug information is always placed in a .obj or .pdb file.”
I guess you need to copy pdb files if you runtime debug information.
Bob.
> On Dec 4, 2019, at 10:09 AM,
Hi,
thanks for your comments.
The reason why I want to have (at least basic) internal debugging information
is to have helpful callstacks in hs_err files on crashes.
So, Bob, I don't think the executables can contain debug information, just the
compiled .obj files. When it comes to linking,
Hi Christoph,
thanks for your review and sponsoring!
Best regards,
Arno
> -Original Message-
> From: Langer, Christoph
> Sent: Mittwoch, 4. Dezember 2019 13:55
> To: Zeller, Arno
> Cc: core-libs-dev@openjdk.java.net; Mandy Chung
>
> Subject: RE: RFR(XS): 8234696:
>
Hi Mandy,
thanks for your review.
Best regards,
Arno
> -Original Message-
> From: Mandy Chung
> Sent: Mittwoch, 4. Dezember 2019 00:39
> To: Zeller, Arno
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR(XS): 8234696:
> tools/jlink/plugins/VendorInfoPluginsTest.java times out
>
Hello,
On 2019-12-04 06:26, Bob Vandette wrote:
There seems to be an option that will include debug information in generated
.obj files. Assuming this option is supported in the
versions of Visual Studio we use, it could be used to implement “internal”
native debug symbols.
/Z7
We already
Hi Martin,
thanks for looking into this and coming up with this patch. The test failures
were quite annoying
In hotspot, there is coding to define a macro "ATTRIBUTE_ALIGNED(x)". I'd
rather like to see that we define such a macro in the JDK code as well and use
it. I think it would make the
There seems to be an option that will include debug information in generated
.obj files. Assuming this option is supported in the
versions of Visual Studio we use, it could be used to implement “internal”
native debug symbols.
/Z7
The /Z7 option produces object files that also contain full
Correct, with the Microsoft toolchain there is no support for internal.
I don't know what happens to the build if you try to configure it that
way. Feel free to come up with a reasonable behavior.
/Erik
On 2019-12-04 00:06, Langer, Christoph wrote:
Hi,
I'm currently looking into native
Hi,
Thanks a lot to all reviewers. This is the header of the changeset I'm
planning to push. There have been a ton of people working on the
development and / or the review process and I don't want to forget
anyone. Please let me know if I'm missing someone:
8225054: Compiler implementation
Hi Arno,
+1
I'll push it for you.
Cheers
Christoph
> -Original Message-
> From: core-libs-dev On Behalf
> Of Mandy Chung
> Sent: Mittwoch, 4. Dezember 2019 00:39
> To: Zeller, Arno
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: RFR(XS): 8234696:
>
Hi,
I'm currently looking into native debug symbols support for Windows.
The OpenJDK build system supports these two configure flags
--with-native-debug-symbols= (among a few other options
which I don't want to discuss here).
So, the name implies that for "internal", debug symbols should be
23 matches
Mail list logo
