All,
I tried to use jpackage file-associations option to associate a given
extension. This works fine. The program gets launched with the given
argument (e.g., double clicking file on Windows).
I have noticed though that the argument may be split due to possible
whitespaces in the filename.
e.g.
> On Dec 12, 2019, at 10:21 PM, David Holmes wrote:
>
> Hi Igor,
>
> On 13/12/2019 3:19 pm, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8235866/webrev.00
>>> 5 lines changed: 0 ins; 0 del; 5 mod
>> Hi all,
>> could you please review this small patch which updates TEST.ROOT
Hi Igor,
On 13/12/2019 3:19 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8235866/webrev.00
5 lines changed: 0 ins; 0 del; 5 mod
Hi all,
could you please review this small patch which updates TEST.ROOT in all test
suites to require jtreg4.2b16?
8230067[1] updated profiles
Please review fix [2] for jpackage bug [1].
Not sure why it happens, but reading output from "hdiutil attach" was
not exiting immediately after process terminated with delays upto 20
seconds always and in some case upto 10 minutes and thus test was
timeout. Only possible workaround found is to
http://cr.openjdk.java.net/~iignatyev//8235866/webrev.00
> 5 lines changed: 0 ins; 0 del; 5 mod
Hi all,
could you please review this small patch which updates TEST.ROOT in all test
suites to require jtreg4.2b16?
8230067[1] updated profiles to use jtreg4.2b16, but didn't update TEST.ROOT
files.
Thanks Alexey! and I wait Reviewer(s).
Yasumasa
On 2019/12/13 1:42, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 12/12/2019 8:23 AM, Yasumasa Suenaga wrote:
Hi Andrew,
I can see same error whether --disable-precompiled-headers or not.
So I filed it to JBS and uploaded webrev.
Could you r
+1
-Joe
On 12/12/19 2:07 PM, naoto.s...@oracle.com wrote:
Sorry, I seem to have posted an old webrev, which included unnecessary
retrieval of the generic name (4168-4173 in v.00). Here is the correct
webrev:
http://cr.openjdk.java.net/~naoto/8235238/webrev.01/
Naoto
On 12/12/19 1:37 PM,
On Dec 9, 2019, at 10:16 AM, Peter Levart wrote:
> What do you think? Might this be better performance wise?
Yes, a fast positive proof that the access is allowed can be
implemented along the lines you mention.
The owner token could be overloaded in additional ways, if and
when we do more patter
Additional information regarding the field array.
It is meant to hold two arrays, the lower half holds the stamp. And the upper
half holds the fields.
The original implementation was intending to display the second half of the
array. Though the outer loop
iterated through the whole array. Theref
I've just pushed this patch to jdk/jdk14.
I'd like to thank all the reviewers for the great (and quick) feedback.
Cheers
Maurizio
On 11/12/2019 15:39, Maurizio Cimadamore wrote:
I went ahead and created a new revision:
http://cr.openjdk.java.net/~mcimadamore/panama/8234049_v6/
Delta from lat
Hi,
Requesting review for
JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8235699
Webrev : https://cr.openjdk.java.net/~phh/8235699/webrev.00/
CalendarBuilder.toString method has a bug which causes an
ArrayIndexOutOfBoundsException exception.
The class is an internal jdk class that is rest
Sorry, I seem to have posted an old webrev, which included unnecessary
retrieval of the generic name (4168-4173 in v.00). Here is the correct
webrev:
http://cr.openjdk.java.net/~naoto/8235238/webrev.01/
Naoto
On 12/12/19 1:37 PM, Roger Riggs wrote:
+1
There's quite a bit of work being don
+1
There's quite a bit of work being done to get the eligible stings
as part of each parse but it doesn't look easy to re-use it acrosses parses.
Roger
On 12/12/19 3:42 PM, Joe Wang wrote:
On 12/12/19 12:31 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for the review.
The original c
On 12/12/19 12:31 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for the review.
The original code loops through zoneStrings array, and if the id
exists in regionIds, then adds their display names in the tree
(4142-4154). This process is not altered with my change. My change
made regi
Hi Joe,
Thank you for the review.
The original code loops through zoneStrings array, and if the id exists
in regionIds, then adds their display names in the tree (4142-4154).
This process is not altered with my change. My change made regionIds
mutable (line 4127) so that after the loop, it on
Hi Naoto,
Does the new code block, 4156 - 4174, need a conditional statement, that
is when it's for a standard timezon? Before this change, or before a
custom TimeZoneNameProvider is attempted, the process didn't need to
loop through regionIds to add display names.
Thanks,
Joe
On 12/11/19 1
Looks good.
- Alexey
On 12/12/2019 8:23 AM, Yasumasa Suenaga wrote:
Hi Andrew,
I can see same error whether --disable-precompiled-headers or not.
So I filed it to JBS and uploaded webrev.
Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8235833
webrev: http://cr.openjdk.
On 12/12/2019 00:08, Brian Burkhalter wrote:
https://bugs.openjdk.java.net/browse/JDK-8235668
http://cr.openjdk.java.net/~bpb/8235668/webrev.00/
Due to the problems reported in [1], in the interest of not changing
longstanding behavior, we would like to revert the fix for [2], despite the
fact
> On 11 Dec 2019, at 16:43, Paul Sandoz wrote:
>
> Looks very good,
+1 This looks very good to me too. Nice work.
-Chris.
> Paul.
>
>> On Dec 11, 2019, at 7:39 AM, Maurizio Cimadamore
>> wrote:
>>
>> I went ahead and created a new revision:
>>
>> http://cr.openjdk.java.net/~mcimadamore
Hi Brian,
ok, the revert looks fine.
Roger
On 12/11/19 7:08 PM, Brian Burkhalter wrote:
https://bugs.openjdk.java.net/browse/JDK-8235668
http://cr.openjdk.java.net/~bpb/8235668/webrev.00/
Due to the problems reported in [1], in the interest of not changing
longstanding behavior, we would li
Thank you Henry for fixing the test issue, and thank you Kumar for the prompt
review! In hindsight I should've run the tests on MacOS too, I'll make sure I
do that for future work.
I truly appreciate the help you've given me in making this bug fix.
Cheers,
Nikola
-Original Message-
Fro
Hi Henry,
I approve this. Appreciate you pushing it, as usual *all* possible tests need
to be run. ;)
Nikola, welcome to the OpenJDK community.
Thanks
Kumar
> On Dec 11, 2019, at 10:29 PM, Henry Jen wrote:
>
> Nikola,
>
> The change looks fine to me as well, I’ll run the test and push it
Hi Andrew,
I can see same error whether --disable-precompiled-headers or not.
So I filed it to JBS and uploaded webrev.
Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8235833
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8235833/webrev.00/
It works fine on Fedora 31.
On 12/12/19 9:31 AM, Yasumasa Suenaga wrote:
> AFAICS sysctl.h provides `sysctl()` and some macros, but they are not used in
> PosixPlatform.cpp .
> In fact, I did not see any error when I remove `#include ` from
> it.
You probably won't see an error unless you configure with
--disable-precompil
On 12/11/19 7:29 pm, Igor Ignatyev wrote:
Hi Sergey,
overall looks good to me. a question about linux, is there an alternative to
gnome-screenshot for DEs other than GNOME?
There are some alternatives like spectacle, mate-screenshot, xwd,
imagemagick/import and some others, but non
of them a
Hi all,
I tried to build jdk/jdk on Fedora 31 x64, but I saw C++ compiler error as
below:
```
In file included from
/home/ysuenaga/OpenJDK/jdk/src/jdk.incubator.jpackage/unix/native/libapplauncher/PosixPlatform.cpp:36:
/usr/include/sys/sysctl.h:21:2: error: #warning "The header is
deprecated
Thanks, Andy and Alexey for the reviews. I've pushed it.
Cheers
Christoph
> -Original Message-
> From: core-libs-dev On Behalf
> Of Andy Herrick
> Sent: Mittwoch, 11. Dezember 2019 15:25
> To: core-libs-dev@openjdk.java.net
> Subject: Re: RFR (S): 8235750: [jpackage] Cleanup imports in
>
The quote is causing test failure on Mac, I’ll apply following fix
diff --git a/test/jdk/tools/launcher/ArgsEnvVar.java
b/test/jdk/tools/launcher/ArgsEnvVar.java
--- a/test/jdk/tools/launcher/ArgsEnvVar.java
+++ b/test/jdk/tools/launcher/ArgsEnvVar.java
@@ -285,7 +285,7 @@
}
//
28 matches
Mail list logo
