Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-15 Thread Martin Buchholz
forwarded to other teams for review. On Fri, Dec 13, 2019 at 3:14 AM Patrick Zhang OS < patr...@os.amperecomputing.com> wrote: > Hi > > Please review this patch, if it should be reviewed by any group other than > core-libs, please help forward it. Thanks. > > JBS:

Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-15 Thread Martin Buchholz
Looks good to me.

Re: jpackager

2019-12-15 Thread Scott Palmer
Welcome to Windows. The .exe is a Windows app not a Console app. This is a distinction that only Microsoft seemed to think was needed. All other platforms are sane. There is command line option to make a console app. --win-console Scott > On Dec 14, 2019, at 12:22 PM, Thomas Vatter

jpackager

2019-12-15 Thread Thomas Vatter
Hi, I've created a modular jar and jre image by jlink. I tested it with this command: PS C:\_dev\exebase\SimpleApp> .\jimage\bin\java.exe -m SimpleApp Dec 14, 2019 6:07:39 PM simpleapp.SimpleApp main INFO: SimpleApp says hello It says "SimpleApp says hello" in the powershell window. Then I

Re: [minor feature change] java.util.Properties

2019-12-15 Thread Alan Bateman
On 15/12/2019 16:37, Bradley Willcott wrote: Hi there, I have been told that this is the correct place is to propose a change to the Java SDK. I would like to propose the following changes to /java.util.Properties/: 1) That the current built-in treatment of the space character ' ' as a

Re: RFR 8235930 : java.util.regex.PrintPattern does not print a link to the next node

2019-12-15 Thread Ivan Gerasimov
Thank you Martin! Pushed. On 12/14/19 10:45 PM, Martin Buchholz wrote: Looks Good To Me. -- With kind regards, Ivan Gerasimov

[minor feature change] java.util.Properties

2019-12-15 Thread Bradley Willcott
Hi there, I have been told that this is the correct place is to propose a change to the Java SDK. I would like to propose the following changes to /java.util.Properties/: 1) That the current built-in treatment of the space character ' ' as a key/value pair separator, be made optional.  This