Hi Volker,
Thank you for the feedback.
I have update the revision to reflect your comments.
http://cr.openjdk.java.net/~phh/8235699/webrev.01/
Regards,
Clive Verghese
On 12/13/19, 8:09 AM, "Volker Simonis" wrote:
Hi Clive,
nice catch :)
I think it would be better
Thanks Martin.
Hi net-dev, and/or security-dev Reviewers,
Please help review and sponsor this patch if acceptable.
It does not tend to bring any functionality changes, instead to propose an
early fix, for the build (linking) errors with further toolchain (GCC 10).
JBS:
Gentle ping.
Will someone please volunteer to review this fix of a regression?
Thanks in advance!
On 11/20/19 10:11 PM, Ivan Gerasimov wrote:
Hello!
When a sublist of a sublist of an ArrayList is created, its modCount
is initialized from the ArrayList root, and not from its immediate
Hello!
In the regular expressions, the quantifier ? can be equally written as
{0,1}.
While for the former variant an optimized algorithm is used (coded in
the Pattern.Ques class), the later variant uses more general and less
efficient implementation (coded in the Pattern.Curly class).
It
+1
Please add an appropriate noreg-* label to the bug.
-phil
On 12/16/19, 8:29 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 12/16/2019 10:32 AM, Andy Herrick wrote:
Please review this jpackage fix to [1] at [2]
the change just adds quotes around the Argument element's value in
WIX
thanks for confirming that Joe.
-- Igor
> On Dec 16, 2019, at 9:54 AM, Joe Wang wrote:
>
>
>
> On 12/12/19 10:46 PM, Igor Ignatyev wrote:
>> @Joe/Lance,
>> were there any reasons why you needed to switch jtreg's requiredVersion back
>> to 4.2b13 in jaxp? are there any reasons which prevent
Looks good.
On 12/16/2019 7:32 AM, Andy Herrick wrote:
Please review this jpackage fix to [1] at [2]
the change just adds quotes around the Argument element's value in WIX
xml's association definition.
[1] https://bugs.openjdk.java.net/browse/JDK-8235915
[2]
On 12/12/19 10:46 PM, Igor Ignatyev wrote:
@Joe/Lance,
were there any reasons why you needed to switch jtreg's
requiredVersion back to 4.2b13 in jaxp? are there any reasons which
prevent jaxp from switching to jtreg4.2b16 now?
I don't recall any specific reason, if any. It would be fine
I 've tried with the recommended jpackage from JDK14 EA.
The syntax has slightly changed, with the option --win-console it now
shows the output as expected:
> .\test01.exe
Dec 16, 2019 6:41:01 PM simpleapp.SimpleApp main
INFO: SimpleApp says hello
Thomas
Am 16.12.2019 um 15:14 schrieb Andy
Looks good.
- Alexey
On 12/16/2019 10:32 AM, Andy Herrick wrote:
Please review this jpackage fix to [1] at [2]
the change just adds quotes around the Argument element's value in WIX
xml's association definition.
[1] https://bugs.openjdk.java.net/browse/JDK-8235915
[2]
Hi Andy,
The change looks ok.
(As long as the files being copied have the needed execute, write and
read permissions.)
Roger
On 12/16/19 10:32 AM, Andy Herrick wrote:
can I get a review from a Reviewer to push this simple fix in JDK-15 ?
/Andy
On 12/10/2019 3:00 PM, Andy Herrick wrote:
Please review this jpackage fix to [1] at [2]
the change just adds quotes around the Argument element's value in WIX
xml's association definition.
[1] https://bugs.openjdk.java.net/browse/JDK-8235915
[2] http://cr.openjdk.java.net/~herrick/8235915/webrev.01/
/Andy
can I get a review from a Reviewer to push this simple fix in JDK-15 ?
/Andy
On 12/10/2019 3:00 PM, Andy Herrick wrote:
On 12/10/2019 12:56 PM, Andy Herrick wrote:
Please review the jpackage fix at [1] to issue [2].
This is a change to jpackage/internal/IOUtils.copyFile() to
essentially
Thank you, yes. In fact I'm packaging a GUI Application, I was just
having a first try with a simple console application.
Thomas
Am 16.12.2019 um 16:05 schrieb Schnoor Jonas:
Notice the different naming: jpackage*r* vs. jpackage (without the trailing
*r*).
The primary purpose of JPackage*r*
Notice the different naming: jpackage*r* vs. jpackage (without the trailing
*r*).
The primary purpose of JPackage*r* seems to be to package JavaFX (read: GUI)
applications and AFAIK is a backport by GluonHQ of an EA version of JPackage
that probably did not yet have the --win-console option.
I first read on
https://openjdk.java.net/jeps/343
Then I was looking for the download and somewhere found the links
http://download2.gluonhq.com/jpackager/11/jdk.packager-linux.zip
http://download2.gluonhq.com/jpackager/11/jdk.packager-osx.zip
That was my initial reaction too, but I don't believe that is the
problem here.
The arguments to jpackage used indicate you are using an older early
access version of jpackage.
Can you try again using the jpackage in the latest JDK14 EA from
https://jdk.java.net/14/ ?
/Andy
On 12/15/2019
The recent crypto event logging mechanism (JDK-8148188) has introduced a
regression whereby the System Logger may be invoked too early in the
bootstrap phase. This causes issue when JarFile objects are locked by
JarFile verifier initialization code. The logging work records an X509
Certificate
Hi Jon,
On Fri, 2019-12-13 at 08:47 -0800, Jonathan Gibbons wrote:
> I've been trying to contact AdoptOpenJDK folk about this and other
> related issues. I've not heard back yet.
It's tracked at AdoptOpenJDK via:
https://github.com/AdoptOpenJDK/openjdk-build/issues/1445
Thanks,
Severin
Gentle Remainder .
Kindly review , this is just a small patch.
Thanks,
Suresh.
From: Sureshkumar Mahaliswamy
Sent: Wednesday, November 27, 2019 1:16 PM
To: core-libs-dev@openjdk.java.net
Subject: RFR(S) : 8234309:LFGarbageCollectedTest.java fails with parse Exception
Hi All,
20 matches
Mail list logo
