RFR: JDK-8236138: Add tests for jmod applications

2019-12-17 Thread Alexey Semenyuk
Please review fix [2] for jpackage bug [1]. The fix updates jtreg tests by adding test coverage for scenarios when jpackage is used for packaging applications bundled in .jmod files. - Alexey [1] https://bugs.openjdk.java.net/browse/JDK-8236138 [2] http://cr.openjdk.java.net/~asemenyuk/82361

Re: RFR (trivial): 8235833: PosixPlatform.cpp should not include sysctl.h

2019-12-17 Thread Yasumasa Suenaga
PING: Could you review this trivial change? JBS: https://bugs.openjdk.java.net/browse/JDK-8235833 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8235833/webrev.00/ Yasumasa On 2019/12/12 22:23, Yasumasa Suenaga wrote: Hi Andrew, I can see same error whether --disable-precompiled-h

RFR(S): 8236111 : narrow allowSmartActionArgs disabling

2019-12-17 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/ > 31 lines changed: 20 ins; 11 del; 0 mod; Hi all, could you please review this small patch which enables allowSmartActionArgs in hotspot and jdk test suites and disables them in a small number of test directories? the patch also removes

Re: jpackager

2019-12-17 Thread Thomas Vatter
Hi Scott, thank you for you answer and explainationr, I did another test the weekend, with a JFrame Window and this is shown. Thomas Am 16.12.2019 um 02:46 schrieb Scott Palmer: Welcome to Windows. The .exe is a Windows app not a Console app. This is a distinction that only Microsoft seemed

Re: RFR: JDK-8235903: GCC default -fno-common exposes "multiple definition" link errors

2019-12-17 Thread Chris Hegarty
The changes to the SCTP code seem ok. -Chris. > On 17 Dec 2019, at 03:00, Patrick Zhang OS > wrote: > > Thanks Martin. > > Hi net-dev, and/or security-dev Reviewers, > > Please help review and sponsor this patch if acceptable. > It does not tend to bring any functionality changes, instead to