Code looks fine, I did not run the tests, but +1 assuming this has been run
through a mach5 test job already. If not please submit one first.
-phil.
On 12/18/19, 6:38 AM, Andy Herrick wrote:
Code looks good - ran tests locally and all passed.
/Andyu
On 12/17/2019 8:31 PM, Alexey Semenyuk wrot
Hi Matthias,
Looks good. Thanks for fixing and finding. :)
David
On 19/12/2019 12:33 am, Baesken, Matthias wrote:
Hello David,
Here is a change that adjusts the naming of
Java_jdk_internal_reflect_Reflection_getCallerClass -
With this change, I checked the output of LD_DEBUG=libs ja
Hi Roger.
Thank you for taking a look!
The variant with a single loop was the first thing I tried (should have
mentioned that in the review request).
Unfortunately, that showed performance decrease.
I suspect that hitting the end of the input should be a less common
thing, that's why it it
Hi Ivan,
Though the new code has a good effect, the asymmetry and duplication
seems unnecessary.
Can it be structured to have a single copy of the loop comparing the
available range
and still get the desired performance improvement.
Like:
boolean match(Matcher matcher,int i, CharSequence seq
On 18/12/2019 14:33, Baesken, Matthias wrote:
Hello David,
Here is a change that adjusts the naming of
Java_jdk_internal_reflect_Reflection_getCallerClass -
With this change, I checked the output of LD_DEBUG=libs java Test ,
and the error I observed before is gone .
Bug/webrev :
Code looks good - ran tests locally and all passed.
/Andyu
On 12/17/2019 8:31 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
The fix updates jtreg tests by adding test coverage for scenarios when
jpackage is used for packaging applications bundled in .jmod files.
- A
Nice find!
Looks good to me.
/Claes
On 2019-12-18 15:33, Baesken, Matthias wrote:
Hello David,
Here is a change that adjusts the naming of
Java_jdk_internal_reflect_Reflection_getCallerClass -
With this change, I checked the output of LD_DEBUG=libs java Test ,
and the error I ob
Hello David,
Here is a change that adjusts the naming of
Java_jdk_internal_reflect_Reflection_getCallerClass -
With this change, I checked the output of LD_DEBUG=libs java Test ,
and the error I observed before is gone .
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-823618
Hi David, thanks for clarification .
Guess we can just remove the __ now and avoid one lookup.
I'll open a bug for this .
Best regards, Matthias
> On 18/12/2019 10:43 pm, David Holmes wrote:
> > On 18/12/2019 7:43 pm, Baesken, Matthias wrote:
> >> Hello, I recently worked a bit with the
On 18/12/2019 10:43 pm, David Holmes wrote:
On 18/12/2019 7:43 pm, Baesken, Matthias wrote:
Hello, I recently worked a bit with the "verbose debugging
information" output about operations of the dynamic linker (to
sort out some lib loading issues) .
See
https://docs.oracle.com/cd/E196
On 18/12/2019 7:43 pm, Baesken, Matthias wrote:
Hello, I recently worked a bit with the "verbose debugging information"
output about operations of the dynamic linker (to sort out some lib loading issues) .
See
https://docs.oracle.com/cd/E19683-01/816-1386/chapter3-33/index.html
http://m
Hello, I recently worked a bit with the "verbose debugging information"
output about operations of the dynamic linker (to sort out some lib loading
issues) .
See
https://docs.oracle.com/cd/E19683-01/816-1386/chapter3-33/index.html
http://man7.org/linux/man-pages/man8/ld.so.8.html
abou
12 matches
Mail list logo
