Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

Thanks David. core-libs folks, could you please review jdk part of this patch? Thanks, -- Igor > On Dec 23, 2019, at 1:33 PM, David Holmes wrote: > > Hi Igor, > > Hotspot changes seem fine. Can't comment on jdk tests. > > Thanks, > David > > On 24/12/2019 6:42 am, Igor Ignatyev wrote: >>

Re: RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

Have you verified this with VS 2017 ? Not that I can see a problem but I doubt we want to trade breaking 2017 to fix 2013 ... -phil. On 12/23/19, 3:52 PM, Alex Kashchenko wrote: Hi, Please review this minor change to jpackage, that is required for successful compilation with VS2013

Re: [15] RFR: 8227313: Support monetary grouping separator in DecimalFormat/DecimalFormatSymbols

Hi Naoto, Is there a need for an APINote to note the relationship between the new get/setMonetaryGroupingSeparator and get/setGroupingSeparator methods. The new method did state it "May be different from {@code grouping separator} in some locales", but that may be insufficient. For example,

RFR: JDK-8236125: Windows (MSVC 2013) build fails in jpackage: Need to include strsafe.h after tchar.h

Hi, Please review this minor change to jpackage, that is required for successful compilation with VS2013 toolchain: Bug: https://bugs.openjdk.java.net/browse/JDK-8236125 Webrev: http://cr.openjdk.java.net/~akasko/jdk/8236125/webrev.00/ Some details on this problem:

Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

Hi Igor, Hotspot changes seem fine. Can't comment on jdk tests. Thanks, David On 24/12/2019 6:42 am, Igor Ignatyev wrote: ping? On Dec 17, 2019, at 11:30 AM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/ 31 lines changed: 20 ins; 11 del; 0 mod; Hi all,

Re: RFR(S): 8236111 : narrow allowSmartActionArgs disabling

ping? > On Dec 17, 2019, at 11:30 AM, Igor Ignatyev wrote: > > http://cr.openjdk.java.net/~iignatyev/8236111/webrev.00/ >> 31 lines changed: 20 ins; 11 del; 0 mod; > > Hi all, > > could you please review this small patch which enables allowSmartActionArgs > in hotspot and jdk test suites

RE: RFR(M):8167065: Add intrinsic support for double precision shifting on x86_64

Hi Vladimir, Thanks for reviewing the code. Can you please sponsor and push the changes? Regards, Smita -Original Message- From: Vladimir Kozlov Sent: Friday, December 20, 2019 9:12 PM To: Kamath, Smita Cc: 'hotspot compiler' ; core-libs-dev@openjdk.java.net Subject: Re:

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

I am not sure what the right mailing list(s) are for this change. It definitely isn't a core-libs change. I think build-dev may be better. I am also unclear when this failure handler is invoked and how all this machinery works. It is only useful for headful tests and so I'd only want it

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi, On 12/2/19 6:13 PM, Bob Vandette wrote: 2) How should we deal with "not supported" for booleans/arrays, etc.? Would it make sense to return record objects from the Metrics API so that this could be dealt with? E.g. Metrics m = ... MetricResult result = m.getCpuSetCpus();

Re: RFR: JDK-8236132: Add missing properties to msi installers

looks good /Andy On 12/20/2019 3:16 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. Add properties to msi installers to properly display installation location and icon of the application in the list of installed applications. - Alexey [1]

Re: RFR 8234362: k_standard.c is not needed and should be removed (was: Re: _IEEE_LIBM targets and __kernel_standard)

On 11/18/19 9:49 PM, Florian Weimer wrote: > I think the file should just be removed. > > Bug: > Webrev: > > As usual, I'll need a sponsor for this. This is OK. How many patches have you