Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-30 Thread Weijun Wang
There is neither a test nor a noreg-* label. I would add a regression test even if reflection is needed. Or you can make it noreg-trivial. Thanks, Max > On Dec 17, 2019, at 11:50 AM, Verghese, Clive wrote: > > Hi Volker, > > Thank you for the feedback. > > I have update the revision to

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString(Internet mail)

2019-12-30 Thread 杨晓峰
Excuse me, Should be "Clive" -Felix 在 2019/12/31 上午9:18,“felixxfyang(杨晓峰)” 写入: Hi Volker, Please update last modified date "Copyright (c) 2010, 2014," to "Copyright (c) 2010, 2019," Thanks, Felix 在 2019/12/31 上午5:59,“core-libs-dev 代表 Hohensee, Paul” 写入:

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString(Internet mail)

2019-12-30 Thread 杨晓峰
Hi Volker, Please update last modified date "Copyright (c) 2010, 2014," to "Copyright (c) 2010, 2019," Thanks, Felix 在 2019/12/31 上午5:59,“core-libs-dev 代表 Hohensee, Paul” 写入: This revision looks fine to me. Thanks, Paul On 12/16/19, 7:52 PM, "core-libs-dev on

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-30 Thread Volker Simonis
Hi Clive, thanks for updating the patch. Looks good now. Do you need a sponsor for pushing? Best regards, Volker Verghese, Clive schrieb am Di., 17. Dez. 2019, 04:50: > Hi Volker, > > Thank you for the feedback. > > I have update the revision to reflect your comments. >

Re: RFR 8235699 : ArrayIndexOutOfBoundsException in CalendarBuilder.toString

2019-12-30 Thread Hohensee, Paul
This revision looks fine to me. Thanks, Paul On 12/16/19, 7:52 PM, "core-libs-dev on behalf of Verghese, Clive" wrote: Hi Volker, Thank you for the feedback. I have update the revision to reflect your comments. http://cr.openjdk.java.net/~phh/8235699/webrev.01/

Re: [14] Review Request: 8233827 Enable screenshots in the enhanced failure handler on Linux/macOS

2019-12-30 Thread Sergey Bylokhov
On 12/23/19 9:15 pm, Phil Race wrote: I am not sure what the right mailing list(s) are for this change. It definitely isn't a core-libs change. I think build-dev may be better. Previous changes to these configs were discussed here, so I have send it here as well. I am also unclear when