Happy New Year, Naoto!
Thanks for the explanation and changes. The changeset looks good to me.
-Joe
On 1/2/20 12:50 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Happy new year and thanks for your comments. Please see my replies below:
On 12/23/19 5:20 PM, Joe Wang wrote:
Hi Naoto,
Is there a
The removal of the existing TEST.properties files look fine.
Please also solicit feedback from the security libs team as their area
is affected.
Roger, FYI the serial filter tests are updated as part of this changeset.
Cheers,
-Joe
On 12/23/2019 8:13 PM, Igor Ignatyev wrote:
Thanks David.
Hi Alan,
Thanks for the feedback,
I have removed the @Author tag and updated the tests as per your
recommendation.
Updated Webrev
http://cr.openjdk.java.net/~phh/8235699/webrev.04/
Regards,
Clive Verghsese
Regards,
Clive Verghese
On 1/2/20, 11:19 AM, "Volker Simonis" wrote:
On
* Philipp Kunz:
> Hi,
>
> The Jar File Specification [1] states that,
>
>> Note: To prevent mangling of files sent via straight e-mail,
>> no header will start with the four letters "From".
>
> But I can't see that this is actually the case.
I think the problem are the five bytes "From " at the
The core lib changes look ok.
Roger
On 12/23/19 11:13 PM, Igor Ignatyev wrote:
Thanks David.
core-libs folks, could you please review jdk part of this patch?
Thanks,
-- Igor
On Dec 23, 2019, at 1:33 PM, David Holmes wrote:
Hi Igor,
Hotspot changes seem fine. Can't comment on jdk tests.
Hi Joe,
Happy new year and thanks for your comments. Please see my replies below:
On 12/23/19 5:20 PM, Joe Wang wrote:
Hi Naoto,
Is there a need for an APINote to note the relationship between the new
get/setMonetaryGroupingSeparator and get/setGroupingSeparator methods.
The new method did
On 02.01.20 18:39, Alan Bateman wrote:
> On 02/01/2020 13:26, Volker Simonis wrote:
>> :
>> http://cr.openjdk.java.net/~simonis/webrevs/2020/8235699.02/
>>
>> Ready to push?
>>
> You shouldn't need to use core reflection here. Instead you can create
> the test so that it is compiled and runs as if
On 02/01/2020 13:26, Volker Simonis wrote:
:
http://cr.openjdk.java.net/~simonis/webrevs/2020/8235699.02/
Ready to push?
You shouldn't need to use core reflection here. Instead you can create
the test so that it is compiled and runs as if part of the java.text
package, e.g.
@build
Bump :)
Hi Mandy,
Sorry for the delay in responding.
Mandy Chung wrote on 29/10/2019 19:30:55:
> From: Mandy Chung
> To: Adam Farley8
> Cc: core-libs-dev
> Date: 29/10/2019 19:31
> Subject: [EXTERNAL] Re: RFR: JDK-8232773: ClassLoading Debug Output
> for Specific Classes
>
> Hi Adam,
>
On 31.12.19 18:06, Alan Bateman wrote:
> On 31/12/2019 16:54, Verghese, Clive wrote:
>> Hi Volker,
>>
>> Thank you for reviewing the changes and approving.
>>
> Do you know if there is any test coverage for this method? The builder
> is package-private and I think your original mail said that it
I guess it is too late to fix it, will need to update the files at the end of
2020.
On 1/2/20 10:57 am, Erik Joelsson wrote:
Build files look good.
/Erik
On 2019-12-24 19:22, Sergey Bylokhov wrote:
Hello.
Here is an updated version:
Bug: https://bugs.openjdk.java.net/browse/JDK-8235975
11 matches
Mail list logo
