Re: New candidate JEP: 371: Hidden Classes

2020-01-24 Thread Bernd Eckenfels
Hello, I wonder will this (weak class) be useful for reflective method accessors and even be able to reduce/remove the need of jdk.internal.reflect.DelegatingClassLoaders? If so, that would be a good example to mention in the JEP (it only mentions Proxies). (And I was really surprised to see N

[15] 8219567: One of the RandomAccessFile constructor's parameter is not properly named

2020-01-24 Thread Brian Burkhalter
Please review this minor change [1] to address [2]. If it looks worthwhile to address then a CSR will be filed. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8219567/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8219567

Fwd: New candidate JEP: 371: Hidden Classes

2020-01-24 Thread David Holmes
FYI. Cheers, David --- Begin Message --- https://openjdk.java.net/jeps/371 - Mark --- End Message ---

Re: RFR: 8237521: Memory Access API fixes for 32-bit

2020-01-24 Thread David Holmes
On 24/01/2020 7:58 pm, Nick Gasson wrote: Hi David, On 01/24/20 14:35 pm, David Holmes wrote: How about we align the size up to ADDRESS_SIZE (== HeapWordSize) in Unsafe.allocateMemory() before the call to allocateMemoryChecks(). Like: bytes = ((bytes + ADDRESS_SIZE - 1) & ~(ADDRESS_SIZE -

Re: [14] 8215361 (doc) Cleanup package-info markup - smartcardio, java.sql, java.sql.rowset

2020-01-24 Thread naoto . sato
Looks good. Thank you for the update. Naoto On 1/24/20 11:28 AM, Roger Riggs wrote: Hi, Corrections for the observed flaws:   http://cr.openjdk.java.net/~rriggs/webrev-doc-cleanup-8215361-2/ Thanks, Roger On 1/23/20 4:08 PM, naoto.s...@oracle.com wrote: Hi Roger, Looks good to me. Alth

Re: [14] RFR (doc) 8237651 Clarify initialization of jdk.serialFilter

2020-01-24 Thread Brent Christian
Looks fine to me, Roger. -Brent On 1/24/20 11:51 AM, Roger Riggs wrote: Please review a doc change in the description of the initialization of the jdk.serialFilter from a system property to generalize it beyond only command line invocation. diff a/src/java.base/share/classes/java/io/ObjectInp

[14] RFR (doc) 8237651 Clarify initialization of jdk.serialFilter

2020-01-24 Thread Roger Riggs
Please review a doc change in the description of the initialization of the jdk.serialFilter from a system property to generalize it beyond only command line invocation. diff a/src/java.base/share/classes/java/io/ObjectInputFilter.java b/src/java.base/share/classes/java/io/ObjectInputFilter.java

Re: [14] 8215361 (doc) Cleanup package-info markup - smartcardio, java.sql, java.sql.rowset

2020-01-24 Thread Roger Riggs
Hi, Corrections for the observed flaws:   http://cr.openjdk.java.net/~rriggs/webrev-doc-cleanup-8215361-2/ Thanks, Roger On 1/23/20 4:08 PM, naoto.s...@oracle.com wrote: Hi Roger, Looks good to me. Although they are in the original src, I would put spaces between "{@code SerialBlob}" and

Re: RFR: 8237521: Memory Access API fixes for 32-bit

2020-01-24 Thread Maurizio Cimadamore
Changes to the Java code looks fine to me - (and the overall approach in Unsafe seems sensible, but I'll defer to David for that) Thanks Maurizio On 24/01/2020 09:58, Nick Gasson wrote: Hi David, On 01/24/20 14:35 pm, David Holmes wrote: How about we align the size up to ADDRESS_SIZE (== Hea

Re: [zlib] Why do we make uLong a 32-bit int on 64-bit platforms?

2020-01-24 Thread Alan Bateman
On 15/01/2020 21:39, Volker Simonis wrote: Hi, is there any reason why the bundled zlib is patched to make zlib's "uLong" type a 32-bit int on 64-bit platforms [1]? This change to the original zlib is there since the very first drop of OpenJDK 6 [2] (which still had version 1.1.3 of zlib). Maybe

Re: RFR: 8237521: Memory Access API fixes for 32-bit

2020-01-24 Thread Nick Gasson
Hi David, On 01/24/20 14:35 pm, David Holmes wrote: >> >> How about we align the size up to ADDRESS_SIZE (== HeapWordSize) in >> Unsafe.allocateMemory() before the call to allocateMemoryChecks(). Like: >> >>bytes = ((bytes + ADDRESS_SIZE - 1) & ~(ADDRESS_SIZE - 1)); >> >> Then it will throw an