On 6 February 2020 21:13:52 GMT, Peter Levart wrote:
>
>
>On 2/6/20 6:54 PM, Seán Coffey wrote:
>> the current proposal is still:
>> http://cr.openjdk.java.net/~coffeys/webrev.8223260.v2/webrev/
>
>But wasn't this one already better:
>
>https://cr.openjdk.java.net/~coffeys/webrev.8223260.v3/web
On 2020-02-06 18:52, Alan Bateman wrote:
Webrev: http://cr.openjdk.java.net/~redestad/8238599/open.00/
This looks good, just a minor nit that declaring emptySet without any
context looks a bit strange. If you move it to below the comment "open
specific packages in the system modules" then it
On 2020-02-06 18:56, Alan Bateman wrote:
On 06/02/2020 12:35, Claes Redestad wrote:
Webrev: http://cr.openjdk.java.net/~redestad/8237484/open.01/
This looks good to me.
Thanks!
/Claes
On 2/6/20 6:54 PM, Seán Coffey wrote:
the current proposal is still:
http://cr.openjdk.java.net/~coffeys/webrev.8223260.v2/webrev/
But wasn't this one already better:
https://cr.openjdk.java.net/~coffeys/webrev.8223260.v3/webrev/
Or do you prefer the v2 so that spec change and behavior cha
Hi Philipp,
Thank you for the reminder. Your email came in during the holidays so it kind
of was lost in my backlog.
First, thank you for the proposed patch. This will take some time to review
but it is on the list
Best
Lance
> On Feb 6, 2020, at 1:37 PM, Philipp Kunz wrote:
>
> Hi,
>
>
Hi,
I recently submitted two patches related to jar manifests and UTF-8 and
haven't got any reaction so far. I understand and appreciate that
everyone has not time for every wish and my enquiry is certainly not
urgent, but still, may I gently ask if I may continue to hope for any
progress, have mi
On 06/02/2020 17:54, Seán Coffey wrote:
the current proposal is still:
http://cr.openjdk.java.net/~coffeys/webrev.8223260.v2/webrev/
Thanks. This mostly looks good to me, I'm just wondering if there is a
better exception to use to carry the checked exception as
UndeclaredThrowableException is s
On 06/02/2020 12:35, Claes Redestad wrote:
Hi,
a few module bootstrap micro-optimizations.
Webrev: http://cr.openjdk.java.net/~redestad/8237484/open.01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8237484
This looks good to me.
-Alan.
the current proposal is still:
http://cr.openjdk.java.net/~coffeys/webrev.8223260.v2/webrev/
I'd like to make the specification change in a follow on bug ID (if that
works for people)
Regards,
Sean.
On 06/02/20 17:49, Alan Bateman wrote:
On 06/02/2020 15:32, Seán Coffey wrote:
InitialContext
On 06/02/2020 16:50, naoto.s...@oracle.com wrote:
Hello,
Please review this extra small fix for this issue:
https://bugs.openjdk.java.net/browse/JDK-8238605
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8238605/webrev.00/
It is simply updating the version number in
On 06/02/2020 16:39, Claes Redestad wrote:
Hi,
by refactoring implAddOpensToAllUnnamed to take the two sets that
comprise the packages we iterate over, we can make some simplifications,
pre-size HashMaps better etc, adding up to a nice little startup
improvement.
Webrev: http://cr.openjdk.java.
- Mail original -
> De: "Claes Redestad"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Jeudi 6 Février 2020 14:48:38
> Objet: Re: RFR: 8237878: Improve ModuleLoaderMap datastructures
> Hi Rémi,
>
>
> On 2020-02-06 14:08, Remi Forax wrote:
>> Hi Claes,
>> In ArchivedModuleGraph, th
On 06/02/2020 15:32, Seán Coffey wrote:
InitialContextFactory itself is an extremely simple interface with one
method. I've browsed some code bases and could only find a small
number of such Factories implementations with simple logic to return a
Context. Applications will most likely delegate
+1
Best,
Joe
On 2/6/20 8:50 AM, naoto.s...@oracle.com wrote:
Hello,
Please review this extra small fix for this issue:
https://bugs.openjdk.java.net/browse/JDK-8238605
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8238605/webrev.00/
It is simply updating the vers
lgtm
Knuth didn't like linear probing, but memory locality became far more
important over time, favoring linear probing.
I don't get what hash() is doing with the low bits. Maybe we want something
like mix32.
On Thu, Feb 6, 2020 at 1:01 AM Andrew Haley wrote:
> On 1/28/20 11:41 PM, Stuart Mark
Hello,
Please review this extra small fix for this issue:
https://bugs.openjdk.java.net/browse/JDK-8238605
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8238605/webrev.00/
It is simply updating the version number in cldr.md files, which should
have been done with JD
Andy,
defaultSupported() is defined, but not called form the test. What is the
point of this method?
- Alexey
On 2/6/2020 8:42 AM, Andy Herrick wrote:
revised fir at [3] to check for non-existent resource-dir as well as
runtime-image dir.
[3] http://cr.openjdk.java.net/~herrick/8237967/web
revised fir at [3] to check for non-existent resource-dir as well as
runtime-image dir.
[3] http://cr.openjdk.java.net/~herrick/8237967/webrev.02/
/Andy
On 2/5/2020 7:46 PM, Andy Herrick wrote:
OK - this makes sense - will update tomorrow.
/Andy
On 2/5/2020 4:24 PM, Alexander Matveev wrote:
Hi,
by refactoring implAddOpensToAllUnnamed to take the two sets that
comprise the packages we iterate over, we can make some simplifications,
pre-size HashMaps better etc, adding up to a nice little startup
improvement.
Webrev: http://cr.openjdk.java.net/~redestad/8238599/open.00/
Bug:https
On 05/02/20 16:51, Daniel Fuchs wrote:
On 05/02/2020 15:31, Peter Levart wrote:
I think this is about allow the InitialContextFactory instance to be
GC'ed when the thread is long lived. It might not be a concern for
the LDAP or the other providers in the JDK.
-Alan
Ah, I see. You mean whe
+1,
One is enough, but additional eyes are good too.
On 2/5/20 10:35 PM, Patrick Zhang OS wrote:
Does this require one more “yes” from any other reviewer?
And may I ask for any committer’s help to sponsor and push it (once approved)?
Thanks in advance.
Regards
Patrick
From: Thomas Stüfe
Se
Hi Rémi,
On 2020-02-06 14:08, Remi Forax wrote:
Hi Claes,
In ArchivedModuleGraph, there is no point to take the mainModule as parameter
given that it should always be null.
right, I've been thinking this should be simplified for now. Once we
implement support for archiving non-default scenar
Hi Claes,
In ArchivedModuleGraph, there is no point to take the mainModule as parameter
given that it should always be null.
In ModuleLoaderMap, the constants PLATFORM_LOADER_INDEX and APP_LOADER_INDEX
should be moved inside the nested class Mapper given that there are only needed
by the Mapper
On 2020-02-05 16:32, Erik Joelsson wrote:
Hello,
New webrev: http://cr.openjdk.java.net/~erikj/8238225/webrev.02/
Looks good.
/Magnus
On 2020-02-05 02:17, Langer, Christoph wrote:
Hi,
we've tested the patch and all reported failure scenarios we're aware
of are fixed with that, so basicall
Hi,
refactor ModuleLoaderMap to allow the datastructure to be
archived, then archive it.
Webrev: http://cr.openjdk.java.net/~redestad/8237878/open.00/
Bug:https://bugs.openjdk.java.net/browse/JDK-8237878
Testing: tier1-3
/Claes
Hi,
a few module bootstrap micro-optimizations.
Webrev: http://cr.openjdk.java.net/~redestad/8237484/open.01/
Bug:https://bugs.openjdk.java.net/browse/JDK-8237484
Testing: tier1-3
/Claes
As far as another reviewer is needed - looks good to me, too 😊
/Christoph
> -Original Message-
> From: core-libs-dev On Behalf
> Of Thomas Stüfe
> Sent: Donnerstag, 6. Februar 2020 07:49
> To: Patrick Zhang OS
> Cc: core-libs-dev
> Subject: Re: RFR: JDK-8238380: java.base/unix/native/l
On 1/28/20 11:41 PM, Stuart Marks wrote:
> As an aside, I don't know whether the linear-probing (open
> addressed) arrangement of IdentityHashMap is in fact faster than the
> separate chaining approach of HashMap. Perhaps investigating that
> could be a side project for someone.
It always has bee
28 matches
Mail list logo
