RE: tools/jpackage/linux - tests (from 8212780: Packaging Tool Implementation)

Hi Alexey, thanks for confirming . I opened for this issue : https://bugs.openjdk.java.net/browse/JDK-8238947 8238947: tools/jpackage tests fail with old rpmbuild versions Is there already a good place in the tools/jpackage test coding, where we could adjust the rpmbuild version check (e

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi Bob, On Tue, 2020-02-11 at 16:59 -0500, Bob Vandette wrote: > I applied your patch to the latest JDK 15 sources and ran the container > tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some > issues. > I’m not sure if its my setup or not. Looking over them, they appear to

RFR: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Hello, please review this small test related change . Currently (most of the) tools/jpackage tests do not work on Ubuntu Linux . Reason is that the rpm parts of the jpackage tests do not pass on this distro . The rpm tests can be disabled by this property : > > > > Do you expect those

Re: [15] RFR: 8234347: "Turkey" meta time zone does not generate composed localized names, 8236548: Localized time zone name inconsistency between English and other locales

+1 On 2/11/20 6:12 PM, Joe Wang wrote: +1. That's nicer. -Joe On 2/11/20 10:17 AM, naoto.s...@oracle.com wrote: Hi, I modified the proposed changeset. Removed the hard coded 3-letter id compatibility mappings (oldMappings) from CLDRConverter.java. Instead, using public ZoneId.SHORT_IDS tha

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

> On Feb 12, 2020, at 6:22 AM, Severin Gehwolf wrote: > > Hi Bob, > > On Tue, 2020-02-11 at 16:59 -0500, Bob Vandette wrote: >> I applied your patch to the latest JDK 15 sources and ran the container >> tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some >> issues. >> I’m

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

I applied the delegation change that you recommended and now all container tests pass. Here’s the change that I applied. echo +cpu +cpuset +io +memory +pids > /sys/fs/cgroup/cgroup.subtree_control echo +cpu +cpuset +io +memory +pids > /sys/fs/cgroup/user.slice/cgroup.subtree_control echo +cpu +

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

Hi, On Wed, 2020-02-12 at 12:29 -0500, Bob Vandette wrote: > I applied the delegation change that you recommended and now all container > tests pass. > > Here’s the change that I applied. > > echo +cpu +cpuset +io +memory +pids > /sys/fs/cgroup/cgroup.subtree_control > echo +cpu +cpuset +io +me

Re: DriverManager.isDriverAllowed has an unintentional side-effect?

Hi Jaikiran > On Feb 10, 2020, at 10:05 PM, Jaikiran Pai wrote: > > Hello Lance, > > On 11/02/20 2:05 am, Lance Andersen wrote: >> Hi Jaikiran >> >> >>> >>> Should this check in the isDriverAllowed, instead use "false" and not >>> trigger the intialization of the class? >> >> As I mentioned

RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

Please review a trivial doc fix to remove html markup that should not be inside {@code}. And a couple of spacing and punctuation fixes. diff --git a/src/java.base/share/classes/java/util/stream/package-info.java b/src/java.base/share/classes/java/util/stream/package-info.java --- a/src/java.b

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

Looks good. Naoto On 2/12/20 10:52 AM, Roger Riggs wrote: Please review a trivial doc fix to remove html markup that should not be inside {@code}. And a couple of spacing and punctuation fixes. diff --git a/src/java.base/share/classes/java/util/stream/package-info.java b/src/java.base/share

Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

I'll take a look next couple days.  I was out last few days and am catching up on other things. Mandy On 2/11/20 10:04 AM, Severin Gehwolf wrote: Hi Mandy, Bob, Thanks again for the reviews and patience on this. Sorry it took me so long to get back to this :-/ Updated webrev: Full: http://cr

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

On 2/12/20 10:52 AM, Roger Riggs wrote: Please review a trivial doc fix to remove html markup that should not be inside {@code}. And a couple of spacing and punctuation fixes. diff --git a/src/java.base/share/classes/java/util/stream/package-info.java b/src/java.base/share/classes/java/util/s

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

Hi Mandy, I considered breaking it up but none of the other examples have that kind of markup and it make the source much less easy to maintain. I'll keep it as is. Thanks, Roger On 2/12/20 2:40 PM, Mandy Chung wrote: On 2/12/20 10:52 AM, Roger Riggs wrote: Please review a trivial doc fix

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

On 2/12/20 11:44 AM, Roger Riggs wrote: Hi Mandy, I considered breaking it up but none of the other examples have that kind of markup and it make the source much less easy to maintain. I'll keep it as is. Okay with me. Mandy Thanks, Roger On 2/12/20 2:40 PM, Mandy Chung wrote: On

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

Mandy, The desire to "highlight" parts of example code has made it onto the wishlist for a possible new `{@example}` tag for do comments. -- Jon On 2/12/20 11:50 AM, Mandy Chung wrote: On 2/12/20 11:44 AM, Roger Riggs wrote: Hi Mandy, I considered breaking it up but none of the other exa

Re: RFR: CSR JDK-8233385 Align some one-way conversion in MS950 charset with Windows

Hi Ichiroh, Its been reviewed (Email 1/22).  To move it to the next step[1] change its status either to Finalized or Proposed. Finalized has fewer steps for simpler, more obviously confirmed changes. Click on the "View WorkFlow"  link to see the steps. Roger [1] https://wiki.openjdk.java.net

Re: RFR 8238919: (doc) Broken code snippet in the java.util.stream package documentation

That's great.  Thanks. Mandy On 2/12/20 11:52 AM, Jonathan Gibbons wrote: Mandy, The desire to "highlight" parts of example code has made it onto the wishlist for a possible new `{@example}` tag for do comments. -- Jon On 2/12/20 11:50 AM, Mandy Chung wrote: On 2/12/20 11:44 AM, Roger R

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

- Mail original - > De: "Stuart Marks" > À: "Remi Forax" > Cc: "Martin Buchholz" , "Kiran Ravikumar" > , "core-libs-dev" > > Envoyé: Mardi 11 Février 2020 00:57:52 > Objet: Re: RFR [15] 8161558: ListIterator should not discard cause on > exception > Hi Remi, > > The bug report origin

Re: DriverManager.isDriverAllowed has an unintentional side-effect?

Hello Lance, On 13/02/20 12:22 am, Lance Andersen wrote: > Hi Jaikiran > >> On Feb 10, 2020, at 10:05 PM, Jaikiran Pai > > wrote: >> >> Hello Lance, >> >> On 11/02/20 2:05 am, Lance Andersen wrote: >>> Hi Jaikiran >>> >>> Should this check in the isDriver

Re: JEP 370 - text example leads to exception

No problem! Nice talk at FOSDEM, Maurizio ;-)! One suggestion, for future talks - when it comes to memory layouts please construct an example that is a little bit more complex (by end of the upcoming weekend I will publish one that can be used). I had trouble with bit alignment when working on min

JDK 15 RFR of JDK-8237805: Use inline @jls @jvms in core libs where appropriate

Hello, Inline forms of the @jls and @jvms javadoc tags are now available (JDK-8235926). I made a pass over the files in java.base to take advantage of the new feature:     http://cr.openjdk.java.net/~darcy/8237805.0/ Thanks, -Joe

Re: JDK 15 RFR of JDK-8237805: Use inline @jls @jvms in core libs where appropriate(Internet mail)

Hi Joe， A minor comment on copyright date 2019 -> 2020 -Felix 在 2020/2/13 下午12:49，“core-libs-dev 代表 Joe Darcy” 写入: Hello, Inline forms of the @jls and @jvms javadoc tags are now available (JDK-8235926). I made a pass over the files in java.base to take advantage of the