Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so as to recognize unified hierarchy

2020-02-14 Thread Mandy Chung
Hi Severin, On 2/11/20 10:04 AM, Severin Gehwolf wrote: Updated webrev: Full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/webrev/ incremental: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/incremental/webrev/ Thanks for updating this.  This patch looks okay in ge

Re: jlink and jpackage not producing correct macOS packages

2020-02-14 Thread Alexander Matveev
Hi James, Thank you for sharing this information. We currently investigating this issue from jpackage side as part of https://bugs.openjdk.java.net/browse/JDK-8237490. Thanks, Alexander On 2/14/2020 9:06 AM, James Elliott wrote: I’d raised some issues earlier on this list about jpackage not

Re: JEP 370 - text example leads to exception

2020-02-14 Thread Maurizio Cimadamore
On 13/02/2020 03:39, Chris T wrote: No problem! Nice talk at FOSDEM, Maurizio ;-)! One suggestion, for future talks - when it comes to memory layouts please construct an example that is a little bit more complex (by end of the upcoming weekend I will publish one that can be used). I had tro

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

2020-02-14 Thread forax
- Mail original - > De: "Stuart Marks" > À: "Remi Forax" > Cc: "Martin Buchholz" , "Kiran Ravikumar" > , "core-libs-dev" > > Envoyé: Vendredi 14 Février 2020 18:25:14 > Objet: Re: RFR [15] 8161558: ListIterator should not discard cause on > exception > On 2/12/20 2:04 PM, fo...@univ-m

Re: RFR: 8211917: (zipfs) Creating or updating a JAR file system should put the MANIFEST.MF at the start

2020-02-14 Thread Lance Andersen
Hi Jaikiran, I think the changes to ZipFileSystem are OK. The test overall is good. I am going to streamline it a bit and remove the long lines (we try to keep lines to around 80 characters). I will push a revised webrev out once I do this over the next few days Best Lance > On Feb 12, 2020

Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in read

2020-02-14 Thread Daniel Fuchs
Hi Vyom, On the surface, your patch seems reasonable. I would be more confident if there was a test, but I understand it might well be one of these noreg-hard issues. I've put it on my TODO list to import your patch and try to test it in our test system. I'll get back to you when I have managed

Re: RFR [15] 8161558: ListIterator should not discard cause on exception

2020-02-14 Thread Stuart Marks
On 2/12/20 2:04 PM, fo...@univ-mlv.fr wrote: I don't disagree with the fact that having the index may help, I disagree with the fact that chaining the IOOBE to the NSEE is the right way to expose that index, crafting an error message with the index is IMO a better idea because you have no id

jlink and jpackage not producing correct macOS packages

2020-02-14 Thread James Elliott
I’d raised some issues earlier on this list about jpackage not being able to create packages that can successfully be notarized by Apple, which is now necessary for them to install and open when downloaded from the internet. My initial point was that jpackage needs to enable secure timestamps, t

RE: 8238953: tools/jpackage tests do not work on Ubuntu Linux

2020-02-14 Thread Baesken, Matthias
Btw one small comment, I wonder why you have own functions for finding out the platform (e.g. in TKit) , maybe jdk.test.lib.Platform should be reused like in a lot of other jtreg tests ? Example : 28import jdk.test.lib.Platform; 43public class DynLibsTest { 44 45public void run(Comma

RFR: 8238953: tools/jpackage tests do not work on Ubuntu Linux

2020-02-14 Thread Baesken, Matthias
Hi Alexey , I like your idea to do the handling in test/jdk/tools/jpackage/helpers/jdk/jpackage/test/PackageType.java . New webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8238953.1/ Best regards, Matthias > Date: Thu, 13 Feb 2020 08:06:44 -0800 > From: Alexey Semenyuk > To: core-