[15] RFR: 8239520: ValueRange.of(long, long, long) does not throw IAE on invalid inputs

Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239520 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8239520/webrev.00/ This change lets 3-arg ValueRange.of() method thrown an IAE on invalid inputs, as well as corrects th

Re: RFR: 8239563 - Reduce public exports in dynamic libraries built from JDK static libraries

Hi Bob, Please file a CSR request for this change; thanks, -Joe On 2/20/2020 11:13 AM, Bob Vandette wrote: Please review this RFE that alters the visibility of JNI entrypoints to hidden when a shared library is created using static JDK libraries. RFE: https://bugs.openjdk.java.net/browse/JDK

RFR: 8239563 - Reduce public exports in dynamic libraries built from JDK static libraries

Please review this RFE that alters the visibility of JNI entrypoints to hidden when a shared library is created using static JDK libraries. RFE: https://bugs.openjdk.java.net/browse/JDK-8239563 All JNI entrypoints that exist in JDK static libraries are declared as exported or visible. If a dyn

Re: RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

Hi Christoph, This looks good and thank you for tackling. We will need to regenerate the web-rev for the Manifest fix after this gets pushed I am running Mach5 tiers 1-3 now and will let you know when it completes > On Feb 20, 2020, at 8:33 AM, Langer, Christoph > wrote: > > Hi, > > pleas

Re: RFR: 8235834 IBM-943 charset encoder needs updating

Thanks for the explanation. Here are comments to your fix: - Can you add some comments about the gist of the change to IBM943.c2b? Summarizing the explanation below would be fine. For the test case: - Please wrap the @bug line appropriately. - Those byte array/Strings can be "static final" o

Re: 8238953: tools/jpackage tests do not work on Ubuntu Linux

Looks good! - Alexey On 2/20/2020 9:53 AM, Baesken, Matthias wrote: Thanks, just posted 8238947: tools/jpackage tests fail with old rpmbuild versions https://bugs.openjdk.java.net/browse/JDK-8238947 http://cr.openjdk.java.net/~mbaesken/webrevs/8238947.0/ Best regards, Matthias There is

RFR 8239556: (zipfs) remove ExistingChannelCloser facility in zipfs implementation

Hi, please review this cleanup change to remove the ExistingChannelCloser facility in zipfs. Some technical details about why this existed can be found in this mailing list thread, where Sherman explained its original purpose: https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-April/05

RFR [XS]: 8238947: tools/jpackage tests fail with old rpmbuild versions

Hello, please review this small change adjusting the minimal rpmbuild version of tools/jpackage tests . Currently the tools/jpackage tests, for example jdk/test/jdk/tools/jpackage/linux/AppCategoryTest.java fail on older distros with rpmbuild tools < 4.10 . This can be seen on Suse Linux (SLES

Re: RFR: 8235834 IBM-943 charset encoder needs updating

Hello Naoto. I appreciate your comment. The definition has not changed recently. Applying the change will prevent the characters which are used on Japanese PC from being converted to "?". I checked IBM-943 definition and changelog. Definitions and creation date are as follows: (All definitio