Hi Mandy and Chris,
On 3/29/20 19:17, Mandy Chung wrote:
On 3/27/20 8:51 PM, Chris Plummer wrote:
Hi Mandy,
A couple of very minor nits in the jvmtiRedefineClasses.cpp comments:
153 // classes for primitives, arrays, hidden and vm unsafe
anonymous classes
154 // cannot be
Dear All,
May I ask your help to reivew this tiny patch? Thanks.
BRs,
Lin
From: "linzang(臧琳)"
Date: Thursday, March 26, 2020 at 3:13 PM
To: "core-libs-dev@openjdk.java.net"
Subject: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when
_JAVA_LAUNCHER_DEBUG set
Dear All,
On 3/27/20 8:51 PM, Chris Plummer wrote:
Hi Mandy,
A couple of very minor nits in the jvmtiRedefineClasses.cpp comments:
153 // classes for primitives, arrays, hidden and vm unsafe
anonymous classes
154 // cannot be redefined. Check here so following code can
assume these
- Mail original -
> De: "Stuart Marks"
> À: "joe darcy"
> Cc: "core-libs-dev"
> Envoyé: Dimanche 29 Mars 2020 04:37:06
> Objet: Re: JDK 15 RF(pre)R of JDK-8241374: add Math.absExact
> Hi Joe,
>
> Overall this looks quite good. Thanks for being thorough about this; I
> certainly
>
Hi,
Usually the @throws, @param, @return, etc clauses are not complete
sentences.
Only complete sentences need a period.
And most of OpenJDK omits them.
$.02, Roger
On 3/29/20 2:22 PM, Thomas Stüfe wrote:
On Sun 29. Mar 2020 at 18:48, Martin Buchholz wrote:
I'm fine with the latest
Hi Stuart,
Full webrev for review include including tests:
http://cr.openjdk.java.net/~darcy/8241374.0/
and the companion CSR:
https://bugs.openjdk.java.net/browse/JDK-8241805
Replies interspersed below.
On 3/28/2020 7:37 PM, Stuart Marks wrote:
Hi Joe,
Overall this looks quite
On Sun 29. Mar 2020 at 18:48, Martin Buchholz wrote:
> I'm fine with the latest version
>
> On Sun, Mar 29, 2020 at 1:29 AM Tagir Valeev wrote:
>
>>
>> > At various places, the "@throws ConcurrentModificationException"
>> javadoc:
>> >
>> > 619 * @throws ConcurrentModificationException if
I'm fine with the latest version
On Sun, Mar 29, 2020 at 1:29 AM Tagir Valeev wrote:
>
> > At various places, the "@throws ConcurrentModificationException" javadoc:
> >
> > 619 * @throws ConcurrentModificationException if it is detected
> that the
> > 620 * mapping function modified
Thank you for the review! Here's the updated version:
http://cr.openjdk.java.net/~tvaleev/webrev/8176894/r5/
Martin,
> 676 V newValue;
> 677 int mc = modCount;
> 678 newValue = mappingFunction.apply(key);
> I would never use a C style declaration when an initializing
