Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

Thank you Roger for the additional changes. Looks good. Please remember to update the copyright year for jdk/TEST.groups and hotspot tests before push, and fix the changed year in bin/unshuffle_list.txt (missed a `,` after 2020) (I'm not an official reviewer.) Thanks, Amy On 4/6/20 11:25

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Sure, will change the before I push. I considered that but didn’t run with it. Cheers, Henry > On Apr 6, 2020, at 7:43 PM, David Holmes wrote: > > Hi Henry, > > On 7/04/2020 3:36 am, Henry Jen wrote: >> Here is the combined webrev[1] which I think is what we should have. By >> using

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Hi Henry, On 7/04/2020 3:36 am, Henry Jen wrote: Here is the combined webrev[1] which I think is what we should have. By using __solaris__, we make sure no extra define from build and assuming that all solaris build will have gethrtime() and use that. This looks good to me and means the

JDK 15 RFR of JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations

Hello, Please review the changes to fix     JDK-8225540: In core reflection note whether returned annotations are declaration or type annotations     http://cr.openjdk.java.net/~darcy/8225540.1/ This is a sibling fix to JDK-8225495 already done over in javax.lang.model. In brief, the

Re: Need sponsor to fix Javadoc warnings

Hi Vipin, On 7/04/2020 2:07 am, Vipin Sharma wrote: Hi David, I forgot to mention this is my second patch here. I am new to this project, as per my understanding we need to contribute 3 patches to get user id and space on cr.openjdk.java.net, for now I need sponsor who can create bug id and

Re: RFR: JDK-8237490: [macos] Add support notarizing jpackage app-image and dmg

Looks good. - Alexey On 4/4/2020 8:53 AM, Andy Herrick wrote: I think it best to modify these checks as part of a separate issue, and leave these checks disabled as part of JDK-8237490.  I have filed JDK-8242155 to enhance these tests, including restoring these checks. /ANdy On 4/3/2020

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/6/20 11:54, Mandy Chung wrote: On 4/6/20 9:56 AM, serguei.spit...@oracle.com wrote: The suggested fix is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/ This patch looks okay. I'll include in my local patch. On 4/6/20 11:00 AM, Chris Plummer

RE: RFR (XXL): 8223347: Integration of Vector API (Incubator): x86 backend changes

Hi Vivek, Thanks for the feedback. This patch is for mainline jdk. Best Regards, Sandhya From: Vivek Deshpande Sent: Monday, April 06, 2020 11:55 AM To: Viswanathan, Sandhya Cc: hotspot-compiler-...@openjdk.java.net; core-libs-dev@openjdk.java.net; hotspot-dev Subject: Re: RFR (XXL):

Re: RFR (XXL): 8223347: Integration of Vector API (Incubator): x86 backend changes

Hi Sandhya I looked at the patch over the weekend. It looks good to me and a lot of work is involved. I have a question. Is this patch intended to panama/dev or mainline jdk? Nit: macroAssembler_x86.cpp has extra line at 115. Regards, Vivek OpenJDK id: vdeshpande On Fri, Apr 3, 2020 at 5:18 PM

Re: Review Request: 8238358: Implementation of JEP 371: Hidden Classes

On 4/6/20 9:56 AM, serguei.spit...@oracle.com wrote: The suggested fix is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/valhalla-jdi-regression-8242166.1/ This patch looks okay. I'll include in my local patch. On 4/6/20 11:00 AM, Chris Plummer wrote: I think that's fine but I don't

RFR [15] 8242230: Whitespace typos, relaxed javadoc, formatting

Hello, Please review the change for https://bugs.openjdk.java.net/browse/JDK-8242230: http://cr.openjdk.java.net/~prappo/8242230/webrev.00/ This is a documentation cleanup. There are no code changes involved, and the changes in documentation are mostly trivial. The following packages are

Re: [NEW BUG] Reduce allocations from Class.toString() for primitives

Hi Christoph, while the patch seems ok, I fail to think of a scenario where performance of Class.toString() might be critical. Also it seems this code is subject to change via valhalla[1]. So I think I'll say no, for once. :-) Thanks! /Claes [1]

[NEW BUG] Reduce allocations from Class.toString() for primitives

Hi, I just noticed an opportunity to optimize Class.toString() for primitive types. I've written a small benchmark and ran it against JDK 15 vs a patched variant. @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public class MyBenchmark { @State(Scope.Benchmark)

Re: RFR(S): 8241638: launcher time metrics alway report 1 on Linux when _JAVA_LAUNCHER_DEBUG set(Internet mail)

Here is the combined webrev[1] which I think is what we should have. By using __solaris__, we make sure no extra define from build and assuming that all solaris build will have gethrtime() and use that. The current build only use that for static build launcher, not custom launcher use libjli.

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

fixed the @bug - thx Alan > On Apr 6, 2020, at 2:12 PM, Alan Bateman wrote: > > On 06/04/2020 16:54, Jim Laskey wrote: >> Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 >> >> >> > I assume this this updated

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

On 03/04/2020 16:43, Roger Riggs wrote: Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are:  - remove the jdk.rmic module  - remove the jdk.rmic man page  - remove all tests of rmic

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

On 06/04/2020 16:54, Jim Laskey wrote: Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 I assume this this updated webrev:   http://cr.openjdk.java.net/~jlaskey/8241742/webrev-01/ I asked Jim off-list about the

Re: Need sponsor to fix Javadoc warnings

Hi David, I forgot to mention this is my second patch here. I am new to this project, as per my understanding we need to contribute 3 patches to get user id and space on cr.openjdk.java.net, for now I need sponsor who can create bug id and upload this webrev on cr.openjdk.java.net Please

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

> On 6 Apr 2020, at 17:03, Paul Sandoz wrote: > > ... >> On Apr 6, 2020, at 8:54 AM, Jim Laskey wrote: >> >> Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 >> Woohoo. LGTM. -Chris.

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

+1 Paul. > On Apr 6, 2020, at 8:54 AM, Jim Laskey wrote: > > Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 > > >> On Apr 6, 2020, at 11:40 AM, Jim Laskey wrote: >> >> Please take the time to review the code

Re: RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

Updated webrev: http://cr.openjdk.java.net/~jlaskey/8241742/webrev-00 > On Apr 6, 2020, at 11:40 AM, Jim Laskey wrote: > > Please take the time to review the code changes to remove preview status for > String::stripIndent,

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

Hi Amy, Thanks for looking in places I didn't grep for rmic references. Hotspot for cds and langtools for javadoc. The webrev is covers just the new changes but I will merge them before the push. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-remove-rmic-8225319-misc/ Thanks, Roger On

RFR: JDK-8241742 - Remove the preview status for methods introduced for Text Blocks

Please take the time to review the code changes to remove preview status for String::stripIndent, String::translateEscapes and String::formatted. The changes are pretty light-weight and shouldn't take too long to review. Mostly involves removing "preview" trappings. Cheers, -- Jim webrev:

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

Hi, Roger I noticed some other minor cleanup needed, will they be included in this fix, or separately in the future? 1. test/jdk/TEST.groups To remove `sun/tools/java` from core_tools and svc_tools group. (The only one test under `sun/tools/java` got removed in this patch.) 2.

Re: 8202469 / 8202473: Correct type annotation resolution for class type variables

Many thanks to Vicente for sponsoring this. I'll start to look at the second part shortly. cheers /Joel On Mon, Mar 16, 2020 at 9:44 PM Joel Borggrén-Franck < joel.borggren.fra...@gmail.com> wrote: > Looks good to me! > > I'll see if I can find a sponsor for this. > > cheers > /Joel > > On Sat,

Re: Use Method.getParameterCount() where possible

Thanks, pushed as https://bugs.openjdk.java.net/browse/JDK-8242208 /Claes On 2020-04-06 13:38, Chris Hegarty wrote: The changes look good to me. -Chris. On 6 Apr 2020, at 11:44, Claes Redestad wrote: Hi, looks good and trivial to me. I'll sponsor. /Claes (I hope we can wrap up

Re: Use Method.getParameterCount() where possible

The changes look good to me. -Chris. > On 6 Apr 2020, at 11:44, Claes Redestad wrote: > > Hi, > > looks good and trivial to me. I'll sponsor. > > /Claes > > (I hope we can wrap up https://bugs.openjdk.java.net/browse/JDK-8029019 > some day, soon) > > On 2020-04-03 12:19, Christoph Dreis

Re: RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

On 2020-04-06 13:22, Chris Hegarty wrote: Bug:https://bugs.openjdk.java.net/browse/JDK-8242186 Let me know if there are any concerns, otherwise I'll push once tier1 testing comes back green. Thanks! Thanks all for this nice micro-optimization. The changes look good to me. -Chris.

Re: RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

> On 6 Apr 2020, at 11:29, Claes Redestad wrote: > > Hi, > > (including net-dev@.. since this is in java.net) > > I intend to sponsor this trivial patch provided by Christoph: > > diff -r 65b345254ca3 > src/java.base/share/classes/java/net/URLStreamHandler.java > ---

Re: Use Method.getParameterCount() where possible

Hi, looks good and trivial to me. I'll sponsor. /Claes (I hope we can wrap up https://bugs.openjdk.java.net/browse/JDK-8029019 some day, soon) On 2020-04-03 12:19, Christoph Dreis wrote: Hi, I noticed that the JDK itself still uses Method.getParameterTypes().length in a couple of places.

RFR: 8242186: Reduce allocations in URLStreamHandler.parseURL for some cases (Was: Re: [NEW BUG] Small optimization in URLStreamHandler.parseURL)

Hi, (including net-dev@.. since this is in java.net) I intend to sponsor this trivial patch provided by Christoph: diff -r 65b345254ca3 src/java.base/share/classes/java/net/URLStreamHandler.java --- a/src/java.base/share/classes/java/net/URLStreamHandler.java Thu Apr 02 05:44:04 2020 +

Re: [PATCH] Trivial improvement for j.l.Character.toString() - 8241649: Optimize Character.toString

Good catch. Closed it as duplicate - also surprised myself that I didn't find this one when I did a cursory search in JBS for pre-existing issues. /Claes On 2020-04-06 07:24, Anirvan Sarkar wrote: JDK-8189375 should be closed as duplicate.