Hi,
nashorn modules were used only as an example in this test. Using
jdk.jshell module instead to test
known module dependencies in jlink produced images.
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8242860
Webrev: http://cr.openjdk.java.net/~sundar/8242860/webrev.00/
Thanks
Hi Sundar,
On 17/04/2020 4:00 am, sundararajan.athijegannat...@oracle.com wrote:
Thanks Daniel.
Fixed it. Updated webrev:
http://cr.openjdk.java.net/~sundar/8242931/webrev.02/
These changes seem okay in themselves.
Thanks,
David
PS. Submitting mach5 job concurrently.
Thanks,
-Sundar
O
Looks good.
As you noticed, the error does not seem to occur with JDK14 as bootjdk.
I will push it after I confirmed OK on my side. Thank you for your
contribution.
Naoto
On 4/16/20 12:26 PM, Philipp Kunz wrote:
Hi Naoto,
Changed as you suggested.
However, I could not verify it due to, mos
Hi Naoto,
Changed as you suggested.However, I could not verify it due to, most
probably totally unrelated, Error: Resolution failed: Module
jdk.scripting.nashorn.shell does not read a module that exports
jdk.internal.editor.spi.
Regards,Philipp
On Wed, 2020-04-15 at 11:14 -0700, naoto.s...@oracle.
Please review[2] and comment on a new Hex printing utility to support
OpenJDK tests.
The usefulness of a hex printing has been discussed from time to time with
many suggestions as to the API shape and features.
To get an idea of the API and features, take a look at the javadoc[1].
It covers the
Further update:
Good news. With the proper certs installed, I can notarize a pkg
installer generated by jpackage (from JDK-15). I have confirmed this
works both with pkg that is built with one jpackage command, and with
two a phase build (where an app-image is created by the first jpackag
On 4/16/20 11:42 AM, serguei.spit...@oracle.com wrote:
Hi Mandy,
I have a couple of minor comments on the Serviceability spec update.
http://cr.openjdk.java.net/~mchung/valhalla/webrevs/hidden-classes/webrev.06-svc-spec-changes/src/jdk.jdi/share/classes/com/sun/jdi/ReferenceType.java.udiff.h
On 16/04/2020 19:00, sundararajan.athijegannat...@oracle.com wrote:
Thanks Daniel.
Fixed it. Updated webrev:
http://cr.openjdk.java.net/~sundar/8242931/webrev.02/
LGTM
best regards,
-- daniel
PS. Submitting mach5 job concurrently.
Thanks,
-Sundar
Thanks Daniel.
Fixed it. Updated webrev:
http://cr.openjdk.java.net/~sundar/8242931/webrev.02/
PS. Submitting mach5 job concurrently.
Thanks,
-Sundar
On 16/04/20 11:16 pm, Daniel Fuchs wrote:
Hi Sundar,
I spotted a typo (generial vs generic) test/jdk/ProblemList.txt:
936 java/util/Serv
Hi Sundar,
I spotted a typo (generial vs generic) test/jdk/ProblemList.txt:
936 java/util/ServiceLoader/ReloadTest.java
8242935 generial-all
This is not an area I know well - so maybe wait for at least
another opinion (reviewer or not) but what I saw looked
reasonable.
You have my review.
OK - I approve. - I have tested on 2 platforms and it looks good.
/Andy
On 4/15/2020 4:13 PM, Alexey Semenyuk wrote:
Please review fix [2] for jpackage bug [1].
Refactor jpackage native code.
- Improve code reuse between different platforms.
- Replace custom string classes with the standard s
On 4/14/20 11:51 AM, Paul Sandoz wrote:
Looks good to me (not familiar with all the code areas.
Minor suggestion:
MethodHandles.java
1811 * ASCII periods. For the instance of {@link java.lang.Class}
representing {@code C}:
1812 *
1813 * {@link Class#getName()} ret
Please review updated webrev:
http://cr.openjdk.java.net/~sundar/8242931/webrev.01/
Thanks,
-Sundar
On 16/04/20 6:49 pm, David Holmes wrote:
+1 Please problem list the tests under the associated bug ids.
Thanks,
David
On 16/04/2020 11:10 pm, Alan Bateman wrote:
On 16/04/2020 13:59, sundara
Looks good thank you Claes
> On Apr 16, 2020, at 11:27 AM, Claes Redestad
> wrote:
>
> Lance,
>
> On 2020-04-16 16:33, Lance Andersen wrote:
>> I think this looks good. I few minor comments/suggestions:
>> * JavaUtilZipFileAccess.java:Please update the copyright
>> * JarFile.java: In getVe
Lance,
On 2020-04-16 16:33, Lance Andersen wrote:
I think this looks good. I few minor comments/suggestions:
* JavaUtilZipFileAccess.java:Please update the copyright
* JarFile.java: In getVersionEntry(), can we place break the if
statements onto two lines to make it a bit easier to re
Hi Claes,
Hi Claes,
I think this looks good. I few minor comments/suggestions:
JavaUtilZipFileAccess.java:Please update the copyright
JarFile.java: In getVersionEntry(), can we place break the if statements onto
two lines to make it a bit easier to read?
ZipFile.java: Perhaps add a comment
Hi Sundar,
Will there be a replacement for Nashorn, i.e. V8 with added Java bindings?
I am asking because one of the JFR test uses Nashorn for parsing JSON and if
another parser is coming in the near future, it could be used. instead of
adding a parser for the test.
Thanks
Erik
> On 16 Apr 20
+1 Please problem list the tests under the associated bug ids.
Thanks,
David
On 16/04/2020 11:10 pm, Alan Bateman wrote:
On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote:
Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript
Engine) missed updating few tests, con
On 16/04/2020 13:59, sundararajan.athijegannat...@oracle.com wrote:
Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript
Engine) missed updating few tests, config files.
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8242931
Webrev: http://cr.openjdk.java.net/~sund
Nashorn engine removal fix (8241749: Remove the Nashorn JavaScript
Engine) missed updating few tests, config files.
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8242931
Webrev: http://cr.openjdk.java.net/~sundar/8242931/webrev.00/
PS I'm disabling tests by adding @ignore. I've
Hi,
please review this patch to improve JarFile.getEntry performance
on multi-release jar files, mainly contributed by Eirik Bjørsnøs.
The main idea is to piggy-back on the scanning of meta-inf entries
we already do during initCEN to scan what versions exists in the
jar file. This then reduces t
Hi Eirik,
On 2020-04-16 13:47, Eirik Bjørsnøs wrote:
On Thu, Apr 16, 2020 at 12:59 PM Claes Redestad
mailto:claes.redes...@oracle.com>> wrote:
I think this is an interesting idea and a good optimization.
Looks like we get most of the performance win of Bloom filters while not
introduci
On Thu, Apr 16, 2020 at 12:59 PM Claes Redestad
wrote:
>
> I think this is an interesting idea and a good optimization.
Looks like we get most of the performance win of Bloom filters while not
introducing regressions for hits, footprint or complexity.
We'll
> deliberately cause a few more hash
Hi Volker,
On 2020-04-15 19:48, Volker Simonis wrote:
While doing this change, I've also realized that all the streams in
java.util.zip (i.e. DeflaterInputStream, GZIPInputStream,
GZIPOutputStream, InflaterInputStream, DeflaterOutputStream) use an
internal byte buffer of 512 bytes by default. Lo
Hi Johannes,
On 16/04/2020 08:28, Alan Bateman wrote:
java/util/logging/Handler
That's already logged as
https://bugs.openjdk.java.net/browse/JDK-8025709 (assigned to me)
I have never got to the point to start working on it
because it seems to be a very niche case: Handler
are usually attac
Hi,
I think this is an interesting idea and a good optimization. We'll
deliberately cause a few more hash collisions, but since we do half as
many hash table lookups in the normal case (and the streaming/iterators
shouldn't care) then that should be fine.
Some issues:
- Need to be made to work
updated the code, similar output. Disregard org/w3c/dom/html/HTMLDocument
https://gist.github.com/DasBrain/df25a69acf564dcb5f2241cc065be2ed
About java.xml.stream: A XMLStreamReader is for example constructed with:
BufferedReader br = ...;
XMLStreamReader xsr =
XMLInputFactory.newDefault
Am 2020-04-16 um 11:46 schrieb Alan Bateman:
On 16/04/2020 09:46, Osipov, Michael wrote:
Folks,
can some one, or Rob, explain why this class is explicitly tied to the
application class loader [1] when using the ServiceLoader? Is there
any specific implication when the thread context class
On 16/04/2020 09:46, Osipov, Michael wrote:
Folks,
can some one, or Rob, explain why this class is explicitly tied to the
application class loader [1] when using the ServiceLoader? Is there
any specific implication when the thread context class loader is used?
This makes it rather problemati
Folks,
can some one, or Rob, explain why this class is explicitly tied to the
application class loader [1] when using the ServiceLoader? Is there any
specific implication when the thread context class loader is used?
This makes it rather problematic using in a stacked class loader
environmen
Hi,
ZipEntry.getEntryPos currently has a double loop which retries search after
a failed lookup by appending a '/' to the name/hash. This means that any
miss needs to query the hash table twice.
The following patch updates hashN to truncate any '/' at the end of an
entry name. This ensures that t
On 16/04/2020 01:28, Johannes Kuhn wrote:
:
I did not restrict my enumeration to public and exported types - it
was easier not to do that and I'm lazy.
Most of the candidates that you've identified are JDK internal classes
and there are several non-public classes in exported packages. There ar
32 matches
Mail list logo
