Re: RFR: 8245455: Remove alternative StringConcatFactory strategies

2020-05-23 Thread Mandy Chung
Has that system property ever documented in CSR?    It's not in CSR for JEP 280 [1].   Maybe other CSR? Mandy [1] https://bugs.openjdk.java.net/browse/CCC-8085796 On 5/23/20 6:18 AM, David Holmes wrote: Hi Claes, You are removing a property so this needs a CSR request. Thanks, David On 22/0

Re: [BUG] java.util.Properties.entrySet() does not override java.lang.Object methods since Java 9

2020-05-23 Thread Rob Spoor
On 23/05/2020 21:13, Rob Spoor wrote: Hi, I was working on upgrading a library of mine from Java 8 to 11, and I noticed my unit tests started failing. Some investigation showed that in Java 9, java.util.Properties was rewritten to no longer rely on the fact that it extends Hashtable. One of t

[BUG] java.util.Properties.entrySet() does not override java.lang.Object methods since Java 9

2020-05-23 Thread Rob Spoor
Hi, I was working on upgrading a library of mine from Java 8 to 11, and I noticed my unit tests started failing. Some investigation showed that in Java 9, java.util.Properties was rewritten to no longer rely on the fact that it extends Hashtable. One of the changes was to use a private static

Re: Avoid allocations in Executable.getAllGenericParameterTypes

2020-05-23 Thread Claes Redestad
Hi Christoph, I agree this might not be called super often, but the refactoring is straightforward and I think it clarifies the intent of the code, so seems like a reasonable enhancement to make. I've already volunteered to sponsor another patch of yours, so I might as well pick this up too and

Re: RFR: 8245455: Remove alternative StringConcatFactory strategies

2020-05-23 Thread David Holmes
Hi Claes, You are removing a property so this needs a CSR request. Thanks, David On 22/05/2020 7:52 pm, Claes Redestad wrote: Hi, this patch removes the alternative, undocumented strategies from StringConcatFactory. The default strategy has been optimized and stabilized since inception in J

Re: [8u] RFR: 8244843: [JDK 8u] JapanEraNameCompatTest fails

2020-05-23 Thread Andrew Hughes
On 15/05/2020 10:22, Severin Gehwolf wrote: > Hi Andrew, > > Sigh, I only now realized that the bug number was missing the > subject. Fixed now. > snip... >>> >> >> Only issue with the patch itself is java.time.japanese.short.Eras is >> missing the new Reiwa era. I guess this is because 11u

Re: [aarch64-port-dev ] RFR (XXL): 8223347: Integration of Vector API (Incubator): AArch64 backend changes

2020-05-23 Thread Andrew Haley
On 5/22/20 7:01 PM, Paul Sandoz wrote: > We have made changes similar in spirit to the x64 ad file (reducing in size > at least), so I think it reasonable request before integration to reduce the > cognitive and maintenance burden. So here's a question: can the changes to the AArch64 back end be

Avoid allocations in Executable.getAllGenericParameterTypes

2020-05-23 Thread Christoph Dreis
Hi, I was looking through the code and found a relatively straight-forward optimization in Executable.getAllGenericParameterTypes (attached below). The idea is to simply move some code around to avoid unnecessary allocations from getParameters() or array initializations when working with generic