Re: RFR: 8242786: [macos] tools/jpackage/share/IconTest.java fails: ABORT trying to dequeue work

2020-05-24 Thread Andy Herrick
looks good /Andy On 5/22/2020 7:33 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Detach fails sometimes due to disk image being busy. Not sure what keeps disk image busy. Probably antivirus or something else. Within short period of time disk ima

Re: RFR: 8245455: Remove alternative StringConcatFactory strategies

2020-05-24 Thread David Holmes
After some offlist discussion it seems this is an undocumented property (not unlike a VM diagnostic option) and does not require a CSR request to remove. David On 24/05/2020 7:19 am, Mandy Chung wrote: Has that system property ever documented in CSR?    It's not in CSR for JEP 280 [1].   Mayb

Re: RFR: JDK-8225056 VM support for sealed classes

2020-05-24 Thread David Holmes
Hi Harold, On 22/05/2020 4:33 am, Harold Seigel wrote: Hi David, Thanks for looking at this!  Please review this new webrev: http://cr.openjdk.java.net/~hseigel/webrev.01/webrev/ I'll list all relevant commens here rather than interspersing below so that it is easier to track. Mostly ni

Re: [BUG] java.util.Properties.entrySet() does not override java.lang.Object methods since Java 9

2020-05-24 Thread Roger Riggs
Hi Rob, Thanks for the report, an issues has been created: https://bugs.openjdk.java.net/browse/JDK-8245694 Regards, Roger On 5/23/20 3:13 PM, Rob Spoor wrote: Hi, I was working on upgrading a library of mine from Java 8 to 11, and I noticed my unit tests started failing. Some investigation