Re: RFR: JDK-8245432: Lookup::defineHiddenClass should throw UnsupportedClassVersionError if the given bytes are of an unsupported major or minor version

On 5/29/20 4:31 PM, Johannes Kuhn wrote: Thanks. Noted that readInt can read outside of the byte array when it is shorter than 4 bytes, throwing an ArrayIndexOutOfBoundsException. Same applies for readUnsignedShort. Test cases for malformedClassFiles: new byte[3], new byte[] {0xCA, 0xFE, 0

Re: RFR: JDK-8225056 VM support for sealed classes

Hi Harold, On 1/06/2020 8:57 am, Harold Seigel wrote: Thanks for the comments. Here's version 3 of the JDK and VM changes for sealed classes. full webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.3/webrev/ The new webrev contains just the following three changes: 1. The s

Re: Sometimes constraints are questionable

I'm still not deeply reading the code in java.nio but I see in AbstractStringBuilder * Will not return a capacity greater than * {@code (MAX_ARRAY_SIZE >> coder)} unless the given minimum capacity * is greater than that. My intent was that a garden variety grow method would first g

Re: Sometimes constraints are questionable

On 1/06/2020 9:52 am, Martin Buchholz wrote: On Sun, May 31, 2020 at 4:35 PM David Holmes wrote: Not sure how we could have minCapacity < 0 at this point. It should have been checked before the call to grow, and grow will not make it negative. At least some of the grow methods were designed

Re: Sometimes constraints are questionable

On Sun, May 31, 2020 at 4:35 PM David Holmes wrote: > Not sure how we could have minCapacity < 0 at this point. It should have > been checked before the call to grow, and grow will not make it negative. At least some of the grow methods were designed so that callers did not have to do the checki

Re: Sometimes constraints are questionable

On 31/05/2020 12:29 am, Jim Laskey wrote: I'm working through https://bugs.openjdk.java.net/browse/JDK-8230744 Several classes throw OutOfMemoryError without message . I'm wondering why hugeCapacity in src/jdk.zipfs/share/classes/jdk/nio/zipf

Re: RFR: JDK-8225056 VM support for sealed classes

Thanks for the comments. Here's version 3 of the JDK and VM changes for sealed classes. full webrev: http://cr.openjdk.java.net/~hseigel/sealedClasses.8225056.3/webrev/ The new webrev contains just the following three changes: 1. The sealed classes API's in Class.java (permittedSubclasses()

Re: RFR: 8232841: [TESTBUG] [macos] SigningPackageTest fails when untrusted certificates exist on machine

Looks good. - Alexey On 5/29/2020 7:39 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - I was not able to reproduce this issue. Not sure why this command returns non zero code in some cases. It still returns output which we need, so fixed by ignori

Re: RFR: JDK-8246010: AdditionalLaunchersTest is not enabled, and fails.

Please revice revised webrev at [3] I have revised to only throw FileServiceException right before operations that will fail. [3] webrev: http://cr.openjdk.java.net/~herrick/8246010/webrev.02 /Andy On 5/29/2020 7:38 PM, Andy Herrick wrote: On 5/29/20 7:16 PM, Alexey Semenyuk wrote: Andy,