Hi Alexey,
Looks good. Only suggestion is to move CmdlineExecutor to Executor class
and make it configurable for error message and probably attempts and
timeout in case if we need such functionality in other places.
Thanks,
Alexander
On 7/8/20 6:37 PM, Alexey Semenyuk wrote:
Please review
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8248261/webrev.01/
- Added fatalError() to log fatal errors without timestamp.
- Added missing timestamp to Log.verbose(Throwable t).
Thanks,
Alexander
On 7/8/20 9:34 AM, Alexey Semenyuk wrote:
I still think it would be good to create dedicated
Please review fix [2] for jpackage bug [1].
Sometimes jpackage fails building .deb package due to failure of
`fakeroot` command with the same error message printed in stderr:
`semop(1): encountered an error: Invalid argument`.
The suggested fix is to rerun `fakeroot` command if it fails and
Hi Martin,
Yep, there are number of other ways stack could have been handled.
Another one might be to not "commit" all the stack memory until it is
needed.
So it takes up address space, but not memory; still not a perfect way.
I haven't looked to see if the 64k network stack buffer that is
Approved.
As author of the small stack size for the reaper thread, I'm sorry
it's caused so much trouble.
But as always, the proper solution is to fix the java runtime so that
fixed allocations like this are unnecessary.
hard: stack size should not include native overhead like shadow pages.
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/8/20 9:18 AM, Alexey Semenyuk wrote:
Looks good.
- Alexey
On 7/8/2020 10:34 AM, Andy Herrick wrote:
Please review change at [1] to issue [2] removing the
"--bind-services" option from jpackage.
/Andy
[1]
Thanks for the fast review.
I was surprised that jcheck -r tip didn't flag that, but... :-)
Dan
On 7/8/20 5:23 PM, igor.ignat...@oracle.com wrote:
LGTM, thanks for fixing, and sorry for introducing that.
— Igor
On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty
wrote:
Greetings,
A
LGTM, thanks for fixing, and sorry for introducing that.
— Igor
> On Jul 8, 2020, at 2:22 PM, Daniel D. Daugherty
> wrote:
>
> Greetings,
>
> A trivial fix to make the validate-header Tier1 task happy.
>
> Here's the context diff:
>
> $ hg diff -r qparent
> diff -r c5202ed40b86
Greetings,
A trivial fix to make the validate-header Tier1 task happy.
Here's the context diff:
$ hg diff -r qparent
diff -r c5202ed40b86 test/lib/jdk/test/lib/util/JarBuilder.java
--- a/test/lib/jdk/test/lib/util/JarBuilder.java Wed Jul 08 20:35:36
2020 +0100
+++
Hi Raffaello,
Thank you for your taking up this issue. When working on a fix such as this,
it is best to keep the changes narrowly focused to the issue at hand and not
attempt to address additional issues within the same fix (though this can be
tempting).
To move forward, I would suggest
Please reveiw a change to increase the size of the Process Reaper stack
for debug builds.
This intermittent issue can be traced to the stack shadow page size
being larger
in debug builds than in release builds. The problem has only been
spotted in debug builds.
diff
Hi Leo,
Looks good to me.
Naoto
On 7/8/20 10:58 AM, li.ji...@oracle.com wrote:
Hi,
Pls review the l10n resource files update for JDK 15 msg drop 10.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8249086
Webrev:
http://cr.openjdk.java.net/~ljiang/8249086/read/
Thanks,
Leo
Hello Roger,
I would of course retract the changes in encodedOutLength() because, as
you observe, it is out of scope w.r.t. the bug. I would also retract the
other minor changes you mention and clean up the appearance of the
comments to adhere to community shared practices.
Thus, if you
On 7/8/20 11:21 AM, Bob Vandette wrote:
On Jul 8, 2020, at 1:01 PM, Mandy Chung wrote:
On 7/8/20 9:40 AM, Bob Vandette wrote:
Should I add an assert or just let the NPE happen?
What about Objects.requireNonNull(m);
Thanks.
Here’s the updated webrev:
> On Jul 8, 2020, at 1:01 PM, Mandy Chung wrote:
>
>
>
> On 7/8/20 9:40 AM, Bob Vandette wrote:
>> Should I add an assert or just let the NPE happen?
>
> What about Objects.requireNonNull(m);
Thanks.
Here’s the updated webrev:
https://cr.openjdk.java.net/~bobv/8249080/webrev.02/
Hi,
Pls review the l10n resource files update for JDK 15 msg drop 10.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8249086
Webrev:
http://cr.openjdk.java.net/~ljiang/8249086/read/
Thanks,
Leo
On 7/8/20 9:40 AM, Bob Vandette wrote:
Should I add an assert or just let the NPE happen?
What about Objects.requireNonNull(m);
Mandy
Hi Rafaello,
Since you have expanded the scope of the fix, you will need to update
the bug to
include the other changes you are making. Or create a new issue for the
additional work.
Personal preference in style has very little place when maintaining
existing code.
The style should match
> On Jul 8, 2020, at 12:08 PM, Mandy Chung wrote:
>
>
>
> On 7/8/20 8:19 AM, Bob Vandette wrote:
>> Please review this RFE for JDK 16 that reduces a class dependency in the
>> MethodHandles.Lookup class.
>>
>> The ensureInitialized method from MethodHandles.Lookup creates a transient
>>
I still think it would be good to create dedicated method for final
error reporting in Main and Arguments classes without timestamps.
- Alexey
On 7/8/2020 9:59 AM, Andy Herrick wrote:
After further discussion, I approve this change as is.
The main fatal error in Arguments.processArguments()
Looks good.
- Alexey
On 7/8/2020 10:34 AM, Andy Herrick wrote:
Please review change at [1] to issue [2] removing the
"--bind-services" option from jpackage.
/Andy
[1] http://cr.openjdk.java.net/~herrick/8248864/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8247779
On 7/8/20 8:19 AM, Bob Vandette wrote:
Please review this RFE for JDK 16 that reduces a class dependency in the
MethodHandles.Lookup class.
The ensureInitialized method from MethodHandles.Lookup creates a transient
MemberName object only
to be used to throw an exception. This exception can
Please review this RFE for JDK 16 that reduces a class dependency in the
MethodHandles.Lookup class.
The ensureInitialized method from MethodHandles.Lookup creates a transient
MemberName object only
to be used to throw an exception. This exception can be created in a more
efficient manner
Thanks Sean, Alexey,
On 08/07/2020 13:25, Sean Mullan wrote:
Updated webrev : http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v12/
You will also need to update the CSR to remove the connection timeout
property.
Also, you should document the "com.sun.jndi.ldap.tls.cbtype" property in
Please review change at [1] to issue [2] removing the "--bind-services"
option from jpackage.
/Andy
[1] http://cr.openjdk.java.net/~herrick/8248864/webrev.01/
[2] https://bugs.openjdk.java.net/browse/JDK-8247779
After further discussion, I approve this change as is.
The main fatal error in Arguments.processArguments() only calls
Log.error if not verbose , so guarding it from having a timestamp when
verbose is not an issue.
/Andy
On 7/7/2020 7:20 PM, Andy Herrick wrote:
I agree - but I would rather
On 7/7/20 12:29 PM, Alexey Bakhtin wrote:
Hello Sean,
Thank you for review.
You are right, we can eliminate requirements for connection timeout property.
I’ve added handshakeComletedListener to the LDAP over SSl. In this case we’ll
have no possible performance impact caused by synchronous
Hi Andrew
I have updated this patch. Could you please help to review it again?
In this patch, the following changes are made:
1. Separate newly added NEON instructions to a new ad file
aarch64_neon.ad
2. Add assembler tests for NEON instructions. Trailing spaces
in the python script are
28 matches
Mail list logo
