On 7/13/2020 9:04 PM, naoto.s...@oracle.com wrote:
Hi Joe,
On 7/13/20 7:28 PM, Joe Wang wrote:
On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for your review.
On 7/13/20 3:55 PM, Joe Wang wrote:
Hi Naoto,
Would it make sense to provide an additional test using
Hi Joe,
On 7/13/20 7:28 PM, Joe Wang wrote:
On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for your review.
On 7/13/20 3:55 PM, Joe Wang wrote:
Hi Naoto,
Would it make sense to provide an additional test using the public
APIs similar to the one provided in the bug
On 7/13/2020 7:01 PM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for your review.
On 7/13/20 3:55 PM, Joe Wang wrote:
Hi Naoto,
Would it make sense to provide an additional test using the public
APIs similar to the one provided in the bug report? I'm sure yours is
correct and covers
Hi Joe,
Thank you for your review.
On 7/13/20 3:55 PM, Joe Wang wrote:
Hi Naoto,
Would it make sense to provide an additional test using the public APIs
similar to the one provided in the bug report? I'm sure yours is correct
and covers more cases than the original, but it would be nice to
looks good
/Andy
On 7/13/2020 8:35 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
Added missing ",".
[1] https://bugs.openjdk.java.net/browse/JDK-8249264
[2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/
Thanks,
Alexander
LGTM
— Igor
> On Jul 13, 2020, at 5:35 PM, alexander.matv...@oracle.com wrote:
>
> Please review the jpackage fix for bug [1] at [2].
>
> Added missing ",".
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8249264
> [2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/
>
> Thanks,
>
Please review the jpackage fix for bug [1] at [2].
Added missing ",".
[1] https://bugs.openjdk.java.net/browse/JDK-8249264
[2] http://cr.openjdk.java.net/~almatvee/8249264/webrev.00/
Thanks,
Alexander
Hi Naoto,
Would it make sense to provide an additional test using the public APIs
similar to the one provided in the bug report? I'm sure yours is correct
and covers more cases than the original, but it would be nice to have an
actual use case and use the public APIs. The report showed it was
Hi Chris,
Thank you for jumping in at the deep end and reviewing.
I fixed the typos and sent a review of a patch on the panama-dev list [1], to
be pushed in the panama repo and rolled back in to patches at some point,
likely with other updates to expand testing to cover more API points.
Hi Andy,
Looks good.
Thanks,
Alexander
On 7/13/2020 1:26 PM, Andy Herrick wrote:
please review trivial jpackage fix to issue [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8248687
[2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/
/Andy
looks good.
/Andy
On 7/13/2020 4:39 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
EmptyFolderPackageTest.java added to ProblemList.
[1] https://bugs.openjdk.java.net/browse/JDK-8249256
[2] http://cr.openjdk.java.net/~almatvee/8249256/webrev.00/
Please review the jpackage fix for bug [1] at [2].
EmptyFolderPackageTest.java added to ProblemList.
[1] https://bugs.openjdk.java.net/browse/JDK-8249256
[2] http://cr.openjdk.java.net/~almatvee/8249256/webrev.00/
Thanks,
Alexander
please review trivial jpackage fix to issue [1] at [2]
[1] https://bugs.openjdk.java.net/browse/JDK-8248687
[2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/
/Andy
Thanks Mandy. Pushed to the mainline/16 repo.
-Joe
On 7/13/20 10:13 AM, Mandy Chung wrote:
Looks okay. Same as Alan's comment, I don't see there is any urgency
to fix this in 15. Fixing it in 16 is fine.
Mandy
On 7/12/20 3:21 PM, Joe Wang wrote:
Hi all,
Alan updated the bug to
> On 1 Apr 2020, at 23:46, Paul Sandoz wrote:
>
> Hi,
>
> A prior email sent out a request for review of the Vector API in preparation
> for JEP 338: Vector API (Incubator) [1] to be proposed for target:
>
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-March/065345.html
>
+1
- Alexey
On 7/10/2020 6:29 PM, Andy Herrick wrote:
looks good.
/Andy
On 7/9/2020 12:02 AM, alexander.matv...@oracle.com wrote:
Hi Alexey,
http://cr.openjdk.java.net/~almatvee/8248261/webrev.01/
- Added fatalError() to log fatal errors without timestamp.
- Added missing timestamp to
Looks okay. Same as Alan's comment, I don't see there is any urgency
to fix this in 15. Fixing it in 16 is fine.
Mandy
On 7/12/20 3:21 PM, Joe Wang wrote:
Hi all,
Alan updated the bug to indicate it fails since JDK 9. Given we still
have a couple days for JDK 15, I've rebased the patch
On 02/07/2020 20:34, Ivan Sipka wrote:
Hi all,
please review the following changeset:
http://cr.openjdk.java.net/~iignatyev/isipka/8242935/webrev.00/
for the JBS issue https://bugs.openjdk.java.net/browse/JDK-8242935
which replaces Nashorn scripting engine in a service reload test with
On 7/12/20 11:11 PM, Alan Bateman wrote:
On 12/07/2020 23:21, Joe Wang wrote:
Hi all,
Alan updated the bug to indicate it fails since JDK 9. Given we still
have a couple days for JDK 15, I've rebased the patch to the jdk15
repo and would like to check in the patch into JDK 15 instead (and
Hi Lance
Thanks for the detailed review. I will go ahead and look into the required
documentation changes.
Thanks & Regards
Vipin MV
Ping.
On 7/7/20 3:55 PM, naoto.s...@oracle.com wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8248695
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8248695/webrev.00/
There were two causes that resulted in
Hi Daniel,
On 2020/07/09 18:16, Daniel Fuchs wrote:
> Hi Koichi,
>
> If you don't mind I'd prefer to keep the simple approach
> that will fix the warning without changing the behavior
> of the function.
I understand that. I respect your idea.
I fixed the patch as follows.
By the way,
On 12/07/2020 23:21, Joe Wang wrote:
Hi all,
Alan updated the bug to indicate it fails since JDK 9. Given we still
have a couple days for JDK 15, I've rebased the patch to the jdk15
repo and would like to check in the patch into JDK 15 instead (and let
it be sync-ed to 16). Here's the webrev
23 matches
Mail list logo
