Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

Hi Anthony, Since short-circuiting sounds similar to a Subscriber cancelling its Subscription, I believe it might be worthwhile to consider the Flow API. If the argument would be a `Flow.Processor`, then the implementation would publish instances of T to it, subscribe to receive instances of

Re: RFR: 8245527: LDAP Cnannel Binding support for Java GSS/Kerberos

Hi Alexey, On 10/07/2020 21:37, Alexey Bakhtin wrote: Updated webrev:http://cr.openjdk.java.net/~abakhtin/8245527/webrev.v14/ In what the JNDI part is concerned this looks good to me now. nit: java.naming/share/classes/com/sun/jndi/ldap/sasl/TlsChannelBinding.java: 138 }catch(NoSuch

RFR 824767: Incorrect class name displayed in DriverManager trace output

Hi all, Please review this trivial fix for https://bugs.openjdk.java.net/browse/JDK-8247677 , which addresses a couple of typos where the driver class name was not included in the trace output from DriverManager. ——— $ hg diff diff -r e92

Re: RFR: JDK-8222187: java.util.Base64.Decoder stream adds unexpected null bytes at the end

Hi Roger, here's the latest version of the patch. I did: * Withdraw the simplification in encodedOutLength(), as it is indeed out of scope for this bug fix. * Restore field names in DecInputStream except for nextin (now wpos) and nextout (now rpos) because they have slightly different semantic

RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

The test was failing on a newly added mac mini. I've reduced the memory stress by introducing a shared maximum sized string. I don't recommend reducing the 4G memory requirement -- multiple new large objects are constructed in the tests hoping to create an OOM. JBS: https://bugs.openjdk.java.ne

Re: RFR 824767: Incorrect class name displayed in DriverManager trace output

+1 Joe On 7/14/20 8:41 AM, Lance Andersen wrote: Hi all, Please review this trivial fix for https://bugs.openjdk.java.net/browse/JDK-8247677 , which addresses a couple of typos where the driver class name was not included in the trace output

Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

Adding Daniel > Begin forwarded message: > > From: Jim Laskey > Subject: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed > due to OOM (JDK 15) > Date: July 14, 2020 at 2:01:09 PM ADT > To: core-libs-dev > > The test was failing on a newly added mac mini. I've reduced the

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

On 7/14/20 2:09 PM, Jim Laskey wrote: Adding Daniel Begin forwarded message: *From: *Jim Laskey > *Subject: **RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)* *Date: *July 14, 2020 at 2:01:09 PM ADT *To: *core-libs-dev

Re: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Hi Koichi, On 13/07/2020 08:03, Koichi Sakata wrote: > I understand that. I respect your idea. > I fixed the patch as follows. The changes to NetworkInterface.c look good to me. > > By the way, k_standard.c still remains. Is there a way to proceed with it? You'll need to find a reviewer that

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

Looks good. Though it does seem like the VM should have been able to reclaim enough memory between tests to not need to throw OOME. Thanks, Roger On 7/14/20 2:23 PM, Daniel D. Daugherty wrote: On 7/14/20 2:09 PM, Jim Laskey wrote: Adding Daniel Begin forwarded message: *From: *Jim Laske

Re: RFR: JDK-8248687: JPackage test extension misspelled "extention"

Looks good. - Alexey On 7/13/2020 4:26 PM, Andy Herrick wrote: please review trivial jpackage fix to issue [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8248687 [2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/ /Andy

Re: RFR: JDK-8248687: JPackage test extension misspelled "extention"

+1 -phil On 7/13/20, 1:26 PM, Andy Herrick wrote: please review trivial jpackage fix to issue [1] at [2] [1] https://bugs.openjdk.java.net/browse/JDK-8248687 [2] http://cr.openjdk.java.net/~herrick/8248687/webrev.01/ /Andy

Re: Fwd: RFR: JDK-8249258 java/util/StringJoiner/StringJoinerTest.java failed due to OOM (JDK 15)

On 15/07/2020 5:35 am, Roger Riggs wrote: Looks good. Though it does seem like the VM should have been able to reclaim enough memory between tests to not need to throw OOME. I'd have to agree with that - something seems strange here. The first OOME in OOM1 is not actually Java heap exhaustio