http://cr.openjdk.java.net/~iignatyev//8249698/webrev.00
> 3 lines changed: 1 ins; 1 del; 1 mod;
Hi all,
could you please review this trivial patch which removes @ignore from
LFGarbageCollectedTest and adds it into problem-list instead?
from 8249698:
>
http://cr.openjdk.java.net/~iignatyev/8249697/webrev.00/
> 7 lines changed: 4 ins; 0 del; 3 mod;
Hi all,
could you please review this small and trivial patch for
java/lang/invoke/RicochetTest.java test?
from JBS:
> a run of java/lang/invoke/RicochetTest.java w/ MAX_ARITY=255 was removed from
Hi Alexey,
Fixed as per your suggestion:
http://cr.openjdk.java.net/~almatvee/8245311/webrev.01/
Thanks,
Alexander
On 7/17/20 4:26 PM, Alexey Semenyuk wrote:
Alexander,
The change in RetryExecutor.java results in Executor instance created
only once and not every time command line should be
+1
Brian
> On Jul 17, 2020, at 4:56 PM, Mandy Chung wrote:
>
> +1
> Mandy
>
> On 7/17/20 4:04 PM, Joe Darcy wrote:
>> A few more cases found with scripted assistance from Mikael; updated webrev:
>>
>> http://cr.openjdk.java.net/~darcy/8249687.1
>>
+1
Mandy
On 7/17/20 4:04 PM, Joe Darcy wrote:
A few more cases found with scripted assistance from Mikael; updated
webrev:
http://cr.openjdk.java.net/~darcy/8249687.1
Patches for new files below.
Thanks,
-Joe
--- old/src/java.base/share/classes/java/lang/StackTraceElement.java
Hi,
Based on the suggestions, I modified the fix as follows:
https://cr.openjdk.java.net/~naoto/8248655.8248434/webrev.01/
Changes from the initial revision are:
- Shared the implementation between compareToCI() and regionMatchesCI()
- Enabled immediate short cut if two code points match.
-
Alexander,
The change in RetryExecutor.java results in Executor instance created
only once and not every time command line should be executed.
I'd suggest to have
---
void execute(String cmdline[]) throws IOException {
executeLoop(() -> Executor.of(cmdline));
}
private void
Hi Joe,
+1
Brian
> On Jul 17, 2020, at 3:03 PM, Joe Darcy wrote:
>
> Following-up on JDK-8237805 and some recent observations from Mikael V.,
> there are more locations in the base module where in-line @jls and @jvms tags
> are appropriate to use. Please review their addition:
>
>
Hello,
Following-up on JDK-8237805 and some recent observations from Mikael
V., there are more locations in the base module where in-line @jls and
@jvms tags are appropriate to use. Please review their addition:
http://cr.openjdk.java.net/~darcy/8249687.0/
I checked that the sections
Hi Vladimir and Coleen,
We are getting ready to propose to target Vector API to JDK 16.
Please find below the updated hotspot and x86 backend changes:
Shared Hotspot:
Full: http://cr.openjdk.java.net/~sviswanathan/VAPI_RFR/hs_webrev/webrev.01/
Incremental:
Looks OK - I approve.
/Andy
On 7/15/2020 7:29 PM, alexander.matv...@oracle.com wrote:
Please review the jpackage fix for bug [1] at [2].
- "hdiutil detach" resource busy error is fixed in same way as
JDK-8242786 by repeating detach several times.
- pkgbuild timeout will be covered with
If you are going to change makefiles you need to get review on
build-...@openjdk.java.net :)
David
On 17/07/2020 11:48 pm, Yasumasa Suenaga wrote:
Hi Koichi,
On 2020/07/17 20:26, Koichi Sakata wrote:
Hi Daniel,
> The changes to NetworkInterface.c look good to me.
Thank you.
> You'll
Hi Koichi,
On 2020/07/17 20:26, Koichi Sakata wrote:
Hi Daniel,
> The changes to NetworkInterface.c look good to me.
Thank you.
> You'll need to find a reviewer that understands what that
> method is supposed to do in that case, that's not me ;-)
I understand. This ML is suitable for
Hi Daniel,
> The changes to NetworkInterface.c look good to me.
Thank you.
> You'll need to find a reviewer that understands what that
> method is supposed to do in that case, that's not me ;-)
I understand. This ML is suitable for finding a reviewer, isn't it?
Or, there is another way. We
14 matches
Mail list logo
