Re: RFR[M]: Adding MD5 Intrinsic on x86-64

It looks like you created webrev based on old state of jdk or its branch. Your vm_version_aarch64.cpp change did not apply to latest jdk source. There are also few copyright year updates for files which already have it. I fixed it and start new round of testing. Vladimir K On 8/4/20 7:09 PM, Lu

Re: JDK 16 RFR of JDK-8250920: Increase @jls usage in core reflection

+1 Mandy On 8/4/20 7:42 PM, Joe Darcy wrote: Hello, While JDK-8250660: "Clarify that WildcardType and AnnotatedWildcardType bounds methods return one" is still under discussion, please review a change for     JDK-8250920: Increase @jls usage in core reflection     http://cr.openjdk.java.ne

JDK 16 RFR of JDK-8250920: Increase @jls usage in core reflection

Hello, While JDK-8250660: "Clarify that WildcardType and AnnotatedWildcardType bounds methods return one" is still under discussion, please review a change for     JDK-8250920: Increase @jls usage in core reflection     http://cr.openjdk.java.net/~darcy/8250920.0/ which adds @jls tags for th

RE: RFR[M]: Adding MD5 Intrinsic on x86-64

Webrev: http://cr.openjdk.java.net/~luhenry/8250902/webrev.03 > I think you need to set flag to false (to overwrite setting on command line) > in vm_version_*.cpp files on all other CPUs until they have implementation: Fixed. > Also I forgot to ask to update copyright year in files you touched

Re: RFR[M]: Adding MD5 Intrinsic on x86-64

Hi Ludovic, Tests are mostly clean so far except: new 3 MD5 tests failed on aarch64 because UseMD5Intrinsics flag is 'true' incorrectly: bool UseMD5Intrinsics = true {diagnostic} {command line} compiler/intrinsics/sha/sanity/TestMD5MultiBlockIntrinsics.java compiler/intrinsics/sha/sanity

Re: RFR[M]: Adding MD5 Intrinsic on x86-64

Good. I will run Hotspot and JDK testing and let you know results. Regards, Vladimir K On 8/4/20 1:21 PM, Ludovic Henry wrote: Webrev: http://cr.openjdk.java.net/~luhenry/8250902/webrev.03 Testing: everything passes with hotspot:tier1 and jdk:tier1 in fastdebug on Linux-x64. I would leave t

Can sun.misc.Unsafe.throwException() be removed?

From my understanding, Unsafe.throwException throws the passed Throwable, more commonly known as "snaky throws". There are other ways to archive the same result, one commonly found is by (ab)using generics:     public static void sneakyThrows(Throwable t) throws T {     throw (T) t;   

RE: RFR[M]: Adding MD5 Intrinsic on x86-64

Webrev: http://cr.openjdk.java.net/~luhenry/8250902/webrev.03 Testing: everything passes with hotspot:tier1 and jdk:tier1 in fastdebug on Linux-x64. > I would leave this investigation to Intel's Java group. They are expert in > this area! Ok, we'll reach out to Intel on our end as well to figur

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

Looks good. - Alexey On 8/4/2020 1:05 AM, alexander.matv...@oracle.com wrote: Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey Semen

Re: [16] 8251017: java/io/File/GetXSpace.java fails on UNIX

Thanks, Naoto. I’ll hold off pushing it until the review in [2] is done. Brian > On Aug 4, 2020, at 10:41 AM, naoto.s...@oracle.com wrote: > > Looks good, Brian. > > Naoto > > On 8/4/20 9:01 AM, Brian Burkhalter wrote: >> Add @requires tag for [1]. This patch is layered on top of that proposed

Re: [16] 8251017: java/io/File/GetXSpace.java fails on UNIX

Looks good, Brian. Naoto On 8/4/20 9:01 AM, Brian Burkhalter wrote: Add @requires tag for [1]. This patch is layered on top of that proposed in [2]. --- a/test/jdk/java/io/File/GetXSpace.java +++ b/test/jdk/java/io/File/GetXSpace.java @@ -24,6 +24,7 @@ /** * @test * @bug 4057701 628671

Re: RFR[M]: Adding MD5 Intrinsic on x86-64

Hi Ludovic, On 8/3/20 9:07 PM, Ludovic Henry wrote: Updated webrev: http://cr.openjdk.java.net/~luhenry/8250902/webrev.02 Next code in inline_digestBase_implCompressMB should be reversed (get_long_*() should be called for long_state): if (long_state) { state = get_state_from_digest

[16] 8251017: java/io/File/GetXSpace.java fails on UNIX

Add @requires tag for [1]. This patch is layered on top of that proposed in [2]. --- a/test/jdk/java/io/File/GetXSpace.java +++ b/test/jdk/java/io/File/GetXSpace.java @@ -24,6 +24,7 @@ /** * @test * @bug 4057701 6286712 6364377 + * @requires (os.family == "linux" | os.family == "mac" | os.fam

Re: RFR: 8250646: hdiutil detach fix JDK-8245311 still fails sometimes

looks good /Andy On 8/4/2020 1:05 AM, alexander.matv...@oracle.com wrote: Hi Alexey, http://cr.openjdk.java.net/~almatvee/8250646/webrev.02/ I removed stop method. Also, if we called abort from MacDMGBundler exception will be ignored. Thanks, Alexander On 8/3/20 10:10 AM, Alexey Semenyuk

RE: RFR 6470126 java.util.jar.Attributes#containsKey fails with Strings

Hi, Since, the use of strings and Attributes.Name is distributed over APIs, I have come up with a generic documentation. However any suggestions are welcome. --- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Mar 26 15:26:51 2020 + +++ b/src/java.base/share/classes/java/uti