Re: [11u] RFR[M]: 8250902: Implement MD5 Intrinsics on x86

2020-08-08 Thread Vladimir Kozlov
On 8/8/20 10:30 AM, Ludovic Henry wrote: Hi Andrew, Vladimir, It's too early for that: changes are supposed to bake in JDK head for a while. Also, since it's an enhancement rather than a bug fix we'd need to have the discussion. I would say it's marginal whether something like this should be ba

RE: [11u] RFR[M]: 8250902: Implement MD5 Intrinsics on x86

2020-08-08 Thread Ludovic Henry
Hi Andrew, Vladimir, > It's too early for that: changes are supposed to bake in JDK head for > a while. Also, since it's an enhancement rather than a bug fix we'd > need to have the discussion. I would say it's marginal whether > something like this should be back ported. > Usually we backport on

Re: RFR: JDK-8244288 Specialized implementations for putIfAbsent, merge, compute* methods in TreeMap derived maps

2020-08-08 Thread Paul Sandoz
Hi Tagir, Clearly I am a terribly tracker of null values! My apologies for the poor review of that. Regarding changing sub-map computeIfAbsent and compute behavior, yes that would require a CSR. Thinking more about this, it may be better to play it safe and retain the current behavior for thi

Re: [11u] RFR[M]: 8250902: Implement MD5 Intrinsics on x86

2020-08-08 Thread Andrew Haley
On 8/8/20 5:30 AM, Ludovic Henry wrote: > I would like to backport the newly added MD5 Intrinsic to JDK 11. It's too early for that: changes are supposed to bake in JDK head for a while. Also, since it's an enhancement rather than a bug fix we'd need to have the discussion. I would say it's margi

Re: RFR: 8245036: DataInputStream.readFully(byte[], int, int) does not throw expected IndexOutOfBoundsExceptions

2020-08-08 Thread Raffaello Giulietti
Thanks Brian for pushing On 2020-08-07 23:12, Brian Burkhalter wrote: On Aug 7, 2020, at 9:39 AM, Brian Burkhalter mailto:brian.burkhal...@oracle.com>> wrote: There's one corner case that would not pass, however, so I added testNegativeOffsetZeroLength() to exercise that. It passes on the n

[11u] RFR[M]: 8250902: Implement MD5 Intrinsics on x86

2020-08-08 Thread Ludovic Henry
Hello, I would like to backport the newly added MD5 Intrinsic to JDK 11. The change is contained, limiting the chance of a regression, and provides a great speedup on a common pattern. This change also contains the follow-up fix by Vladimir Kozlov. As it is the first backport I go through, ple