Re: Fix for Javadoc errors in java.base

Hi Vipin, My review comments on the files I look after is interspersed below. On 7/27/2020 10:28 PM, Vipin Sharma wrote: Hi Joe, I ran an IntelliJ inspection to find these errors. Regards, Vipin

Re: RFR: JDK-8232621: L10n issues with msi installers

Hi Alexey, Looks good. Thanks, Alexander On 8/10/20 9:09 AM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix adds ability to jpackage to hook up custom WiX localization files from resource directory. This allows to create .msi installers with custom locales, not j

RFR(S): 8248188 Add HotSpotIntrinsicCandidate and API for Base64 decoding (repost to correct mailing list)

Hello, I had originally made two posts to the hotspot-compiler-dev and ppc-aix-port-dev mailing lists, but since this RFR requires modifying the core library code, it makes sense to post it to core-lib-devs instead. The two original posts: https://mail.openjdk.java.net/pipermail/ppc-aix-port

Re: RFR: JDK-8232621: L10n issues with msi installers

looks good to me. /ANdy On 8/10/2020 12:09 PM, Alexey Semenyuk wrote: Please review fix [2] for jpackage bug [1]. The fix adds ability to jpackage to hook up custom WiX localization files from resource directory. This allows to create .msi installers with custom locales, not just with three

RFR: JDK-8232621: L10n issues with msi installers

Please review fix [2] for jpackage bug [1]. The fix adds ability to jpackage to hook up custom WiX localization files from resource directory. This allows to create .msi installers with custom locales, not just with three locales supported by OpenJDK. - Alexey [1] https://bugs.openjdk.java.n

Re: [16] 8251017: java/io/File/GetXSpace.java fails on UNIX

The patch addresses only the situation in the comments, excluding the test on AIX. A separate issue should be filed to address the NFS mounts situation. Thanks, Brian > On Aug 10, 2020, at 6:14 AM, Baesken, Matthias > wrote: > > Hi Arno yes I think so ; the NFS issue seems to appear on Linux

RE: [16] 8251017: java/io/File/GetXSpace.java fails on UNIX

Hi Arno yes I think so ; the NFS issue seems to appear on Linux quite often , noticed it a number of times in our nightly tests . Best regards, Matthias -Original Message- From: Zeller, Arno Sent: Montag, 10. August 2020 14:58 To: Brian Burkhalter Cc: core-libs-dev ; Baesken, Matthias

RE: [16] 8251017: java/io/File/GetXSpace.java fails on UNIX

Hi Brian, just a question: I only see a fix for the AIX issue in your change. As far as I understand Matthias the main issue in https://bugs.openjdk.java.net/browse/JDK-8251017 is that NFS mounts (that often change the usable size during the test run) are not excluded. We see this kind of fail

Re: Possible subtle memory model error in ClassValue

Catching up... As implied in other posts, the minimal fix is to add a trailing release fence (using Unsafe?) to the constructor. Or less delicately, to access only using acquire/release (which will cost a bit on ARM/Power, but probably not noticeable on x86), or most simply (but expensively) t