Re: RFR: JDK-8250611: Cannot display splash screen on Windows

Only back to 11 and client support ended before that. -Phil. > On Aug 13, 2020, at 7:58 PM, Alexey Semenyuk > wrote: > > Phil, > > jpackage can be used to bundle apps with older JREs. Do you think it doesn't > make sense for this check given this? > > - Alexey > >> On 8/13/2020 6:03 PM, P

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

Phil, jpackage can be used to bundle apps with older JREs. Do you think it doesn't make sense for this check given this? - Alexey On 8/13/2020 6:03 PM, Philip Race wrote: Do I understand correctly that you are checking if the client VM is being specified ? I didn't think we had client VMs a

Re: RFR: 8250803: pkgbuild failed with exit code 134

Hi Joe, None. Most time is spend when pkgbuild is executed which is external tool. Based on log our code does not consume a lot of time during execution. Based on one of the runs total time was 11 min: 1 min for jlink, 4 min for hdutil create and 4 min for pkgbuild, so test itself took 2 min.

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

Hi Andy, Looks good. Thanks, Alexander On 8/13/20 12:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll).

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

Do I understand correctly that you are checking if the client VM is being specified ? I didn't think we had client VMs any more .. -phil. On 8/13/20, 12:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked appla

Re: RFR: 8250803: pkgbuild failed with exit code 134

Looks good. - Alexey On 8/13/2020 4:13 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without

Re: RFR: JDK-8250611: Cannot display splash screen on Windows

Looks good. - Alexey On 8/13/2020 3:35 PM, Andy Herrick wrote: Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll). /Andy [1] - htt

Re: RFR: 8250803: pkgbuild failed with exit code 134

What steps were taken to make the test run faster instead of increasing the time out? cheers, -Joe On 8/13/2020 1:13 PM, alexander.matv...@oracle.com wrote: Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing time

RFR: 8250803: pkgbuild failed with exit code 134

Please review the jpackage fix for bug [1] at [2]. - Looks like issue was just in not enough time for test to execute. Increasing timeout by 1 min fixed issues. In fix it is increased by 50% just in case. Without timeout increase it was reproducible 100% on one of test machine. With increased

Re: 8251160: Fix "no comment" warnings in java.logging

On 8/13/20 5:00 AM, Daniel Fuchs wrote: Hi, Please find below a doc-only fix for: 8251160: Fix "no comment" warnings in java.logging https://bugs.openjdk.java.net/browse/JDK-8251160 CSR: https://bugs.openjdk.java.net/browse/JDK-8251534 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8251

RFR: JDK-8250611: Cannot display splash screen on Windows

Please review this jpackage fix for issue [1] at [2]. In order to show splash screen from statically linked applauncher, we need to load the dependent libraries of splashscreen.dll first (java.dll and jvm.dll). /Andy [1] - https://bugs.openjdk.java.net/browse/JDK-8250611 [2] - http://cr.ope

Re: [Ping] Re: 8181919: Refactor test/java/io/File/GetXSpace.sh to java test

Thanks, Naoto, will do. I am always unclear as to whether to add a bug id to a test when the issue is labelled “noreg-self.” Brian > On Aug 13, 2020, at 10:52 AM, naoto.s...@oracle.com wrote: > > Looks good, Brian. I'd add the bug id in GetXSpace.java's @bug tag. > > Naoto > > On 8/13/20 8:40

Optimize sun.invoke.util.BytecodeDescriptor.unparse

Hi, I just stumbled upon sun.invoke.util.BytecodeDescriptor.unparse that seems to unnecessarily create a StringBuilder and checks for the given type to be of Object.class twice in certain scenarios. When I apply the attached patch below with the following isolated benchmark: @BenchmarkMode(Mod

Re: [Ping] Re: 8181919: Refactor test/java/io/File/GetXSpace.sh to java test

Looks good, Brian. I'd add the bug id in GetXSpace.java's @bug tag. Naoto On 8/13/20 8:40 AM, Brian Burkhalter wrote: Thanks! On Aug 11, 2020, at 11:32 AM, Brian Burkhalter wrote: A revised version [A] is available pursuant to the changes made in the course of the review [B] of the fix fo

Re: Fix for Javadoc errors in java.base

On 8/13/20 1:21 PM, Jonathan Gibbons wrote: --- old/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:21.233726447 +0530 +++ new/src/java.base/share/classes/com/sun/crypto/provider/DHPrivateKey.java 2020-07-25 23:46:20.721720857 +0530 @@ -96,8 +96,6 @@

Re: Fix for Javadoc errors in java.base

On 8/13/20 10:13 AM, Sean Mullan wrote: On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to hav

Re: Fix for Javadoc errors in java.base

On 8/13/20 11:05 AM, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Bug: https://bugs.openjdk.java.n

Re: Fix for Javadoc errors in java.base

Hi Vipin, Julia, On 13/08/2020 16:05, Julia Boes wrote: Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Changes to Soc

Re: [aarch64-port-dev ] [16] RFR[S]: 8251216: Implement MD5 intrinsics on AArch64

On 13/08/2020 11:00, Andrew Haley wrote: On 12/08/2020 12:38, Stuart Monteith wrote: > The method "testDigest" generates an byte array of a given size, > with each element filled with it's own index & 0xff. > > The test is then run once, assumed uncompiled, it is then "warmed > up" and the

[Ping] Re: 8181919: Refactor test/java/io/File/GetXSpace.sh to java test

Thanks! > On Aug 11, 2020, at 11:32 AM, Brian Burkhalter > wrote: > > A revised version [A] is available pursuant to the changes made in the course > of the review [B] of the fix for [C]. > > Thanks, > > Brian > > [A] http://cr.openjdk.java.net/~bpb/8181919/webrev.01/ >

Re: 8251160: Fix "no comment" warnings in java.logging

Hi Daniel, The changes look good. I added myself as a reviewer to the CSR Best Lance > On Aug 13, 2020, at 8:00 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a doc-only fix for: > > 8251160: Fix "no comment" warnings in java.logging > https://bugs.openjdk.java.net/browse/JDK-8251160

Re: Fix for Javadoc errors in java.base

Hi Vipin, Thanks for providing this fix, I'm happy to sponsor your change. To complete the review, we still need someone to green light the remaining changes below. I'm looping in net-dev and security-dev to have a look. Bug: https://bugs.openjdk.java.net/browse/JDK-8251542 Webrev: http://cr

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

- Mail original - > De: "Florian Weimer" > À: "Remi Forax" > Cc: "Patrick Concannon" , "Julia Boes" > , "Anthony Vanelverdinghe" > , "core-libs-dev" > Envoyé: Jeudi 13 Août 2020 11:58:38 > Objet: Re: RFR[8238286]: 'Add new flatMap stream operation that is more > amenable to pushing’

8251160: Fix "no comment" warnings in java.logging

Hi, Please find below a doc-only fix for: 8251160: Fix "no comment" warnings in java.logging https://bugs.openjdk.java.net/browse/JDK-8251160 CSR: https://bugs.openjdk.java.net/browse/JDK-8251534 webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8251160/webrev.00/ The documentation of the ser

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

* Remi Forax: > I still don't like the fact that IntMapMultiConsumer, > DoubleMapMultiConsumer and LongMapMultiConsumer are not in > java.util.function unlike all other functional interfaces used by > the Stream API. They seem rather too specific for java.util.function to me. Maybe we should add

Re: RFR[8238286]: 'Add new flatMap stream operation that is more amenable to pushing’

* Patrick Concannon: > webrev: http://cr.openjdk.java.net/~pconcannon/8238286/webrevs/webrev.05/ + * The results of this method are undefined if the second {@link IntConsumer} + * argument is operated on outside the scope of the mapper function. Should this say “after the mapper functio