HI, Sundar, David
Thanks.
I have update the webrev at the same link:
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/ according Sundar's
suggestion.
Thanks.
Yumin
On 8/17/20 7:39 PM, sundararajan.athijegannat...@oracle.com wrote:
Hi David.
Thanks.
-Sundar
On 18/08/20
Hi, Calvin
I have updated the webrev at
http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-02/
On 8/12/20 11:54 AM, calvin.che...@oracle.com wrote:
Hi Yumin,
I reviewed mostly the native code. Below are my comments:
1) classListParser.hpp
71 bool _lambda_format;
No
Hi Naoto,
That's nice! The change looks good to me.
Regards,
Joe
On 8/18/20 11:37 AM, naoto.s...@oracle.com wrote:
Hi Joe,
Thank you for your comment. I consolidated those duplicated pieces
into one piece. Did not make it a private method, though, as it would
need to return two results
Hi Joe,
Thank you for your comment. I consolidated those duplicated pieces into
one piece. Did not make it a private method, though, as it would need to
return two results from the method (cnfMultiplier and whether to return
immediately for no-placeholder cases).
Hi Roger,
Thank you for your comment. I added a brief comment in the issue on how
the implementation behaves in the problem case.
Naoto
On 8/18/20 8:19 AM, Roger Riggs wrote:
Hi Naoto,
I think the issue would benefit from a comment describing the solution.
Its not clear how the code
Looks fine.
Thanks
Mandy
On 8/18/20 10:02 AM, Julia Boes wrote:
Hi,
The two changes below still need to be reviewed. Any takers?
Cheers,
Julia
---
old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14
23:55:41.953638446 +0530
+++
Hi,
The two changes below still need to be reviewed. Any takers?
Cheers,
Julia
---
old/src/java.base/share/classes/java/lang/invoke/AbstractValidatingLambdaMetafactory.java2020-08-14
23:55:41.953638446 +0530
+++
Hi Patrick,
This looks good. To resolve the ambiguity of when results are undefined I
suggest we tweak the docs at the various locations, see below. No need for
another round of review.
I can understand the desire to place the primitive functional interfaces in
j.u.functions, but for reasons
Hi Naoto,
I think the issue would benefit from a comment describing the solution.
Its not clear how the code addresses the issue.
Thanks, Roger
On 8/17/20 7:42 PM, naoto.s...@oracle.com wrote:
Hi Joe,
It turned out that the previous fix did not address plural format
cases. That means that
On 17/08/2020 15:24, Peter Levart wrote:
>
> On 8/16/20 7:35 PM, Andrew Haley wrote:
>> On 15/08/2020 10:13, Peter Levart wrote:
>>> https://github.com/openjdk/jdk/pull/9
>>>
>>>
>>> Sorry for abusing GitHub pull request mechanism but I don't have
>>> bandwidth currently to clone the mercurial
Looks fine to me Evan.
regards,
Sean.
On 17/08/2020 16:25, Evan Whelan wrote:
Hi all,
This is a small fix that helps with some test cleanup. One redundant test file
has been removed.
Webrev found at: http://cr.openjdk.java.net/~kravikumar/8249691/webrev/
Link to JBS issue:
Hi Naoto,
Looks good overall. One nit, blocks 1633-1639 and 1642-1649 may share a
common private method with a parameter that takes either matchedPosIndex
or matchedNegIndex, if you want.
Best,
Joe
On 8/17/20 4:42 PM, naoto.s...@oracle.com wrote:
Hi Joe,
It turned out that the previous
12 matches
Mail list logo
