Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

2020-08-23 Thread Yumin Qi
Hi, Mandy, Ioi and Calvin   I have updated the new changed at: http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-03/   In this version:     1) Added a new API to check if flag DumpLoadedClassList set and the file is open. If true, call into vm to print out the trace line to the log file.

RFR 8251989: Hex encoder and decoder utility

2020-08-23 Thread Raffaello Giulietti
In the meantime I'll nevertheless take a look at the current implementation of the Decoder. Greetings Raffaello Hi Roger, here are my notes about the Decoder. (1) The only serious issue I could find is on L.548. It should read L.548 CharBuffer cb = CharBuffer.wrap(chars, index, index +

Re: Review request for JDK-8252124: Restore Dynalink tests

2020-08-23 Thread Attila Szegedi
Im happy to update the copyright years before merging my changes. I’ll not put up a separate webrev for that though, if that’s okay. Attila. > On 2020. Aug 21., at 07:32, Sundararajan Athijegannathan > wrote: > > Looks good. > > Minor comment: not sure if you need to update copyright year on

Re: Review request for JDK-8251538: Modernize and lint Dynalink code

2020-08-23 Thread Attila Szegedi
On 2020. Aug 20., at 23:43, Remi Forax wrote: > > - Mail original - >> De: "Attila Szegedi" >> À: "core-libs-dev" >> Envoyé: Jeudi 20 Août 2020 22:40:53 >> Objet: Review request for JDK-8251538: Modernize and lint Dynalink code > >> ... >> Oh, BTW, I really got an inspiration for addin