Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall wrote: > Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since` from

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

Hi Philippe, On 8/09/2020 3:08 am, Philippe Marschall wrote: Hello, newbie here Welcome aboard! I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do. - I tried to update the copyright year to 2020 in every file. - I decided to change `@sinc

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files [v2]

On Mon, 7 Sep 2020 18:57:11 GMT, Sean Coffey wrote: >> Continuation of RFR thread from >> http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html >> >> CSR has been approved. > > Sean Coffey has updated the pull request incrementally with one additional > commit since the l

Integrated: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote: > Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. This pull request has now been integrated. Changeset: 7686e871 Author:Sean Coffey URL: http

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files [v2]

> Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. Sean Coffey has updated the pull request incrementally with one additional commit since the last revision: Copyright and test clean up - Ch

Re: JDK 15 hidden classes & stack trace visibility

Thanks Mandy. In my opinion for the hidden classes an additional enum constant in ClassOption would be fine: ClassOption.SHOW_IN_STACKTRACE (or similar). That would be simplest to implement and allows also for the caller to enable it like strong references or nestmate features. So it's consiste

Re: RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall wrote: > Hello, newbie here > > I picked JDK-8138732 to work on because it has a "starter" label and I > believe I understand what to do. > > - I tried to update the copyright year to 2020 in every file. > - I decided to change `@since` from

RFR: 8238669: Long.divideUnsigned is extremely slow for certain values (Needs to be Intrinsic)

This is a follow-up of the Mercurial-based workflow initiated on the core-lib-devs mailing list [0]. Not sure if this one is strictly necessary or if the patches sent on the list are sufficient. Anyway, I exploit this PR as a test ;-) [0] https://mail.openjdk.java.net/pipermail/core-libs-dev/20

RFR: 8138732: Rename @HotSpotIntrinsicCandidate to @IntrinsicCandidate and move it to the jdk.internal.vm.annotation package

Hello, newbie here I picked JDK-8138732 to work on because it has a "starter" label and I believe I understand what to do. - I tried to update the copyright year to 2020 in every file. - I decided to change `@since` from 9 to 16 since it is a new annotation name in a new package. - I tried to k

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote: > Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. Marked as reviewed by weijun (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/56

Re: RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

On Mon, 7 Sep 2020 13:48:57 GMT, Sean Coffey wrote: > Continuation of RFR thread from > http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html > > CSR has been approved. I think this looks good over all Sean. In your SymLinkTest, I probably would have the test delete th

Re: JDK 15 hidden classes & stack trace visibility

Hi Uwe, It's a future enhancement to allow a class/method to request filtering from stack trace:     https://bugs.openjdk.java.net/browse/JDK-8212620 This RFE should also take hidden classes into account. Mandy On 9/5/20 4:55 AM, Uwe Schindler wrote: Hi, I am doing a mockup for dynamically

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

Hi Kim: Thanks for the discussion, this makes more sense to me now. > Kim Barrett on 06 September 2020 19:35 wrote: > > Can you be (very) specific about this.  Do all of these changes cause gcc10 > to warn?  Or > do only some of them.  If only some, specifically which ones? I have a > conjec

RFR: 8250968: Symlinks attributes not preserved when using jarsigner on zip files

Continuation of RFR thread from http://mail.openjdk.java.net/pipermail/security-dev/2020-August/022373.html CSR has been approved. - Commit messages: - JDK-8250968 Changes: https://git.openjdk.java.net/jdk/pull/56/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=56&ran

RFR: 8245194: Unix domain socket channel implementation

Continuing this review as a PR on github with the comments below incorporated. I expect there will be a few more iterations before integrating. On 06/09/2020 19:47, Alan Bateman wrote: > On 26/08/2020 15:24, Michael McMahon wrote: >> >> As I mentioned the other day, I wasn't able to use the sugge

RE: RFR(M): 8248188: [PATCH] Add HotSpotIntrinsicCandidate and API for Base64 decoding

Hi Corey, thanks for investigating. Note that we use xlclang++ on AIX. It may possibly understand the directives as gcc on linux. Gcc 7.3.1 is the minimum for BE linux. But if you protect your code by #ifdef VM_LITTLE_ENDIAN no compiler except gcc >= 7.4.0 should ever look at it. Best regards,

Re: RFR(S): 8252407: Build failure with gcc-8+ and asan

* Kim Barrett: > And strlen is not even necessarily the best solution, as it likely > introduces an additional otherwise unnecessary string traversal. For > example, getFlags could be changed to reject an overly long ifname, > without using strlen, thusly: > > strncpy(if2.ifr_name, ifname, siz