Re: RFR: JDK-8230652: Improve verbose output

2020-09-20 Thread Alexander Zuev
On Sat, 12 Sep 2020 18:30:08 GMT, Andy Herrick wrote: > JDK-8230652 > Extracting the commands displayed by verbose output (including commands > called thru ToolProvider) , to contain the the > command, it's output, and it's return value on separate lines and formatted > in a way that they can b

Re: Request for review of JDK-8251548

2020-09-20 Thread David Holmes
On 18/09/2020 5:15 pm, Сергей Цыпанов wrote: Hi, Did you not follow these instructions to get your github account connected to your OCA record: Those are for "OpenJDK Author, Committer or Reviewer", but I'm only a contributor, i.e. I cannot file an issue or commit directly. My previous contr

RE: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic

2020-09-20 Thread Yangfei (Felix)
Hi, > -Original Message- > From: hotspot-dev [mailto:hotspot-dev-r...@openjdk.java.net] On Behalf > Of Andrew Haley > Sent: Friday, September 18, 2020 9:48 PM > To: Fei Yang ; hotspot-...@openjdk.java.net; > security-...@openjdk.java.net > Subject: Re: RFR: 8252204: AArch64: Implement SHA3

Jpackage file assocations OS X

2020-09-20 Thread Michael Hall
Are there any examples or further information on how the file association property file should work? It is not entirely clear to me from the command help.

Re: RFR: 8252537: Updated @exception with @throws [v3]

2020-09-20 Thread Serguei Spitsyn
On Sat, 19 Sep 2020 20:24:14 GMT, Vipin Sharma wrote: >> Updated @exception with @throws for core-libs, it fixes all open sub-tasks >> of JDK-8252536. >> >> Open Subtasks part of this fix are: >> 1. JDK-8252537 >> 2. JDK-8252539 >> 3. JDK-8252540 >> 4. JDK-8252541 >> >> Previous conversation o

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v3]

2020-09-20 Thread Uwe Schindler
On Sun, 20 Sep 2020 22:22:47 GMT, Lance Andersen wrote: >> Hi all, >> >> Please review the fix for JDK-8252739 which addresses an issue introduced by >> https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored >> the offset specified by >> Deflater.setDictionary. Mach5 jdk-t

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v3]

2020-09-20 Thread Lance Andersen
On Sun, 20 Sep 2020 20:42:30 GMT, Uwe Schindler wrote: >> Minor updates have been made to the tests > > Ok much better for the heap buffers. Many thanks. > > The direct buffers have now contents, but I think it should copy the whole > heap array into the byte buffer. After that > set position

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v3]

2020-09-20 Thread Uwe Schindler
On Sun, 20 Sep 2020 20:38:59 GMT, Lance Andersen wrote: >> The tests with byte buffers (direct and heap) are not using offsets >> (arrayOffset=0). The direct buffer test uses just a >> series of 0-bytes, so incorrect offsets won't change result. There should be >> real data copied into the dire

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v3]

2020-09-20 Thread Lance Andersen
> Hi all, > > Please review the fix for JDK-8252739 which addresses an issue introduced by > https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored > the offset specified by > Deflater.setDictionary. Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly > as well as the java/u

RFR: 8253149: Building an installer from invalid app image fails on Window…

2020-09-20 Thread Andy Herrick
8253149: Building an installer from invalid app image fails on Windows and Linux When jpackage builds a package from an app-image that was not generated by jpackage, the tool should give user a warning message, and then complete the package anyway. - Commit messages: - 8253149: Buil

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v2]

2020-09-20 Thread Lance Andersen
On Sun, 20 Sep 2020 18:29:20 GMT, Uwe Schindler wrote: >> Lance Andersen has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Additional updates to DeflaterDictionaryTests.java > > The tests with byte buffers (direct and heap) are not using

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary [v2]

2020-09-20 Thread Lance Andersen
> Hi all, > > Please review the fix for JDK-8252739 which addresses an issue introduced by > https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored > the offset specified by > Deflater.setDictionary. Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly > as well as the java/u

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary

2020-09-20 Thread Uwe Schindler
Hi, I left some comments on the PR. The tests with ByteBuffers are not testing the bug correctly. Uwe Am September 20, 2020 6:14:59 PM UTC schrieb Lance Andersen : >Hi all, > >Please review the fix for JDK-8252739 which addresses an issue >introduced by >https://bugs.openjdk.java.net/browse/J

Re: RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary

2020-09-20 Thread Uwe Schindler
On Sun, 20 Sep 2020 18:03:02 GMT, Lance Andersen wrote: > Hi all, > > Please review the fix for JDK-8252739 which addresses an issue introduced by > https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored > the offset specified by > Deflater.setDictionary. Mach5 jdk-tier1,

RFR: 8252739: Deflater.setDictionary(byte[], int off, int len) ignores the starting offset for the dictionary

2020-09-20 Thread Lance Andersen
Hi all, Please review the fix for JDK-8252739 which addresses an issue introduced by https://bugs.openjdk.java.net/browse/JDK-8225189, where Deflater.c ignored the offset specified by Deflater.setDictionary. Mach5 jdk-tier1, jdk-tier2, jdk-tier3 runs cleanly as well as the java/util/zip and ja

Re: RFR: 8252523: Add ASN1 Formatter to work with HexPrinter [v2]

2020-09-20 Thread Roger Riggs
> # JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter > > Debugging functions that utilize ASN.1, DER, and BER encoded streams is > difficult without test utilities to show the contents. > The ASN.1 formatter reads a stream and produces annotated output of the > tags, values, a

RFR: 8252523: Add ASN1 Formatter to work with HexPrinter

2020-09-20 Thread Roger Riggs
# JDK-8252523: Add ASN.1 Formatter to work with test utility HexPrinter Debugging functions that utilize ASN.1, DER, and BER encoded streams is difficult without test utilities to show the contents. The ASN.1 formatter reads a stream and produces annotated output of the tags, values, and structure

Re: RFR: 8252204: AArch64: Implement SHA3 accelerator/intrinsic [v4]

2020-09-20 Thread Fei Yang
> Contributed-by: ard.biesheu...@linaro.org, dong...@huawei.com > > This added an intrinsic for SHA3 using aarch64 v8.2 SHA3 Crypto Extensions. > Reference implementation for core SHA-3 transform using ARMv8.2 Crypto > Extensions: > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git