On Wed, 21 Oct 2020 20:39:18 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes to the subject issue. The fix replaces the
> obsolete/incorrect English language/region/script display names in the COMPAT
> root locale bundle. The data are derived from CLDR's English names.
This pull
On Thu, 22 Oct 2020 23:20:08 GMT, Naoto Sato wrote:
> Hi Joe,
>
> > Do we need a test similar to ISO3166 where display names of Locale.ROOT and
> > Locale.US are compared? I see LocaleEnhanceTest.java has references to
> > Locale.ROOT and a few selected names were updated. But we don't seem
On Wed, 21 Oct 2020 23:38:23 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the changes to the subject issue. The fix replaces the
>> obsolete/incorrect English language/region/script display names in the
>> COMPAT root locale bundle. The data are derived from CLDR's English names.
>
>
On Thu, 22 Oct 2020 22:29:16 GMT, Joe Wang wrote:
>> Marked as reviewed by bchristi (Reviewer).
>
> Hi Naoto,
>
> Do we need a test similar to ISO3166 where display names of Locale.ROOT and
> Locale.US are compared? I see LocaleEnhanceTest.java has references to
> Locale.ROOT and a few
On Thu, 22 Oct 2020 21:40:59 GMT, Brent Christian wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Put a newline at the end.
>
> Marked as reviewed by bchristi (Reviewer).
Hi Naoto,
Do we need a test similar to
On Thu, 22 Oct 2020 14:24:34 GMT, Paul Murphy
wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TestBase64.java: remove jdk.test.lib.Utils from @build which was causing
>> Tier3 failures.
>
>
On Thu, 22 Oct 2020 14:32:40 GMT, Paul Murphy
wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TestBase64.java: remove jdk.test.lib.Utils from @build which was causing
>> Tier3 failures.
>
>
On Tue, 20 Oct 2020 21:49:37 GMT, Brent Christian wrote:
> Hi,
>
> The java/util/prefs/AddNodeChangeListener.java test fails once in a while in
> the automated test system. Previous failures were traced to machine
> configuration errors, but that does not appear to be the case this time.
>
On Wed, 21 Oct 2020 23:16:15 GMT, Naoto Sato wrote:
>> Hi, Naoto
>>
>> What is the source for the updated values in LocaleNames.properties?
>>
>> Also, could the bug synopsis be updated to be more descriptive?
>>
>> Thanks,
>> -Brent
>
> Hi Brent,
>
>> What is the source for the updated
On Wed, 21 Oct 2020 23:38:23 GMT, Naoto Sato wrote:
>> Hi,
>>
>> Please review the changes to the subject issue. The fix replaces the
>> obsolete/incorrect English language/region/script display names in the
>> COMPAT root locale bundle. The data are derived from CLDR's English names.
>
>
Please review this proposed fix. The review was initially in this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/061914.html
under the old Hg SCM. The changes proposed here are derived from the final
(.05) patch in the previous review which was posted in
On Thu, 22 Oct 2020 20:00:12 GMT, Claes Redestad wrote:
>> @cl4es could I ask one more question? Would it be helpful to create a
>> separate PR about removal of explicit zeroing of Atomic* classes (excluding
>> AtomicBoolean), e.g. somethin like this
>>
On Thu, 22 Oct 2020 19:48:19 GMT, Сергей Цыпанов
wrote:
>>> On 15/10/2020 11:41, Claes Redestad wrote:
>>>
>>> > In the short term we could consider a point fix to replace existing
>>> > use of `new AtomicInteger/-Long(0)` with `new
>>> > AtomicInteger/-Long()`, but in the long term we should
On Thu, 22 Oct 2020 18:10:02 GMT, Martin Doerr wrote:
>> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 3820:
>>
>>> 3818: __ vcmpequb_(eq_special_case_char, input,
>>> vec_special_case_char);
>>> 3819: //
>>> 3820: // There's a (63/64)^16 = 77.7% chance that there are
On Thu, 22 Oct 2020 14:00:49 GMT, Paul Murphy
wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TestBase64.java: remove jdk.test.lib.Utils from @build which was causing
>> Tier3 failures.
>
>
On Thu, 15 Oct 2020 19:05:54 GMT, Claes Redestad wrote:
>> @cl4es , @dreis2211 thanks for explanation!
>
>> On 15/10/2020 11:41, Claes Redestad wrote:
>>
>> > In the short term we could consider a point fix to replace existing
>> > use of `new AtomicInteger/-Long(0)` with `new
>> >
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
This pull request has now been integrated.
Changeset: 0aa3c925
Author:Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/0aa3c925
Stats:
On Thu, 22 Oct 2020 14:01:05 GMT, Paul Murphy
wrote:
>> CoreyAshford has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> TestBase64.java: remove jdk.test.lib.Utils from @build which was causing
>> Tier3 failures.
>
>
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by mchung (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
As the creator of these tags many moons ago, I approve this change.
-
Marked as reviewed by mr (Lead).
PR:
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by alanb (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/814
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
looks fine
-
Marked as reviewed by lancea (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
The change is (just) to remove legacy usages of a JDK-private custom tag.
-
Commit messages:
- JDK-8255262: Remove use of legacy custom @spec tag
Changes: https://git.openjdk.java.net/jdk/pull/814/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=814=00
Issue:
On Thu, 22 Oct 2020 14:23:13 GMT, Alan Bateman wrote:
> NewInvocationHandler/DefaultMethodInvoker feels a bit awkward. If I have it
> right, to use it as a lambda expression to Proxy.newProxyInterface would
> require casting to NewInvocationHandler. I also need to be careful when using
> the
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Thu, 22 Oct 2020 16:31:00 GMT, Maurizio Cimadamore
wrote:
>> Some of this is familiar to me from reviews in the `panama-foreign`
>> repository, but less so than the memory API. I focused on the Java code, and
>> ignored changes that are common with the memory API PR.
>>
>> If it helps in
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Thu, 22 Oct 2020 14:17:56 GMT, Severin Gehwolf wrote:
> Originally only join controllers of form `cpu,cpuacct` would have been
> recognized.
> However, this fails if more controllers are joined at a certain path.
>
> The proposed fix is to be sure to split join controllers on `,` and set
On Wed, 21 Oct 2020 17:42:53 GMT, Paul Sandoz wrote:
> Some design considerations, to consider later maybe.
>
> The IR representation could be simplified to use record classes (which should
> be exiting preview in 16), implementing a Binding interface. The interpreter
> and specializer
> This patch contains the changes associated with the first incubation round of
> the foreign linker access API incubation
> (see JEP 389 [1]). This work is meant to sit on top of the foreign memory
> access support (see JEP 393 [2] and associated pull request [3]).
>
> The main goal of this
On Thu, 22 Oct 2020 15:46:33 GMT, Paul Sandoz wrote:
>> IIRC this was added to silence a javac linter warning. Something should be
>> added here. There is/was no plan to make this class public though.
>
> It's odd the lint warning is triggering on a package private class and
> private methods.
On Wed, 21 Oct 2020 19:05:42 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one
On Thu, 22 Oct 2020 15:45:56 GMT, Bob Vandette wrote:
>> Isn't this what line 164 does?
>
> Sorry, I missed the fact that line 164 was being retained. I just saw a lot
> of line removal. Looks good.
No worries. Thank you for the review!
-
PR:
On Thu, 22 Oct 2020 14:26:37 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractNativeScope.java
>> line 120:
>>
>>> 118: }
>>> 119: }
>>> 120: throw new AssertionError("Cannot get here!");
>>
>>
On Thu, 22 Oct 2020 14:31:12 GMT, Jorn Vernee wrote:
>> src/java.base/share/classes/java/lang/invoke/NativeMethodHandle.java line 36:
>>
>>> 34: import static java.lang.invoke.MethodHandleStatics.newInternalError;
>>> 35:
>>> 36: /** TODO */
>>
>> Is the TODO to make this class public later
On Thu, 22 Oct 2020 13:30:13 GMT, Maurizio Cimadamore
wrote:
>> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java
>> line 126:
>>
>>> 124: *
>>> 125: * @param symbol downcall symbol.
>>> 126: * @param type the method type.
>>
>> s/method
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of
On Thu, 22 Oct 2020 14:17:56 GMT, Severin Gehwolf wrote:
> Originally only join controllers of form `cpu,cpuacct` would have been
> recognized.
> However, this fails if more controllers are joined at a certain path.
>
> The proposed fix is to be sure to split join controllers on `,` and set
On Thu, 22 Oct 2020 15:42:34 GMT, Severin Gehwolf wrote:
>> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/CgroupV1Subsystem.java
>> line 165:
>>
>>> 163:
>>> 164: if (controllerName != null && base != null) {
>>> 165: for (String cName:
On Thu, 22 Oct 2020 15:00:55 GMT, Bob Vandette wrote:
>> Originally only join controllers of form `cpu,cpuacct` would have been
>> recognized.
>> However, this fails if more controllers are joined at a certain path.
>>
>> The proposed fix is to be sure to split join controllers on `,` and set
On Thu, 22 Oct 2020 14:17:56 GMT, Severin Gehwolf wrote:
> Originally only join controllers of form `cpu,cpuacct` would have been
> recognized.
> However, this fails if more controllers are joined at a certain path.
>
> The proposed fix is to be sure to split join controllers on `,` and set
On Wed, 21 Oct 2020 20:43:30 GMT, CoreyAshford
wrote:
>> This patch set encompasses the following commits:
>>
>> - Adds a new HotSpot intrinsic candidate to the java.lang.Base64 class -
>> decodeBlock(), and provides a flexible API for the intrinsic. The API is
>> similar to the existing
On Thu, 22 Oct 2020 14:25:28 GMT, Severin Gehwolf wrote:
>> Originally only join controllers of form `cpu,cpuacct` would have been
>> recognized.
>> However, this fails if more controllers are joined at a certain path.
>>
>> The proposed fix is to be sure to split join controllers on `,` and
On Tue, 20 Oct 2020 21:53:55 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one
On Tue, 20 Oct 2020 21:08:26 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one
On Wed, 21 Oct 2020 16:23:16 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 27 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Don't use JNI when generating native
On Thu, 22 Oct 2020 14:17:56 GMT, Severin Gehwolf wrote:
> Originally only join controllers of form `cpu,cpuacct` would have been
> recognized.
> However, this fails if more controllers are joined at a certain path.
>
> The proposed fix is to be sure to split join controllers on `,` and set
On Thu, 22 Oct 2020 00:24:59 GMT, Mandy Chung wrote:
>> Hi Peter, thanks for coming with these alternatives. The need for new
>> `InvocationHandler2` and `InvocationHandler2.SuperInvoker` APIs and the
>> complexity of `plevart:proxy-default-method-alt-api2` look unpleasing in
>> order to
Originally only join controllers of form `cpu,cpuacct` would have been
recognized.
However, this fails if more controllers are joined at a certain path.
The proposed fix is to be sure to split join controllers on `,` and set the path
accordingly. Otherwise, the Metrics system might be
On Thu, 22 Oct 2020 09:08:31 GMT, Andrew Haley wrote:
>> DataOutputStream is very slow post-disabling of Biased Locking. This
>> was discovered when benchmarking a transaction library, which showed
>> significant performance loss when moving to JDK 15. WIth some small
>> changes to
On Tue, 20 Oct 2020 21:31:17 GMT, Paul Sandoz wrote:
>> Maurizio Cimadamore has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge branch 'master' into 8254231_linker
>> - Fix incorrect capitalization in one
Hello,
while working with java.net.URL I've found unused package-private method
URL.set(String protocol, String host, int port, String file, String ref) which
can be safely removed. Testing: both tier1 and tier2 are ok.
Could someone crate an issue for tracking of this simple change?
Here's
> This is the current proposed patch for the upcoming JEP 394, for pattern
> matching for instanceof.
>
> A summary of changes:
> -making the feature permanent (non-preview)
> -making the binding variables non-final (as per current specification
> proposal)
> -producing a compile-time error for
On Wed, 21 Oct 2020 03:13:34 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits
On Thu, 22 Oct 2020 09:08:31 GMT, Andrew Haley wrote:
>> DataOutputStream is very slow post-disabling of Biased Locking. This
>> was discovered when benchmarking a transaction library, which showed
>> significant performance loss when moving to JDK 15. WIth some small
>> changes to
On Wed, 21 Oct 2020 03:12:08 GMT, Vicente Romero wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 15 additional
>> commits
> DataOutputStream is very slow post-disabling of Biased Locking. This
> was discovered when benchmarking a transaction library, which showed
> significant performance loss when moving to JDK 15. WIth some small
> changes to DataOutputStream we can get the performance back. There's a
> JMH
59 matches
Mail list logo
