Re: RFR: 8253459: Formatter treats index, width and precision > Integer.MAX_VALUE incorrectly [v5]

2020-10-24 Thread Marcono1234
On Thu, 15 Oct 2020 19:20:28 GMT, Ian Graves wrote: >> The `java.util.Formatter` format specifies support for field widths, >> argument indexes, or precision lengths of a field that relate to the >> variadic arguments supplied to the formatter. These numbers are specified by >> integers,

Re: RFR: 8255299: Drop explicit zeroing at instantiation of Atomic* objects

2020-10-24 Thread Phil Race
On Thu, 22 Oct 2020 20:46:15 GMT, Сергей Цыпанов wrote: > As discussed in https://github.com/openjdk/jdk/pull/510 there is never a > reason to explicitly instantiate any instance of `Atomic*` class with its > default value, i.e. `new AtomicInteger(0)` could be replaced with `new >

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-24 Thread Peter Levart
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote: >> I just want to note that if you have a `Reference ref` at hand, >> you can not just do: >> Referemce r = (Reference) ref; >> ...since those generic types are not related. You have to do something like: >> >>

RFR: 8202471: Make type annotations on owner type parameters available

2020-10-24 Thread Rafael Winterhalter
A method's or constructor's owner type might carry annotations on its potential type parameters but is never represented as parameterized type what makes these parameters inaccessible at runtime, despite the presence of parameter type annotations. - Commit messages: - 8202471: A

Re: RFR: 8248188: Add IntrinsicCandidate and API for Base64 decoding [v8]

2020-10-24 Thread CoreyAshford
On Thu, 22 Oct 2020 20:40:00 GMT, CoreyAshford wrote: >> Thanks for this question. I also stumbled over it when reviewing. I guess a >> branch which gets mispredicted in ~22% of the cases leads to a big >> performance loss. (In addition, the branch target is not aligned.) > > Yes, it assumes

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-24 Thread Kim Barrett
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote: >> I just want to note that if you have a `Reference ref` at hand, >> you can not just do: >> Referemce r = (Reference) ref; >> ...since those generic types are not related. You have to do something like: >> >>

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v4]

2020-10-24 Thread Jorn Vernee
> Hi, > > This patch adds an asExact() combinator to VarHandle, that will return a new > VarHandle that performs exact type checks, similar to > MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, > which can lead to performance degradation. > > This is implemented