Re: RFR: 8255671: Bidi.reorderVisually has misleading exception messages

2020-10-30 Thread Joe Wang
On Fri, 30 Oct 2020 22:23:30 GMT, Naoto Sato wrote: > Hi, > > Please review this simple message fix that follows JDK-8255242. > > Naoto Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/973

Re: RFR: 8254354: Add a withInvokeExactBehavior() VarHandle combinator [v11]

2020-10-30 Thread Paul Sandoz
On Fri, 30 Oct 2020 16:17:06 GMT, Jorn Vernee wrote: >> Hi, >> >> This patch adds an asExact() combinator to VarHandle, that will return a new >> VarHandle that performs exact type checks, similar to >> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, >> which can

RFR: 8255671: Bidi.reorderVisually has misleading exception messages

2020-10-30 Thread Naoto Sato
Hi, Please review this simple message fix that follows JDK-8255242. Naoto - Commit messages: - 8255671: Bidi.reorderVisually has misleading exception messages Changes: https://git.openjdk.java.net/jdk/pull/973/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=973=00

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Alexander Matveev
On Fri, 30 Oct 2020 12:47:08 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8254920: Application launched with jpackage produced .exe crashes JVM Marked as reviewed by almatvee

Re: RFR: 8247781: Day periods support [v3]

2020-10-30 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: 8247781: Day periods support [v2]

2020-10-30 Thread Naoto Sato
On Fri, 30 Oct 2020 10:33:28 GMT, Stephen Colebourne wrote: >> Naoto Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed the following comments: >> - https://github.com/openjdk/jdk/pull/938#discussion_r515003422 >> -

Re: RFR: 8247781: Day periods support [v2]

2020-10-30 Thread Naoto Sato
> Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder > method. The motivation and its spec are in this CSR: >

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Alexey Semenyuk
On Fri, 30 Oct 2020 12:47:08 GMT, Andy Herrick wrote: >> JVM > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > > JDK-8254920: Application launched with jpackage produced .exe crashes JVM Marked as reviewed by asemenyuk

Integrated: 8214561: Use {@systemProperty} for definition of "java.util.prefs.PreferencesFactory" system property

2020-10-30 Thread Brent Christian
On Fri, 30 Oct 2020 19:47:14 GMT, Brent Christian wrote: > Using the {@systemProperty} tag for the "java.util.prefs.PreferencesFactory" > system property will allow it to be found in the main javadoc search index. > > The updated doc build looks good. This pull request has now been

Integrated: 8255690: in StringBuilder.subSequence

2020-10-30 Thread Brent Christian
On Fri, 30 Oct 2020 19:30:14 GMT, Brent Christian wrote: > There are a couple of stray ""'s in the StringBuilder.subSequence() > documentation, which should be removed. The updated doc build looks good. This pull request has now been integrated. Changeset: 98a69ede Author:Brent Christian

Re: RFR: 8255690: in StringBuilder.subSequence

2020-10-30 Thread Brent Christian
On Fri, 30 Oct 2020 19:38:45 GMT, Lance Andersen wrote: >> There are a couple of stray ""'s in the StringBuilder.subSequence() >> documentation, which should be removed. The updated doc build looks good. > > Looks fine Brent Thanks, Lance - PR:

Re: RFR: 8214561: Use {@systemProperty} for definition of "java.util.prefs.PreferencesFactory" system property

2020-10-30 Thread Lance Andersen
On Fri, 30 Oct 2020 19:47:14 GMT, Brent Christian wrote: > Using the {@systemProperty} tag for the "java.util.prefs.PreferencesFactory" > system property will allow it to be found in the main javadoc search index. > > The updated doc build looks good. Marked as reviewed by lancea (Reviewer).

RFR: 8214561: Use {@systemProperty} for definition of "java.util.prefs.PreferencesFactory" system property

2020-10-30 Thread Brent Christian
Using the {@systemProperty} tag for the "java.util.prefs.PreferencesFactory" system property will allow it to be found in the main javadoc search index. The updated doc build looks good. - Commit messages: - 8214561: Use {@systemProperty} for definition of

Re: RFR: 8255690: in StringBuilder.subSequence

2020-10-30 Thread Lance Andersen
On Fri, 30 Oct 2020 19:30:14 GMT, Brent Christian wrote: > There are a couple of stray ""'s in the StringBuilder.subSequence() > documentation, which should be removed. The updated doc build looks good. Looks fine Brent - Marked as reviewed by lancea (Reviewer). PR:

RFR: 8255690: in StringBuilder.subSequence

2020-10-30 Thread Brent Christian
There are a couple of stray ""'s in the StringBuilder.subSequence() documentation, which should be removed. The updated doc build looks good. - Commit messages: - remove nbsp from AbstractStringBuilder.subSequence() Changes: https://git.openjdk.java.net/jdk/pull/963/files

Withdrawn: 8255128: linux x86 build failure with libJNIPoint.c

2020-10-30 Thread Jorn Vernee
On Fri, 30 Oct 2020 12:47:59 GMT, Jorn Vernee wrote: > Guard libJNIPoint.c impl in `#ifdef _LP64` block > > This fixes a 32-bit build error This pull request has been closed without being integrated. - PR: https://git.openjdk.java.net/jdk/pull/956

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v11]

2020-10-30 Thread Jorn Vernee
> Hi, > > This patch adds an asExact() combinator to VarHandle, that will return a new > VarHandle that performs exact type checks, similar to > MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, > which can lead to performance degradation. > > This is implemented

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v10]

2020-10-30 Thread Jorn Vernee
> Hi, > > This patch adds an asExact() combinator to VarHandle, that will return a new > VarHandle that performs exact type checks, similar to > MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, > which can lead to performance degradation. > > This is implemented

Re: RFR: 8254354: Add an asExact() VarHandle combinator [v9]

2020-10-30 Thread Paul Sandoz
On Thu, 29 Oct 2020 18:14:05 GMT, Jorn Vernee wrote: >> Hi, >> >> This patch adds an asExact() combinator to VarHandle, that will return a new >> VarHandle that performs exact type checks, similar to >> MethodHandle::invokeExact, to help developers catch inexact VarHandle usage, >> which can

Re: RFR: 8255398: Add a dropReturn MethodHandle combinator [v3]

2020-10-30 Thread Jorn Vernee
On Tue, 27 Oct 2020 10:40:40 GMT, Jorn Vernee wrote: >>> …`dropReturn` seemed like a good choice since we already have >>> `dropArguments`. WRT changing to `MethodHandle::changeReturnType`... >> >> That's a very reasonable point. People might look for `dropRT` after they >> find `dropAs`.

RFR: 8255128: linux x86 build failure with libJNIPoint.c

2020-10-30 Thread Jorn Vernee
Guard libJNIPoint.c impl in `#ifdef _LP64` block This fixes a 32-bit build error - Commit messages: - Guard libJNIPoint.c impl in #ifdef _LP64 block Changes: https://git.openjdk.java.net/jdk/pull/956/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=956=00 Issue:

Re: RFR: JDK-8254920: Application launched with jpackage produced .exe crashes JVM [v2]

2020-10-30 Thread Andy Herrick
> JVM Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8254920: Application launched with jpackage produced .exe crashes JVM - Changes: - all: https://git.openjdk.java.net/jdk/pull/940/files - new:

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v14]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v13]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this

Re: RFR: 8247781: Day periods support

2020-10-30 Thread Stephen Colebourne
On Thu, 29 Oct 2020 15:59:51 GMT, Naoto Sato wrote: > Hi, > > Please review the changes for the subject issue. This is to enhance the > java.time package to support day periods, such as "in the morning", defined > in CLDR. It will add a new pattern character 'B' and its supporting builder >

Re: RFR: 8254162: Implementation of Foreign-Memory Access API (Third Incubator) [v19]

2020-10-30 Thread Maurizio Cimadamore
> This patch contains the changes associated with the third incubation round of > the foreign memory access API incubation (see JEP 393 [1]). This iteration > focus on improving the usability of the API in 3 main ways: > > * first, by providing a way to obtain truly *shared* segments, which

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v5]

2020-10-30 Thread Jan Lahoda
> This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (javac until now supported primarily only > preview