> Start of JDK 17 updates.
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains 17 additional commits since the
last revision:
- Merge branch 'm
On Fri, 13 Nov 2020 22:14:47 GMT, Michael Edgar
wrote:
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method signature change (construct
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method signature change (constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStrea
On Thu, 10 Dec 2020 02:07:14 GMT, Joe Wang wrote:
>> @JoeWang-Java - thanks for the additional feedback - all good. Do you
>> suggest I make them now in this PR? Just confirming before pushing the
>> change and dismissing your approval.
>
> Yes, please make the changes. Approval will be quick :
On Thu, 10 Dec 2020 01:06:16 GMT, Michael Edgar
wrote:
>> Looks good! Some minor comments below.
>
> @JoeWang-Java - thanks for the additional feedback - all good. Do you suggest
> I make them now in this PR? Just confirming before pushing the change and
> dismissing your approval.
Yes, plea
On Tue, 8 Dec 2020 22:12:29 GMT, Joe Darcy wrote:
>> I'll note initially that the original bug is about `equals` and `==` whereas
>> this change also covers `compareTo` and additional comparison operators `<`
>> and `>`. I believe covering this additional material **IS** important, as
>> these
On Wed, 9 Dec 2020 21:39:26 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Additional test class clean-up
>
> Looks good! Some minor comments below.
@JoeWang-Java - thanks for the additional feedb
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote:
> Changed all external executables to run via full path to avoid potential
> issues.
This pull request has now been integrated.
Changeset: eb1c8a15
Author:Alexander Matveev
URL: https://git.openjdk.java.net/jdk/commit/eb1c8a1
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote:
> Changed all external executables to run via full path to avoid potential
> issues.
Marked as reviewed by herrick (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1710
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
This pull request has now been integrated.
Changeset: 1ce2a36c
Author:Andy Herrick
URL: https://git.openjdk.java.net/jdk/commit/1ce2a36
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
>
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by kizune (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Wed, 25 Nov 2020 20:22:21 GMT, Daniel Fuchs wrote:
>> @pavelrappo
>>
>>> What is the required level of fidelity particular (pseudo-) code has to
>>> have?
>>
>> It's potentially a large discussion, one that could be had in the context of
>> my JEP draft http://openjdk.java.net/jeps/806856
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote:
> Changed all external executables to run via full path to avoid potential
> issues.
Marked as reviewed by asemenyuk (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1710
On 09-Dec-20 19:44, Mandy Chung wrote:
On 12/8/20 6:02 PM, Johannes Kuhn wrote:
There are a lot of things to consider when trying to fix JDK-8013527.
Exactly in particular security implication! What is clear is that the
expected lookup class should not be the injected class. The key
mes
On Wed, 9 Dec 2020 18:57:52 GMT, Maurizio Cimadamore
wrote:
> Lowering the mx size to 3G works - and I believe should work on 32bits too?
> Disabling the entire test seems a bit overkill IMHO.
I think -Xmx3G may be still easily broken on some 32-bit platforms since 3G >>
3800 / 2 =1900M.
---
Thanks, Pavel!
I committed this to CVS, but am not planning to include it in this
integration:
(not sure if re-generating will invalidate my "Ready" status)
(Having to cast to Future makes this more problematic, but in typical
usages the user will know that the queue contains Futures)
--- src/mai
On Wed, 9 Dec 2020 11:49:51 GMT, Michael Edgar
wrote:
>> Allow `XMLStreamException` to be thrown to the application when a filtered
>> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
>> `XMLStreamReader`.
>>
>> Note, this PR includes a method signature change (const
> 8246585: ForkJoin updates
Martin Buchholz has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains one commit:
JDK-8246585
-
Changes: https://git.openjdk.java.net/jdk/pull/1646/files
Webrev: https://webrevs.openjdk.java.net/
On Wed, 9 Dec 2020 18:58:54 GMT, Andy Herrick wrote:
> Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed
> up with merge
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/1720
On Mon, 7 Dec 2020 20:30:07 GMT, Andrey Turbanov
wrote:
> 6882207: Convert javap to use diamond operator internally
This pull request has now been integrated.
Changeset: 30de320c
Author:Andrey Turbanov
Committer: Jonathan Gibbons
URL: https://git.openjdk.java.net/jdk/commit/30de320
On Mon, 7 Dec 2020 19:51:38 GMT, Harold Seigel wrote:
> Please review this fix for JDK-8256867. This change no longer throws a
> ClassFormatError exception when loading a class whose PermittedSubclasses
> attribute is empty (contains no classes). Instead, the class is treated as a
> sealed c
On Tue, 8 Dec 2020 07:45:30 GMT, Alexander Matveev wrote:
> This is similar issue we used to have for hdiutil create/detach, but for
> "convert". Added same workaround to repeat command. I also added repeat for
> "udifrez" command just in case.
This pull request has now been integrated.
Chang
Same code change as https://github.com/openjdk/jdk/pull/1676 that got messed up
with merge
-
Commit messages:
- JDK-8257539: tools/jpackage/windows/WinL10nTest.java unpack.bat failed with
Exit code: 1618
Changes: https://git.openjdk.java.net/jdk/pull/1720/files
Webrev: https://we
On Tue, 8 Dec 2020 23:55:05 GMT, Claes Redestad wrote:
>> See here:
>> https://github.com/mcimadamore/jdk/runs/1460615378
>>
>> $ CONF=linux-x86-server-fastdebug make images run-test
>> TEST=java/foreign/TestSegments.java
>>
>> STDERR:
>> Invalid maximum heap size: -Xmx4G
>> The specified siz
On Wed, 9 Dec 2020 18:39:14 GMT, Alexey Semenyuk wrote:
>> as long as your sure these are always in /usr/bin this is fine.
>> If there is any chance of them being somewhere else instead we need a
>> findTool type mechanism
>
> What if users would like to use not the default tools with jpackage?
On 12/8/20 6:02 PM, Johannes Kuhn wrote:
There are a lot of things to consider when trying to fix JDK-8013527.
Exactly in particular security implication! What is clear is that the
expected lookup class should not be the injected class. The key
message here is that we can't fix JDK-8257
On Tue, 8 Dec 2020 21:15:48 GMT, Martin Buchholz wrote:
>> 8234131: Miscellaneous changes imported from jsr166 CVS 2020-12
>
> Martin Buchholz has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains one commit:
>
> JDK-8234131
The chang
On Wed, 9 Dec 2020 18:06:42 GMT, Andy Herrick wrote:
>> Changed all external executables to run via full path to avoid potential
>> issues.
>
> as long as your sure these are always in /usr/bin this is fine.
> If there is any chance of them being somewhere else instead we need a
> findTool type
On Tue, 8 Dec 2020 07:45:30 GMT, Alexander Matveev wrote:
> This is similar issue we used to have for hdiutil create/detach, but for
> "convert". Added same workaround to repeat command. I also added repeat for
> "udifrez" command just in case.
Marked as reviewed by asemenyuk (Committer).
---
On Wed, 9 Dec 2020 08:05:17 GMT, Alexander Matveev wrote:
> Changed all external executables to run via full path to avoid potential
> issues.
as long as your sure these are always in /usr/bin this is fine.
If there is any chance of them being somewhere else instead we need a findTool
type mec
On Tue, 8 Dec 2020 02:36:01 GMT, Mandy Chung wrote:
> `Reference::isEnqueued` method was never implemented as it was initially
> specified since 1.2. The specification says that it tests if this reference
> object has been enqueued, but the long-standing behavior is to test if this
> reference
On Tue, 8 Dec 2020 07:45:30 GMT, Alexander Matveev wrote:
> This is similar issue we used to have for hdiutil create/detach, but for
> "convert". Added same workaround to repeat command. I also added repeat for
> "udifrez" command just in case.
Marked as reviewed by herrick (Reviewer).
--
On Wed, 9 Dec 2020 15:19:58 GMT, Ivan Šipka wrote:
>> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java
>> test.
>
> Ivan Šipka has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8166026: Refactor java/lang shell tests
> java.util.HexFormat utility:
>
> - Format and parse hexadecimal strings, with parameters for delimiter,
> prefix, suffix and upper/lowercase
> - Static factories and builder methods to create HexFormat copies with
> modified parameters.
> - Consistent naming of methods for conversion of byt
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java
> test.
Ivan Šipka has updated the pull request incrementally with one additional
commit since the last revision:
8166026: Refactor java/lang shell tests to java
-
Changes:
- all: https://git.openjdk.j
> Adding support for record classes in the historical data for ct.sym. This
> includes a few changes not strictly needed for the change:
> -updating and moving tests into test/langtools, so that it is easier to run
> them.
> -fixing Record attribute reading in javac's ClassReader (used for tests,
On Fri, 27 Nov 2020 13:21:15 GMT, Jan Lahoda wrote:
> Adding support for record classes in the historical data for ct.sym. This
> includes a few changes not strictly needed for the change:
> -updating and moving tests into test/langtools, so that it is easier to run
> them.
> -fixing Record att
On Tue, 8 Dec 2020 20:42:52 GMT, Mandy Chung wrote:
>> `Reference::isEnqueued` method was never implemented as it was initially
>> specified since 1.2. The specification says that it tests if this reference
>> object has been enqueued, but the long-standing behavior is to test if this
>> refer
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote:
> Please review a small change that replaces use of objc_msgSend_stret in macOS
> platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
> support, where objc_msgSend_stret is not available.
Looks ok to me.
But it woul
On Wed, 9 Dec 2020 13:23:47 GMT, Thomas Schatzl wrote:
>> Please review this change that eliminates the use of Reference.isEnqueued by
>> tests. There were three tests using it:
>>
>> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
>> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.j
On Tue, 8 Dec 2020 23:23:55 GMT, Joe Darcy wrote:
>> Start of JDK 17 updates.
>
> Joe Darcy has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/rebase. The pull request contains 14 addi
On Tue, 8 Dec 2020 19:35:03 GMT, Jan Lahoda wrote:
>> This is an update to javac and javadoc, to introduce support for Preview
>> APIs, and generally improve javac and javadoc behavior to more closely
>> adhere to JEP 12.
>>
>> The notable changes are:
>>
>> * adding support for Preview APIs
On Tue, 8 Dec 2020 09:52:51 GMT, Kim Barrett wrote:
> Please review this change that eliminates the use of Reference.isEnqueued by
> tests. There were three tests using it:
>
> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
> jd
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote:
> Please review a small change that replaces use of objc_msgSend_stret in macOS
> platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64
> support, where objc_msgSend_stret is not available.
>From a build PoV this soun
On Tue, 8 Dec 2020 17:30:11 GMT, Mandy Chung wrote:
>> Please review this change that eliminates the use of Reference.isEnqueued by
>> tests. There were three tests using it:
>>
>> vmTestbase/gc/gctests/ReferencesGC/ReferencesGC.java
>> vmTestbase/gc/gctests/WeakReferenceGC/WeakReferenceGC.java
On Thu, 3 Dec 2020 14:14:22 GMT, Sean Mullan wrote:
>> Ivan Šipka has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8166026: Refactor java/lang shell tests to java
>> - 8166026: Refactor java/lang shell tests to java
>
> Marked as revie
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method signature change (constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStrea
On Mon, 7 Dec 2020 17:58:09 GMT, Joe Wang wrote:
>> Michael Edgar has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Correct comments/annotations
>> - Update XML stream filter test and comments
>> - Update Ja
> Allow `XMLStreamException` to be thrown to the application when a filtered
> `XMLStreamReader` encounters an `XMLStreamException` advancing the wrapped
> `XMLStreamReader`.
>
> Note, this PR includes a method signature change (constructor of
> `com.sun.org.apache.xerces.internal.impl.XMLStrea
On Wed, 9 Dec 2020 08:20:38 GMT, Nick Gasson wrote:
> This is more-or-less a straight port of the x86 code to AArch64.
> GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
> to generate a blob that jumps to the native function entry point. This
> simply switches the thread st
On Tue, 24 Nov 2020 16:13:59 GMT, Ivan Šipka wrote:
> Defined new test groups as defined in ticket. @fguallini
This pull request has now been integrated.
Changeset: 616b1f12
Author:Ivan Šipka
Committer: Alan Bateman
URL: https://git.openjdk.java.net/jdk/commit/616b1f12
Stats: 51
On Mon, 7 Dec 2020 17:31:34 GMT, Julia Boes wrote:
> This change applies a stricter semantic distinction of 'type' versus 'class
> and interface'. This is based on the JLS changes described in the "Consistent
> Class and Interface Terminology" document:
> https://download.java.net/java/early_a
On Tue, 8 Dec 2020 05:54:24 GMT, Martin Buchholz wrote:
>> 8246677: LinkedTransferQueue and SynchronousQueue synchronization updates
>
> Martin Buchholz has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> compa
This is more-or-less a straight port of the x86 code to AArch64.
GraphKit::make_native_call() calls SharedRuntime::make_native_invoker()
to generate a blob that jumps to the native function entry point. This
simply switches the thread state from Java to native and handles the
safepoint poll on retu
Changed all external executables to run via full path to avoid potential issues.
-
Commit messages:
- 8257924: Use full path when running external executable from jpackage
Changes: https://git.openjdk.java.net/jdk/pull/1710/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&p
58 matches
Mail list logo
