Accidentally public inner classes in JDK APIs?

2020-12-22 Thread Marc Hoffmann
Dear core libs developers, I recently noted that the JDK lib implementation comes with a list of public inner classes nested in package private classes. Either these classes are explicitly flagged as public or they become implicitly public when they are nested in interfaces (in accordance to JL

Re: [BUG] InputStream.readNBytes doesn't correctly check for EOF

2020-12-22 Thread Philippe Marschall
On 20.12.20 19:15, Philippe Marschall wrote: On 20.12.20 18:47, Rob Spoor wrote: ... That "> 0" is incorrect here; it's allowed to return 0 before EOF I don't think the method is allowed to return 0 before EOF. To quote from the method Javadoc. > This method blocks until input data is

[jdk16] Integrated: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. This pull request has now been integrated. Changeset: eabc9030 Author:Daniel D. Daugherty URL: https

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
On Tue, 22 Dec 2020 17:14:24 GMT, Phil Race wrote: >> ProblemList two java/rmi/Naming tests on Windows in order to reduce the >> noise in the JDK16 CI. This is a trivial fix. > > overdue Thanks for the fast reviews! - PR: https://git.openjdk.java.net/jdk16/pull/58

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Mark Sheppard
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. LGTM - Marked as reviewed by msheppar (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/58

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Phil Race
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. overdue - Marked as reviewed by prr (Reviewer). PR: https://git.openjdk.java.net/jdk16/pull/58

Re: [jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Roger Riggs
On Tue, 22 Dec 2020 16:56:33 GMT, Daniel D. Daugherty wrote: > ProblemList two java/rmi/Naming tests on Windows in order to reduce the > noise in the JDK16 CI. This is a trivial fix. Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/58

[jdk16] RFR: 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows

2020-12-22 Thread Daniel D . Daugherty
ProblemList two java/rmi/Naming tests on Windows in order to reduce the noise in the JDK16 CI. This is a trivial fix. - Commit messages: - 8258827: ProblemList Naming/DefaultRegistryPort.java and Naming/legalRegistryNames/LegalRegistryNames.java on Windows Changes: https://git.open

RFR: 8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject()

2020-12-22 Thread Weijun Wang
The method is useless now since the related TLS cipher suite was removed long ago. - Commit messages: - 8258631: Remove sun.security.jgss.krb5.Krb5Util.getSubject() Changes: https://git.openjdk.java.net/jdk/pull/1865/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1865

RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module

2020-12-22 Thread Doerr, Martin
Hi Götz, thanks for the review! Best regards, Martin From: Lindenmaier, Goetz Sent: Dienstag, 22. Dezember 2020 13:02 To: Doerr, Martin ; core-libs-dev ; jdk-updates-...@openjdk.java.net Cc: Langer, Christoph Subject: RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if modu

RE: [11u] RFR: 8241770 Module xxxAnnotation() methods throw NCDFE if module-info.class found as resource in unnamed module

2020-12-22 Thread Lindenmaier, Goetz
Hi Martin, The change looks good. The additional argument is only used for an optional printout of platform information, so not relevant for this fix - besides that it is null anyways. Best regards, Goetz. From: Doerr, Martin Sent: Monday, December 21, 2020 9:54 PM To: core-libs-dev ; jdk-