Withdrawn: 8253280: Use class name as class loading lock

2021-01-11 Thread Robert LU
On Thu, 10 Sep 2020 05:25:43 GMT, Robert LU wrote: > When many thread try to load same class, the thread will stuck on > `ClassLoader.loadClass`. > At current jdk, the stacktrace by example program is: > "Thread-1" prio=5 Id=12 BLOCKED on java.lang.Object@2e817b38 owned by > "Thread-0" Id=11 >

Re: RFR: 8257733: Move module-specific data from make to respective module [v4]

2021-01-11 Thread Magnus Ihse Bursie
On Mon, 4 Jan 2021 21:20:53 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains eight >> additional comm

Integrated: JDK-8250768: javac should be adapted to changes in JEP 12

2021-01-11 Thread Jan Lahoda
On Fri, 16 Oct 2020 15:20:03 GMT, Jan Lahoda wrote: > This is an update to javac and javadoc, to introduce support for Preview > APIs, and generally improve javac and javadoc behavior to more closely adhere > to JEP 12. > > The notable changes are: > > * adding support for Preview APIs (java

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v3]

2021-01-11 Thread Attila Szegedi
On Mon, 11 Jan 2021 05:12:11 GMT, Johannes Kuhn wrote: >> Simple fix - one line change: >> https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0. >> >> Most of the changes come from an additional test that fails without this fix: >> >> Error: Unable to load main class somelib.t

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v3]

2021-01-11 Thread Johannes Kuhn
On Mon, 11 Jan 2021 14:06:12 GMT, Attila Szegedi wrote: >> Johannes Kuhn has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add a missing pesky newline. > > Marked as reviewed by attila (Reviewer). Thanks @szegedi for reviewing this.

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v3]

2021-01-11 Thread Alan Bateman
On Mon, 11 Jan 2021 14:11:15 GMT, Johannes Kuhn wrote: >> Marked as reviewed by attila (Reviewer). > > Thanks @szegedi for reviewing this. This issue requires a Reviewer from someone working in this area. Please do not sponsor or integrate until that review has been done. - PR: h

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v3]

2021-01-11 Thread Johannes Kuhn
On Mon, 11 Jan 2021 14:13:47 GMT, Alan Bateman wrote: > > > This issue requires a Reviewer from someone working in this area. Please do > not sponsor or integrate until that review has been done. Ok, increased the number of required reviewers to 2. Hope that was the right move, as I don't s

Withdrawn: 8228988: AnnotationParser throws NullPointerException on incompatible member type

2021-01-11 Thread Rafael Winterhalter
On Sun, 18 Oct 2020 22:21:37 GMT, Rafael Winterhalter wrote: > If an annotation member type is changed in an incompatible manner, the > `AnnotationParser` currently throws a `NullPointerException` if: > > - An enumeration-typed member is changed to be an annotation type or a > `Class` type. >

[jdk16] Integrated: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl

2021-01-11 Thread Maurizio Cimadamore
On Wed, 6 Jan 2021 16:10:12 GMT, Maurizio Cimadamore wrote: > This patch tweaks `MemorySegment::mapFile` so that it will throw > `IllegalArgumentException` whenever the path to be mapped is associated with > a custom file system provider. > > The check in the implementation is heavily borrowe

Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base

2021-01-11 Thread Aleksei Efimov
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov wrote: > 8258422: Cleanup unnecessary null comparison before instanceof check in > java.base Hi @turbanoff, This PR is ready for integration - `JDK-8258657` has been resolved. You can proceed with issuing `integrate` bot command. Then I will `sp

RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
Please review this simple doc fix. - Commit messages: - 8259528: Broken Link for [java.text.Normalizer.Form] Changes: https://git.openjdk.java.net/jdk/pull/2028/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=2028&range=00 Issue: https://bugs.openjdk.java.net/browse/J

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Lance Andersen
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base

2021-01-11 Thread Andrey Turbanov
On Mon, 11 Jan 2021 16:57:00 GMT, Aleksei Efimov wrote: >> 8258422: Cleanup unnecessary null comparison before instanceof check in >> java.base > > Hi @turbanoff, > This PR is ready for integration - `JDK-8258657` has been resolved. > You can proceed with issuing `integrate` bot command. Then I

TreeMap in JDK15 deviates from spec

2021-01-11 Thread Phil Smith
Hello, I submitted bug report 9068554 recently, but I consider this a pretty big issue and I'd like for this not to get lost in triage. With JDK-8176894, a specialized implementation for computeIfAbsent was added to TreeMap, however it doesn't handle null values correctly. Spec states a mapping to

Re: RFR: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes [v2]

2021-01-11 Thread Valerie Peng
On Fri, 8 Jan 2021 21:30:14 GMT, Martin Balao wrote: >> As described in JDK-8259319 [1], this fix proposal is to set proper access >> permissions so the SunPKCS11 provider can create instances of SunJCE classes >> when a Security Manager is installed and the fallback scheme is used. >> >> No r

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Joe Wang
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Oops, forgot to submit the review ;-) src/java.base/share/classes/java/text/Normalizer.java line 48: > 46: * The {@code normalize} method supports the standard normalization forms > 47: * described in >

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Iris Clark
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Re: TreeMap in JDK15 deviates from spec

2021-01-11 Thread Rob Spoor
This is a regression, because Java 11 shows "default" twice for the TreeMap, whereas Java 15 shows "null" twice. On 11/01/2021 19:05, Phil Smith wrote: Hello, I submitted bug report 9068554 recently, but I consider this a pretty big issue and I'd like for this not to get lost in triage. With

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
On Mon, 11 Jan 2021 17:35:58 GMT, Joe Wang wrote: >> Please review this simple doc fix. > > src/java.base/share/classes/java/text/Normalizer.java line 48: > >> 46: * The {@code normalize} method supports the standard normalization forms >> 47: * described in >> 48: * https://www.unicode.org/r

Re: RFR: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Joe Wang
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2028

Re: RFR: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes [v2]

2021-01-11 Thread Sean Mullan
On Fri, 8 Jan 2021 21:30:14 GMT, Martin Balao wrote: >> As described in JDK-8259319 [1], this fix proposal is to set proper access >> permissions so the SunPKCS11 provider can create instances of SunJCE classes >> when a Security Manager is installed and the fallback scheme is used. >> >> No r

Integrated: 8259528: Broken Link for [java.text.Normalizer.Form]

2021-01-11 Thread Naoto Sato
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote: > Please review this simple doc fix. This pull request has now been integrated. Changeset: cd73939b Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/commit/cd73939b Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod 8

RFR: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
Forwardport JDK 16 -> JDK 17 - Commit messages: - Merge - 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing - 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl - 8259043: More Zero architectures need linkage with libatom

[jdk16] RFR: 8259298: broken link in Stream::toList spec

2021-01-11 Thread Stuart Marks
Just fixing a broken link. - Commit messages: - 8259298: broken link in Stream::toList spec Changes: https://git.openjdk.java.net/jdk16/pull/106/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk16&pr=106&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259298 St

Re: [jdk16] RFR: 8259298: broken link in Stream::toList spec

2021-01-11 Thread Brent Christian
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote: > Just fixing a broken link. Marked as reviewed by bchristi (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/106

Re: [jdk16] RFR: 8259298: broken link in Stream::toList spec

2021-01-11 Thread Lance Andersen
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote: > Just fixing a broken link. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/106

Re: [jdk16] RFR: 8259298: broken link in Stream::toList spec

2021-01-11 Thread Iris Clark
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote: > Just fixing a broken link. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/106

Re: [jdk16] RFR: 8259298: broken link in Stream::toList spec

2021-01-11 Thread Naoto Sato
On Mon, 11 Jan 2021 23:15:07 GMT, Stuart Marks wrote: > Just fixing a broken link. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk16/pull/106

Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base

2021-01-11 Thread Aleksei Efimov
On Mon, 11 Jan 2021 23:29:53 GMT, Aleksei Efimov wrote: >> @AlekseiEfimov `HttpClientImpl` is not in `java.base` module. So I think >> it's better to not touch it under this PR. > > To double check that docs build will be stable after integration the > following actions have been performed: > -

Re: RFR: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base

2021-01-11 Thread Aleksei Efimov
On Mon, 11 Jan 2021 17:12:24 GMT, Andrey Turbanov wrote: >> Hi @turbanoff, >> This PR is ready for integration - `JDK-8258657` has been resolved. >> You can proceed with issuing `integrate` bot command. Then I will `sponsor` >> it. >> But before that, I would like to ask if you would like to ta

Integrated: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base

2021-01-11 Thread Andrey Turbanov
On Sat, 5 Sep 2020 18:55:53 GMT, Andrey Turbanov wrote: > 8258422: Cleanup unnecessary null comparison before instanceof check in > java.base This pull request has now been integrated. Changeset: 022bc9f0 Author:Andrey Turbanov Committer: Aleksei Efimov URL: https://git.openjdk.ja

Re: RFR: Merge jdk16 [v2]

2021-01-11 Thread Jesper Wilhelmsson
> Forwardport JDK 16 -> JDK 17 Jesper Wilhelmsson has updated the pull request incrementally with one additional commit since the last revision: Merge - Changes: - all: https://git.openjdk.java.net/jdk/pull/2040/files - new: https://git.openjdk.java.net/jdk/pull/2040/files/e5

Integrated: Merge jdk16

2021-01-11 Thread Jesper Wilhelmsson
On Mon, 11 Jan 2021 22:04:16 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 16 -> JDK 17 This pull request has now been integrated. Changeset: b378f54d Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/b378f54d Stats: 139 lines in 12 files changed: 116 ins

RFR: 8259401: Add checking to jarsigner to warn weak algorithms used in si…

2021-01-11 Thread Hai-May Chao
The jarsigner tool currently provides warning associated with the signer’s cert when it uses weak algorithms, but not for the CA certs. This change is to process the signer’s cert chain to warn if CA certs use weak algorithms. - Commit messages: - 8259401: Add checking to jarsigner

Re: RFR: 5023614: UUID needs methods to get most/leastSigBits and write to DataOutput

2021-01-11 Thread Richard Fussenegger
On Mon, 14 Dec 2020 20:18:01 GMT, Roger Riggs wrote: >> Made byte constructor public and changed the length assertion to an >> `IllegalArgumentException`, added a `getBytes` method that allows users to >> retrieve the raw bytes of the UUID, and created a new private constructor >> with an opti