Re: RFR: 8259074: regex benchmarks and tests [v2]

> 8259074: regex benchmarks and tests Martin Buchholz has updated the pull request incrementally with one additional commit since the last revision: address comments from @amalloy; introduce technically correct use of "numeral" - Changes: - all:

Re: RFR: 8259074: regex benchmarks and tests

On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote: > 8259074: regex benchmarks and tests test/jdk/java/util/regex/TestCases.txt line 1248: > 1246: false 1 > 1247: > 1248: // Unary power of two (8), reluctant quantifier I think the comment here is meant as "Giving a power of 2 as input

Re: RFR: 8259074: regex benchmarks and tests

On Tue, 5 Jan 2021 03:15:56 GMT, Martin Buchholz wrote: > 8259074: regex benchmarks and tests @amalloy - you are invited to comment on regex content @cl4es @shipilev - you are invited to point out my jmh bad practices - PR: https://git.openjdk.java.net/jdk/pull/1940

RFR: 8259074: regex benchmarks and tests

8259074: regex benchmarks and tests - Commit messages: - more benchmarks - JDK-8259074 Changes: https://git.openjdk.java.net/jdk/pull/1940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=1940=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8259074 Stats: 444 lines

Re: bug jpackage in JDK 15

> On Jan 29, 2021, at 7:37 PM, Michael Hall wrote: > > > >> On Jan 26, 2021, at 7:16 PM, Michael Hall > > wrote: >> >>> >>> >>> When I open the built dmg there is an application icon, a drag to >>> indicating arrow, but no application folder icon as the drag

Re: Why does Set.of disallow duplicate elements?

Set.of() is the closest way we've got to a literal Set without having introduced a special syntax for that in the language. The idea is that if you conceptually want to write Set set = { "hello", "world" }; instead, you write Set set = Set.of("hello", "world"); In that context, it makes

Re: RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation [v3]

> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is > only used from ZipFile.initCEN right after the checkEncoding today, so > verifying this is equivalent is straightforward. > - Factor out the logic to calculate hash, check encoding etc into the > addEntry method to

Why does Set.of disallow duplicate elements?

Dear users, While looking at the implementation of Set.of(...) I noticed that duplicate elements are not allowed, e.g. Set.of(1, 1) will throw an IllegalArgumentException. Why has it been decided to do this? My expectation was that duplicates would simply be removed. If I do for instance new

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v3]

On Sat, 30 Jan 2021 00:06:51 GMT, Phil Race wrote: >> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> phil comment > > Marked as reviewed by prr (Reviewer). Added a test. Unfortunately it has to be `manual` because updating

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v5]

> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has

Re: RFR: 8257858: [macOS]: Remove JNF dependency from libosxsecurity/KeystoreImpl.m [v4]

> This fix covers both > > - [[macOS]: Remove JNF dependency from > libosxsecurity/KeystoreImpl.m](https://bugs.openjdk.java.net/browse/JDK-8257858) > - [[macOS]: Remove JNF dependency from > libosxkrb5/SCDynamicStoreConfig.m](https://bugs.openjdk.java.net/browse/JDK-8257860) Weijun Wang has

RFR: 8260401: StackOverflowError on open WindowsPreferences

Can I please get a review for this change which proposes to fix the issue reported in https://bugs.openjdk.java.net/browse/JDK-8260401? As noted in that issue, when the constructor of `java.util.prefs.WindowsPreferences` runs into an error while dealing with the Windows registry, it logs a