Re: RFR: 8259074: regex benchmarks and tests [v2]

2021-01-31 Thread Martin Buchholz
On Sun, 31 Jan 2021 08:18:28 GMT, Aleksey Shipilev wrote: >> Martin Buchholz has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address comments from @amalloy; introduce technically correct use of >> "numeral" > > test/micro/org/openjdk/be

Re: Why does Set.of disallow duplicate elements?

2021-01-31 Thread forax
De: "dfranken jdk" À: "Remi Forax" Cc: "core-libs-dev" Envoyé: Dimanche 31 Janvier 2021 13:54:44 Objet: Re: Why does Set.of disallow duplicate elements? BQ_BEGIN Okay, I understand this reasoning, but when you want to construct a Set from an array, you might be tempted to use Se

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-01-31 Thread Vladimir Kempik
On Mon, 25 Jan 2021 09:48:46 GMT, Andrew Haley wrote: >> Would you like me to do something about it now? The problem is that the >> functions of SlowSignatureHandler are subtly different, so it will be >> multiple tables, not sure how many. Such change is another candidate for a >> separate co

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v8]

2021-01-31 Thread Anton Kozlov
> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8260617: Merge ZipFile encoding check with the initial hash calculation [v3]

2021-01-31 Thread Lance Andersen
On Sat, 30 Jan 2021 18:30:59 GMT, Claes Redestad wrote: >> - Merge checkEncoding into the byte[]-based normalizedHash. The latter is >> only used from ZipFile.initCEN right after the checkEncoding today, so >> verifying this is equivalent is straightforward. >> - Factor out the logic to calcula

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v6]

2021-01-31 Thread Alan Bateman
On Sun, 31 Jan 2021 16:26:58 GMT, Johannes Kuhn wrote: >> Simple fix - one line change: >> https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0. >> >> Most of the changes come from an additional test that fails without this fix: >> >> Error: Unable to load main class somelib.t

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v6]

2021-01-31 Thread Johannes Kuhn
> Simple fix - one line change: > https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0. > > Most of the changes come from an additional test that fails without this fix: > > Error: Unable to load main class somelib.test.TestMain in module somelib > java.lang.IllegalAccessEr

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource [v2]

2021-01-31 Thread Jim Laskey
I’ve been handing out the original jimage docs on request. Surprisingly, it’s still accurate. Will dig up on Monday to post. 📱 > On Jan 31, 2021, at 11:07 AM, Alan Bateman wrote: > > On Wed, 27 Jan 2021 18:22:54 GMT, Jim Laskey wrote: > >>> Claes Redestad has updated the pull request incr

Re: RFR: 8260337: Optimize ImageReader lookup, used by Class.getResource [v2]

2021-01-31 Thread Alan Bateman
On Wed, 27 Jan 2021 18:22:54 GMT, Jim Laskey wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Copyrights and rename containsLocation > > Nice clean up. LGTM @JimLaskey Do you have anything that documents the jima

Re: Why does Set.of disallow duplicate elements?

2021-01-31 Thread Dave Franken
Okay, I understand this reasoning, but when you want to construct a Set from an array, you might be tempted to use Set.of(...) because it looks like it supports an array and indeed, you can do Set.of(new int[] {1, 2 }) I believe? Maybe this is just a quirk because of how varargs work. I wondered

Re: RFR: JDK-8259395 Patching automatic module with additional packages re-creates module without "requires java.base" [v5]

2021-01-31 Thread Alan Bateman
On Tue, 19 Jan 2021 23:12:02 GMT, Johannes Kuhn wrote: >> Simple fix - one line change: >> https://openjdk.github.io/cr/?repo=jdk&pr=2000&range=00#sdiff-0. >> >> Most of the changes come from an additional test that fails without this fix: >> >> Error: Unable to load main class somelib.t

Re: RFR: 8259074: regex benchmarks and tests [v2]

2021-01-31 Thread Aleksey Shipilev
On Sat, 30 Jan 2021 22:43:10 GMT, Martin Buchholz wrote: >> 8259074: regex benchmarks and tests > > Martin Buchholz has updated the pull request incrementally with one > additional commit since the last revision: > > address comments from @amalloy; introduce technically correct use of > "num