Re: RFR: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"

2021-02-22 Thread Joe Wang
On Tue, 23 Feb 2021 02:09:01 GMT, Naoto Sato wrote: > Please review the fix to this test case failure that occurs with the usage > tracker enabled JRE. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2683

Re: RFR: 8253409: Double-rounding possibility in float fma [v2]

2021-02-22 Thread Joe Darcy
> In floating-point, usually doing an operation to double precision and then > rounding to float gives the right result in float precision. One exception to > this is fused multiply add (fma) where "a * b + c" is computed with a single > rounding. This requires the equivalent of extra

Re: RFR: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized* [v4]

2021-02-22 Thread Joe Darcy
On Mon, 22 Feb 2021 23:39:15 GMT, Claes Redestad wrote: >> Ian Graves has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updating Collections.java copyright > > This looks good to me. Is there any behavior change here that merits a CSR

RFR: 8253409: Double-rounding possibility in float fma

2021-02-22 Thread Joe Darcy
In floating-point, usually doing an operation to double precision and then rounding to float gives the right result in float precision. One exception to this is fused multiply add (fma) where "a * b + c" is computed with a single rounding. This requires the equivalent of extra intermediate

RFR: 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null"

2021-02-22 Thread Naoto Sato
Please review the fix to this test case failure that occurs with the usage tracker enabled JRE. - Commit messages: - 8261919: java/util/Locale/LocaleProvidersRun.java failed with "RuntimeException: Expected log was not emitted. LogRecord: null" Changes:

Integrated: 8261975: Missing "classpath exception" in VectorSupport.java

2021-02-22 Thread Paul Sandoz
On Mon, 22 Feb 2021 21:57:00 GMT, Paul Sandoz wrote: > Add missing classpath exception paragraph This pull request has now been integrated. Changeset: 0217d699 Author:Paul Sandoz URL: https://git.openjdk.java.net/jdk/commit/0217d699 Stats: 4 lines in 1 file changed: 2 ins; 0

Re: RFR: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized* [v4]

2021-02-22 Thread Claes Redestad
On Mon, 22 Feb 2021 22:08:56 GMT, Ian Graves wrote: >> Modify the `unmodifiable*` methods in `java.util.Collections` to be >> idempotent. That is, when given an immutable collection from >> `java.util.ImmutableCollections` or `java.util.Collections`, these methods >> will return the reference

Re: RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-22 Thread Brian Burkhalter
On Mon, 22 Feb 2021 23:27:19 GMT, Brian Burkhalter wrote: > 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in > subclass overrides This change proposes to use {@inheritDoc} to improve consistency of the specification of `Reader.read(char[],in,in)` in `Reader` and its

RFR: 8258444: Clean up specifications of java.io.Reader.read(char[], int, int) in subclass overrides

2021-02-22 Thread Brian Burkhalter
8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides - Commit messages: - 8258444: Fix trailing whitesoace - 8258444: Clean up specifications of java.io.Reader.read(char[],int,int) in subclass overrides Changes:

Re: RFR: 8261975: Missing "classpath exception" in VectorSupport.java

2021-02-22 Thread Mandy Chung
On Mon, 22 Feb 2021 21:57:00 GMT, Paul Sandoz wrote: > Add missing classpath exception paragraph Marked as reviewed by mchung (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2678

Re: RFR: 6323374: (coll) Optimize Collections.unmodifiable* and synchronized* [v4]

2021-02-22 Thread Ian Graves
> Modify the `unmodifiable*` methods in `java.util.Collections` to be > idempotent. That is, when given an immutable collection from > `java.util.ImmutableCollections` or `java.util.Collections`, these methods > will return the reference instead of creating a new immutable collection that >

RFR: 8261975: Missing "classpath exception" in VectorSupport.java

2021-02-22 Thread Paul Sandoz
Add missing classpath exception paragraph - Commit messages: - 8261975: Missing "classpath exception" in VectorSupport.java Changes: https://git.openjdk.java.net/jdk/pull/2678/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2678=00 Issue:

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v11]

2021-02-22 Thread Ivan Šipka
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java > test. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8166026: Refactor java/lang shell tests to java - Changes: - all:

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v10]

2021-02-22 Thread Ivan Šipka
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java > test. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8166026: Refactor java/lang shell tests to java - Changes: - all:

Re: RFR: 8262066: ProblemList java/util/Locale/LocaleProvidersRun.java [v2]

2021-02-22 Thread Naoto Sato
> The subject test case is failing under the JMS-enabled environment. Naoto Sato has updated the pull request incrementally with one additional commit since the last revision: Limit the exclustion to linux-x64 - Changes: - all: https://git.openjdk.java.net/jdk/pull/2657/files

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v9]

2021-02-22 Thread Daniel Fuchs
On Mon, 22 Feb 2021 15:50:03 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v9]

2021-02-22 Thread Ivan Šipka
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java > test. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8166026: Refactor java/lang shell tests to java - Changes: - all:

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v8]

2021-02-22 Thread Igor Ignatyev
On Mon, 22 Feb 2021 15:24:19 GMT, Ivan Šipka wrote: >> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java >> test. > > Ivan Šipka has updated the pull request incrementally with one additional > commit since the last revision: > > 8166026: Refactor java/lang shell

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v8]

2021-02-22 Thread Igor Ignatyev
On Mon, 22 Feb 2021 15:33:30 GMT, Igor Ignatyev wrote: >> Ivan Šipka has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8166026: Refactor java/lang shell tests to java > > test/jdk/java/lang/annotation/LoaderLeakTest.java line 68: > >>

Re: RFR: 8259267: Refactor LoaderLeak shell test as java test. [v8]

2021-02-22 Thread Ivan Šipka
> Refactor `test/jdk/java/lang/annotation/loaderLeak/LoaderLeak.sh` as java > test. Ivan Šipka has updated the pull request incrementally with one additional commit since the last revision: 8166026: Refactor java/lang shell tests to java - Changes: - all:

Re: RFR: 8248862: Implement Enhanced Pseudo-Random Number Generators [v22]

2021-02-22 Thread Jim Laskey
> This PR is to introduce a new random number API for the JDK. The primary API > is found in RandomGenerator and RandomGeneratorFactory. Further description > can be found in the JEP https://openjdk.java.net/jeps/356 . > > javadoc can be found at >

Integrated: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test)

2021-02-22 Thread Doug Lea
On Sat, 20 Feb 2021 14:17:16 GMT, Doug Lea wrote: > This addresses interactions between parallelism-0 and new shutdown support in > https://bugs.openjdk.java.net/browse/JDK-8259800 This pull request has now been integrated. Changeset: 5b7b18c5 Author:Doug Lea URL:

Re: RFR: 8259800: timeout in tck test testForkJoin(ForkJoinPool8Test) [v2]

2021-02-22 Thread Doug Lea
On Mon, 22 Feb 2021 02:50:34 GMT, David Holmes wrote: >> Doug Lea has updated the pull request incrementally with one additional >> commit since the last revision: >> >> JDK-8259800 > > Hi Doug, > > This looked a little more involved from the version I tested so I re-ran it > through the

ThreadLocal lookup elimination

2021-02-22 Thread Eirik Bjørsnøs
Hello, ThreadLocals are commonly used to transfer state across method boundaries in situations where passing them as method parameters is impractical. Examples include crossing APIs you don't own, or instrumenting code you don't own. Consider the following pseudo-instrumented code (where the

Integrated: 8248318: Remove superfluous use of boxing in ObjectStreamClass

2021-02-22 Thread Julia Boes
On Fri, 19 Feb 2021 10:14:54 GMT, Julia Boes wrote: > This change removes some instances of superfluous boxing in > java.io.ObjectStreamClass. > Testing: tier 1-3 all clear. This pull request has now been integrated. Changeset: e9d7c07b Author:Julia Boes URL:

Re: RFR: 8252883: AccessDeniedException caused by delayed file deletion on Windows [v5]

2021-02-22 Thread Evan Whelan
On Fri, 19 Feb 2021 14:06:23 GMT, Daniel Fuchs wrote: >> LGTM > > I'm seeing some intermittent test failures with the new test (after merging > in latest master changes). Can you retest and have a look: > > --System.out:(25/1343)-- > Testing with arguments: type=process,

Re: RFR: 8252883: AccessDeniedException caused by delayed file deletion on Windows [v6]

2021-02-22 Thread Evan Whelan
> Hi, > > Please review this fix for JDK-8252883. This handles the case when an > AccessDeniedException is being thrown on Windows, due to a delay in deleting > the lock file it is trying to write to. > > This fix passes all testing. > > Kind regards, > Evan Evan Whelan has updated the pull