On Wed, 10 Mar 2021 05:23:51 GMT, Vyom Tewari wrote:
> but what i observed is the test case which was attached by original submitter
> passes null to DynamicConstantDesc as follows "DynamicConstantDesc.of(null)".
> If you pass valid argument like(ConstantDescs.BSM_INVOKE) no deadlock.
Hello Vy
The javadoc of various methods in core reflection would be improved by links
into the JLS.
-
Commit messages:
- 826: Improve links from core reflection to JLS and JVMS
Changes: https://git.openjdk.java.net/jdk/pull/2906/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&
On Wed, 10 Mar 2021 02:15:28 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed patch for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8263108?
>>
>> As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
>> `java.lang.constant.Consta
On Fri, 5 Mar 2021 21:25:20 GMT, Joe Darcy wrote:
> The existing documentation of Method.isBridge isn't terribly helpful to the
> reader. This RFE proposes to given a common example of how bridge methods are
> used. The JLS does *not* have a section discussing bridge methods in detail;
> bridg
> The existing documentation of Method.isBridge isn't terribly helpful to the
> reader. This RFE proposes to given a common example of how bridge methods are
> used. The JLS does *not* have a section discussing bridge methods in detail;
> bridge methods are a compilation technique for lowering t
On Tue, 9 Mar 2021 16:50:40 GMT, Alexey Semenyuk wrote:
>> Add support to insert dialog with prompts to create shortcuts in dialog
>> installation sequence of Windows installers created by jpackage.
>>
>> Dialog look:
>>  in the tryCanonicalize method (thus requiring no
>>> lock
> Can I please get a review for this proposed patch for the issue reported in
> https://bugs.openjdk.java.net/browse/JDK-8263108?
>
> As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
> `java.lang.constant.ConstantDescs` can end up in a classloading deadlock due
> to the
On Tue, 9 Mar 2021 23:38:26 GMT, Joe Darcy wrote:
>> The existing documentation of Method.isBridge isn't terribly helpful to the
>> reader. This RFE proposes to given a common example of how bridge methods
>> are used. The JLS does *not* have a section discussing bridge methods in
>> detail; b
On Tue, 9 Mar 2021 19:51:42 GMT, Stuart Marks wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/reflect/Method.java line 579:
>
>> 577: * Bridg
> The existing documentation of Method.isBridge isn't terribly helpful to the
> reader. This RFE proposes to given a common example of how bridge methods are
> used. The JLS does *not* have a section discussing bridge methods in detail;
> bridge methods are a compilation technique for lowering t
On Mon, 8 Mar 2021 21:25:32 GMT, Ian Graves wrote:
> This fixes a zero-adding issue observed in the hex float conversion.
This all looks fine - just update the copyright year in Formatter.java, please.
In my personal opinion, this behavior change does not rise to the level of
needing a CSR, bu
On Tue, 9 Mar 2021 19:13:24 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/reflect/Method.java line 589:
>>
>>> 587: * different return type, the virtual machine does not.
>>> 588: * A
>>> 589: * common case where covariant overrides are used is for a {@link
>>
>>
On Tue, 9 Mar 2021 22:35:19 GMT, Joe Darcy wrote:
>> The existing documentation of Method.isBridge isn't terribly helpful to the
>> reader. This RFE proposes to given a common example of how bridge methods
>> are used. The JLS does *not* have a section discussing bridge methods in
>> detail; b
> The existing documentation of Method.isBridge isn't terribly helpful to the
> reader. This RFE proposes to given a common example of how bridge methods are
> used. The JLS does *not* have a section discussing bridge methods in detail;
> bridge methods are a compilation technique for lowering t
On 3/9/2021 12:03 PM, Stuart Marks wrote:
On Tue, 9 Mar 2021 19:13:24 GMT, Joe Darcy wrote:
src/java.base/share/classes/java/lang/reflect/Method.java line 589:
587: * different return type, the virtual machine does not.
588: * A
589: * common case where covariant overrides are
> Fix various things pointed out by the most recent doclint run in the
> security-libs area.
>
> This is docs only: I will be checking doccheck/doclint, and will be running
> tier1/tier2 tests. Minor spot checks on generated files.
Bradford Wetmore has updated the pull request incrementally w
ObjectStreamPrinter is a Formatter plugin to the test library HexPrinter.
A binary stream of serialized java objects is converted into a textual form by
parsing the header, typecodes, and interpreting the stream contents. The
formatter can be used standalone or with the HexPrinter to align the f
On Tue, 9 Mar 2021 21:37:16 GMT, Roger Riggs wrote:
> ObjectStreamPrinter is a Formatter plugin to the test library HexPrinter.
>
> A binary stream of serialized java objects is converted into a textual form
> by parsing the header, typecodes, and interpreting the stream contents. The
> format
On Tue, 9 Mar 2021 03:27:29 GMT, Joe Darcy wrote:
>> The existing documentation of Method.isBridge isn't terribly helpful to the
>> reader. This RFE proposes to given a common example of how bridge methods
>> are used. The JLS does *not* have a section discussing bridge methods in
>> detail; b
On Tue, 9 Mar 2021 19:13:24 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/lang/reflect/Method.java line 589:
>>
>>> 587: * different return type, the virtual machine does not.
>>> 588: * A
>>> 589: * common case where covariant overrides are used is for a {@link
>>
>>
On Tue, 9 Mar 2021 03:27:29 GMT, Joe Darcy wrote:
>> The existing documentation of Method.isBridge isn't terribly helpful to the
>> reader. This RFE proposes to given a common example of how bridge methods
>> are used. The JLS does *not* have a section discussing bridge methods in
>> detail; b
On Tue, 9 Mar 2021 07:19:27 GMT, Rémi Forax
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/lang/reflect/Method.java line 589:
>
>> 587: * differ
On Mon, 1 Mar 2021 10:31:19 GMT, Andrew Haley wrote:
>> Anton Kozlov has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/jdk/jdk-macos' into jdk-macos
>> - Minor fixes
>
> src/hotspot/cpu/aarch64/globa
On Tue, 9 Feb 2021 09:23:50 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update signal handler part for debugger
>
> src/hotspot/share/runtime/thread.cpp line 2515:
>
>> 2513: void JavaThre
On Tue, 9 Mar 2021 13:50:05 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this proposed patch for the issue reported in
>> https://bugs.openjdk.java.net/browse/JDK-8263108?
>>
>> As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
>> `java.lang.constant.Constan
On Tue, 9 Feb 2021 09:12:13 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update signal handler part for debugger
>
> src/hotspot/share/runtime/thread.hpp line 848:
>
>> 846: void init_wx(
> Add support to insert dialog with prompts to create shortcuts in dialog
> installation sequence of Windows installers created by jpackage.
> As a side effect of the fix, UI-related WiX source code was moved from
> main.wxs into generated ui.wxf file. Users can override ui.wxf by placing a
> fi
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated files
On Tue, 9 Mar 2021 16:10:11 GMT, Sean Mullan wrote:
>> Bradford Wetmore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Codereview Comment
>
> src/java.base/share/classes/javax/crypto/SealedObject.java line 428:
>
>> 426: * @throws
> Please review the implementation of JEP 391: macOS/AArch64 Port.
>
> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and
> windows/aarch64.
>
> Major changes are in:
> * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks
> JDK-8253817, JDK-8253818)
On Tue, 9 Feb 2021 09:06:26 GMT, Stefan Karlsson wrote:
>> Anton Kozlov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update signal handler part for debugger
>
> src/hotspot/share/runtime/threadWXSetters.hpp line 28:
>
>> 26: #define
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated files
Hi,
The code in both versions of ProcessEnvironment is mostly pre-2007
seem to have the same original author.
It is the typical inheritance vs delegation choice and likely driven by
the details
of what was being stored and the OS specific details that need to be
processed.
For example, Linux
Can I please get a review for this proposed patch for the issue reported in
https://bugs.openjdk.java.net/browse/JDK-8263108?
As noted in that issue, the `java.lang.constant.DynamicConstantDesc` and
`java.lang.constant.ConstantDescs` can end up in a classloading deadlock due to
the nature of th
On Tue, 9 Mar 2021 13:46:04 GMT, Jaikiran Pai wrote:
> An alternate approach that I thought of was to completely get rid of this
> shared cache canonicalMap and instead just use method level map (that gets
> initialized each time) in the tryCanonicalize method (thus requiring no
> locks/synchr
Hi all,
One of my colleagues discovered an intriguing difference between Linux and
Windows, in the context of GraalVM native-image, when it comes to the
returned value for System.getenv().
On windows, the native test he's encountered that a test fails with:
> Error: No instances of java.lang.Pro
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
This pull request has now b
On Fri, 12 Feb 2021 11:46:09 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset for JDK-8252399: 'Update mapMulti
> documentation to use type test pattern instead of instanceof once JEP 375
> exits preview' ?
>
> This change updates the example code displayed in
On Tue, 9 Mar 2021 00:56:25 GMT, Bradford Wetmore wrote:
>> Fix various things pointed out by the most recent doclint run in the
>> security-libs area.
>>
>> This is docs only: I will be checking doccheck/doclint, and will be running
>> tier1/tier2 tests. Minor spot checks on generated files
On Sat, 6 Mar 2021 01:35:28 GMT, Craig Andrews
wrote:
>> `java.net.URLClassLoader.getResource` can throw an undocumented
>> `IllegalArgumentException`.
>>
>> According to the javadoc for the `getResource` and `findResource` methods,
>> neither should be throwing `IllegalArgumentException` - t
42 matches
Mail list logo
