Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

On 12/03/2021 5:12 pm, Anton Kozlov wrote: On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote: Anton Kozlov has updated the pull request incrementally with one additional commit since the last revision: 8262903: [macos_aarch64] Thread::current() called on detached thread

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

On Fri, 12 Mar 2021 05:24:10 GMT, David Holmes wrote: >> Anton Kozlov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8262903: [macos_aarch64] Thread::current() called on detached thread > >

Re: RFR: 8263108: Class initialization deadlock in java.lang.constant [v2]

On Wed, 10 Mar 2021 06:36:58 GMT, Jaikiran Pai wrote: >> Your code change Looks reasonable to me. Although i am not export in this >> area but what i observed is the test case which was attached by original >> submitter passes null to DynamicConstantDesc as follows >>

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review the patch which moves `ClassFileInstaller` class to > `jdk.test.lib.helpers` package? > to reduce changes in the tests, `ClassFileInstaller` in the default package > is kept w/ just `main` method

Integrated: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. This pull request has now been integrated. Changeset: cf1c0219 Author:Daniel D. Daugherty URL: https://git.openjdk.java.net/jdk/commit/cf1c0219 Stats: 2 lines

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth and @azvegint - Thanks for the reviews! - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:44:18 GMT, Daniel D. Daugherty wrote: >> A trivial fix to ProblemList two new tests on Windows. > > @alexeysemenyukoracle or @kevinrushforth - can either of you folks review > this ProblemListing? Sure, although I a not a Reviewer in the jdk project, so it will need one

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. Marked as reviewed by azvegint (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:50:03 GMT, Kevin Rushforth wrote: >> A trivial fix to ProblemList two new tests on Windows. > > Marked as reviewed by kcr (Author). @kevinrushforth - Thanks for the heads up. I've pinged in the jdk-gatekeeping Slack channel. - PR:

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. Marked as reviewed by kcr (Author). - PR: https://git.openjdk.java.net/jdk/pull/2952

Re: RFR: 8263480: ProblemList two jpackage tests on Windows

On Thu, 11 Mar 2021 23:41:53 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList two new tests on Windows. @alexeysemenyukoracle or @kevinrushforth - can either of you folks review this ProblemListing? - PR: https://git.openjdk.java.net/jdk/pull/2952

RFR: 8263480: ProblemList two jpackage tests on Windows

A trivial fix to ProblemList two new tests on Windows. - Commit messages: - 8263480: ProblemList two jpackage tests on Windows Changes: https://git.openjdk.java.net/jdk/pull/2952/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2952=00 Issue:

Re: RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review the patch which moves `ClassFileInstaller` class to > `jdk.test.lib.helpers` package? > to reduce changes in the tests, `ClassFileInstaller` in the default package > is kept w/ just `main` method

Re: RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

On Thu, 11 Mar 2021 05:47:00 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review the patch which moves `ClassFileInstaller` class to > `jdk.test.lib.helpers` package? > to reduce changes in the tests, `ClassFileInstaller` in the default package > is kept w/ just `main` method

Re: RFR: 8251942: PrintStream specification is not clear which flush method is automatically invoked

On Thu, 11 Mar 2021 19:09:08 GMT, Daniel Fuchs wrote: >> Please review this minor change to the specification of >> `java.io.PrintStream`. The longstanding behavior for flushing is to invoke >> the `flush()` method of the underlying `OutputStream` rather than its >> override but this was not

Re: RFR: 8251942: PrintStream specification is not clear which flush method is automatically invoked [v2]

> Please review this minor change to the specification of > `java.io.PrintStream`. The longstanding behavior for flushing is to invoke > the `flush()` method of the underlying `OutputStream` rather than its > override but this was not made explicit in the specification. Brian Burkhalter has

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v12]

On Tue, 9 Mar 2021 17:55:12 GMT, Anton Kozlov wrote: >> src/hotspot/share/runtime/thread.cpp line 2515: >> >>> 2513: void JavaThread::check_special_condition_for_native_trans(JavaThread >>> *thread) { >>> 2514: // Enable WXWrite: called directly from interpreter native wrapper. >>> 2515:

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

On Thu, 11 Mar 2021 14:07:43 GMT, Anton Kozlov wrote: >> Please review the implementation of JEP 391: macOS/AArch64 Port. >> >> It's heavily based on existing ports to linux/aarch64, macos/x86_64, and >> windows/aarch64. >> >> Major changes are in: >> * src/hotspot/cpu/aarch64: support of

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

On Thu, 11 Mar 2021 16:42:24 GMT, Patrick Concannon wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request

RFR: 8263412: ClassFileInstaller can't be used by classes outside of default package

Hi all, could you please review the patch which moves `ClassFileInstaller` class to `jdk.test.lib.helpers` package? to reduce changes in the tests, `ClassFileInstaller` in the default package is kept w/ just `main` method that calls `jdk.test.lib.helpers. ClassFileInstaller::main`. from

Re: RFR: 8251942: PrintStream specification is not clear which flush method is automatically invoked

On Wed, 10 Mar 2021 23:03:03 GMT, Brian Burkhalter wrote: > Please review this minor change to the specification of > `java.io.PrintStream`. The longstanding behavior for flushing is to invoke > the `flush()` method of the underlying `OutputStream` rather than its > override but this was not

Integrated: 8241716: Jpackage functionality to let users choose whether to create shortcuts

On Mon, 8 Mar 2021 22:54:50 GMT, Alexey Semenyuk wrote: > Add support to insert dialog with prompts to create shortcuts in dialog > installation sequence of Windows installers created by jpackage. > > Dialog look: >

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

On Thu, 11 Mar 2021 08:56:00 GMT, Alan Bateman wrote: >> Patrick Concannon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8263358: Refactored equals methods > > src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v3]

> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request incrementally with one additional commit since the last revision:

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable

On Wed, 10 Mar 2021 15:08:53 GMT, Claes Redestad wrote: >> Hi, >> >> Could someone please review my code for updating the code in the `java.lang` >> package to make use of the `instanceof` pattern variable? >> >> Kind regards, >> Patrick > > Great. I included some of these in #2300 - @mlchung

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable [v2]

> Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick Patrick Concannon has updated the pull request with a new target base due to a merge or a rebase. The incremental

Re: RFR: 8251942: PrintStream specification is not clear which flush method is automatically invoked

> On Mar 11, 2021, at 2:45 AM, Daniel Fuchs wrote: > > On Wed, 10 Mar 2021 23:03:03 GMT, Brian Burkhalter > wrote: > >> Please review this minor change to the specification of >> `java.io.PrintStream`. The longstanding behavior for flushing is to invoke >> the

Re: RFR: 8173970: jar tool should have a way to extract to a directory

On Mar 11, 2021, at 9:29 AM, Alan Bateman mailto:alan.bate...@oracle.com>> wrote: On 04/03/2021 12:01, Lance Andersen wrote: Hi Jaikiran From https://docs.oracle.com/en/java/javase/15/docs/specs/man/jar.html The jar man page includes the following : The syntax for the jar command

RFR: 8263450: Simplify LambdaForm.useCount

Simplify useCount and avoid calling lastUseIndex for a small startup win. - Commit messages: - Simplify LambdaForm.useCount Changes: https://git.openjdk.java.net/jdk/pull/2940/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2940=00 Issue:

Re: RFR: 8173970: jar tool should have a way to extract to a directory

On 04/03/2021 12:01, Lance Andersen wrote: Hi Jaikiran From https://docs.oracle.com/en/java/javase/15/docs/specs/man/jar.html The jar man page includes the following :  The syntax for the |jar| command resembles the

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v25]

> Please review the implementation of JEP 391: macOS/AArch64 Port. > > It's heavily based on existing ports to linux/aarch64, macos/x86_64, and > windows/aarch64. > > Major changes are in: > * src/hotspot/cpu/aarch64: support of the new calling convention (subtasks > JDK-8253817, JDK-8253818)

Re: RFR: 8253795: Implementation of JEP 391: macOS/AArch64 Port [v23]

On Wed, 3 Mar 2021 15:57:13 GMT, Gerard Ziemski wrote: >> src/hotspot/os_cpu/bsd_aarch64/os_bsd_aarch64.cpp line 207: >> >>> 205: // Enable WXWrite: this function is called by the signal handler at >>> arbitrary >>> 206: // point of execution. >>> 207: ThreadWXEnable wx(WXWrite, thread);

Re: RFR: 8251942: PrintStream specification is not clear which flush method is automatically invoked

On Wed, 10 Mar 2021 23:03:03 GMT, Brian Burkhalter wrote: > Please review this minor change to the specification of > `java.io.PrintStream`. The longstanding behavior for flushing is to invoke > the `flush()` method of the underlying `OutputStream` rather than its > override but this was not

Re: RFR: 8263358: Update java.lang to use instanceof pattern variable

On Wed, 10 Mar 2021 12:59:18 GMT, Patrick Concannon wrote: > Hi, > > Could someone please review my code for updating the code in the `java.lang` > package to make use of the `instanceof` pattern variable? > > Kind regards, > Patrick