On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Sat, 27 Mar 2021 08:58:03 GMT, Dong Bo wrote:
> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding.
> Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic idea
> can be found at
> http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords.
>
>
On Thu, 8 Apr 2021 18:19:20 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. It is not actually related to
> "parenthesized", but period-comma sequence was regarded as a break on a
> backward traverse.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.
On Thu, 8 Apr 2021 20:59:59 GMT, Coleen Phillimore wrote:
> There's a comment above
> void VM_RedefineClasses::mark_dependent_code(InstanceKlass* ik) {
> that should be rewritten, so I think we should just file an RFE to remove it
> afterwards.
https://bugs.openjdk.java.net/browse/JDK-8264941
On Thu, 8 Apr 2021 21:12:21 GMT, Raffaello Giulietti
wrote:
> Hello,
>
> here's a PR for a patch submitted on March 2020
> [1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
> thing.
>
> The patch has been edited to adhere to OpenJDK code conventions about
> multi
Hello,
here's a PR for a patch submitted on March 2020
[1](https://cr.openjdk.java.net/~bpb/4511638/webrev.04/) when Mercurial was a
thing.
The patch has been edited to adhere to OpenJDK code conventions about
multi-line (block) comments. Nothing in the code proper has changed, except for
the
Please review the fix to the subject issue. It is not actually related to
"parenthesized", but period-comma sequence was regarded as a break on a
backward traverse.
-
Commit messages:
- 8264765: BreakIterator sees bogus sentence boundary in parenthesized “i.e.”
phrase
Changes: ht
On Tue, 30 Mar 2021 16:56:57 GMT, Mahendra Chhipa
wrote:
> JDK-8264454 : Jaxp unit test from open jdk needs to be improved
This pull request has now been integrated.
Changeset: 308f6796
Author:Mahendra Chhipa
Committer: Joe Wang
URL: https://git.openjdk.java.net/jdk/commit/308f6796
On Wed, 7 Apr 2021 18:49:36 GMT, Raffaello Giulietti
wrote:
> (Changed to new branch in personal fork)
>
> Please review these small tweaks.
> For background information see
> [1](https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-March/075822.html)
>
> Greetings
> Raffaello
Automati
On Thu, 8 Apr 2021 20:28:27 GMT, Igor Ignatyev wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> Test changes look good to me.
There's a comment above
void VM_Redef
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 20:00:30 GMT, Vladimir Kozlov wrote:
>> GC changes look good.
>
>> void CodeCache::mark_for_evol_deoptimization(InstanceKlass* dependee) {
>> This function, its caller and the function in jvmtiRedefineClasses.cpp that
>> calls it can be deleted also, but you can file a separat
On Thu, 8 Apr 2021 19:58:11 GMT, Stefan Karlsson wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove exports from Graal module to jdk.aot
>
> GC changes look good.
> void CodeCache::mark_for_evol_deoptimizat
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 17:24:38 GMT, Vladimir Kozlov wrote:
>> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related
>> to Ahead-of-Time Compiler from JDK:
>>
>> - `jdk.aot` module — the `jaotc` tool
>> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
On Thu, 8 Apr 2021 15:23:52 GMT, Vladimir Kozlov wrote:
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> -
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> - related HotSpot code guarded by `#if INCLUDE_AOT`
>
> A
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> - related HotSpot code guarded by `#if INCLUDE_AOT`
>
> A
> Hi,
>
> Could someone please review my code for updating the code in the `java.time`
> package to make use of the `instanceof` pattern variable?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The incremental webre
> As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
> Ahead-of-Time Compiler from JDK:
>
> - `jdk.aot` module — the `jaotc` tool
> - `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
> - related HotSpot code guarded by `#if INCLUDE_AOT`
>
> A
On Mon, 5 Apr 2021 19:46:43 GMT, Alexey Semenyuk wrote:
> Use value of `--icon` jpackage CLI option to set icon for exe installers.
This pull request has now been integrated.
Changeset: 5bd6c745
Author:Alexey Semenyuk
URL: https://git.openjdk.java.net/jdk/commit/5bd6c745
Stats: 2
On Sat, 13 Mar 2021 14:40:14 GMT, Philippe Marschall
wrote:
>> I think the implementation changes here look good. I don't know however
>> whether there is enough coverage in the tests. These should verify that the
>> `Reader`, `CharArrayReader`, and `InputStreamReader` implementations of
>> `
As part of [JEP 410](http://openjdk.java.net/jeps/410) remove code related to
Ahead-of-Time Compiler from JDK:
- `jdk.aot` module — the `jaotc` tool
- `src/hotspot/share/aot` — loads AoT compiled code into VM for execution
- related HotSpot code guarded by `#if INCLUDE_AOT`
Additionally, rem
Hi Lin,
First thank you for your efforts on this feature. As Alan suggested on March
26, we should take a step back and flush out the overall changes to the API
before moving forward with additional PR reviews.
We should look to see if it makes sense to use some of the more recent java
fea
On Wed, 7 Apr 2021 21:01:48 GMT, Brian Burkhalter wrote:
> The specification of the method `flush()` in the `java.io` classes
> `CharArrayWriter` and `StringWriter` is not explicit about the fact that the
> method has no effect. This request proposes to add to the specification of
> each flush
On 08/04/2021 10:11, Daniel Fuchs wrote:
On Thu, 8 Apr 2021 08:54:35 GMT, Sebastian Stenzel
wrote:
When we do
byte b1 = (byte) (value & 0xFF);
we keep from int only 1 lower byte and exactly the same can be achieved with
plain cast. See the test below:
public class Main {
public static voi
On Thu, 8 Apr 2021 06:33:43 GMT, Dong Bo wrote:
>> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding.
>> Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic
>> idea can be found at
>> http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords.
>>
On Thu, 8 Apr 2021 09:05:43 GMT, Dong Bo wrote:
> Hi @nick-arm, are you also ok with the newest commit?
It looks ok to me but I'm not a Reviewer.
-
PR: https://git.openjdk.java.net/jdk/pull/3228
On Thu, 8 Apr 2021 08:54:35 GMT, Sebastian Stenzel
wrote:
>> When we do
>> byte b1 = (byte) (value & 0xFF);
>> we keep from int only 1 lower byte and exactly the same can be achieved with
>> plain cast. See the test below:
>> public class Main {
>> public static void main(String[] args) throw
On Thu, 8 Apr 2021 08:28:53 GMT, Andrew Haley wrote:
>> Dong Bo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce unnecessary memory write traffic in non-SIMD code
>
> Marked as reviewed by aph (Reviewer).
@theRealAph Thanks for th
On Thu, 8 Apr 2021 08:29:36 GMT, Lin Zang wrote:
> Dear All,
> May I ask your help to review this change? Thanks!
@LanceAndersen Do you have cycles to help Lin? This proposal will require
discussion, they may be case for the header to be a record for example. My
personal view is that the PR sh
On Thu, 4 Mar 2021 12:16:29 GMT, Сергей Цыпанов
wrote:
> When we do
> byte b1 = (byte) (value & 0xFF);
> we keep from int only 1 lower byte and exactly the same can be achieved with
> plain cast. See the test below:
> public class Main {
> public static void main(String[] args) throws Excepti
On Mon, 15 Mar 2021 06:56:00 GMT, Alan Bateman wrote:
>> Nothing outside of the JDK should be hacking into this private field of a
>> non-exposed class, this should not be a concern here.
>
>> @AlanBateman so is it ok to keep `ArrayLists`?
>
> One thing to look out for is usages of 2-arg add me
When we do
byte b1 = (byte) (value & 0xFF);
we keep from int only 1 lower byte and exactly the same can be achieved with
plain cast. See the test below:
public class Main {
public static void main(String[] args) throws Exception {
IntStream.range(Integer.MIN_VALUE, Integer.MAX_VALUE).forEach
On Fri, 2 Apr 2021 08:53:20 GMT, Lin Zang wrote:
>> Hi Lin,
>>
>> On Mar 24, 2021, at 2:51 AM, Lin Zang ***@***.**@***.***>> wrote:
>>
>>
>>
>> Hi Lance，
>> Thanks a lot for your review. I will update the PR ASAP.
>> May I ask your help to also review the CSR？
>>
>> I believe we need to
On Thu, 8 Apr 2021 06:33:43 GMT, Dong Bo wrote:
>> In JDK-8248188, IntrinsicCandidate and API is added for Base64 decoding.
>> Base64 decoding can be improved on aarch64 with ld4/tbl/tbx/st3, a basic
>> idea can be found at
>> http://0x80.pl/articles/base64-simd-neon.html#encoding-quadwords.
>>
Well, after digging deeper it seems it didn’t really pass on Java 16. The
allocation instrumenter was unable to instrument anything so it didn’t generate
the errors the test looks for. I tried with Java 12-14 and those all failed. In
Java 15 the JVM crashed.
Ralph
> On Apr 7, 2021, at 11:33 PM
38 matches
Mail list logo
