Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v6]

2021-05-01 Thread Vicente Romero
> Please review this PR that intents to make sealed classes a final feature in > Java. This PR contains compiler and VM changes. In line with similar PRs, > which has made preview features final, this one is mostly removing preview > related comments from APIs plus options in test cases. Please

Re: [External] : Re: ReversibleCollection proposal

2021-05-01 Thread Peter Levart
On 4/30/21 9:25 PM, Stuart Marks wrote: So I think we're stuck with void-returning add{First,Last} methods. Have you thought of perhaps not adding them at all? Collection.add() for: List(s) - behaves the same as addLast() LinkedHashSet - behaves the same as addLast() Deque - behaves

Re: ReversibleCollection proposal

2021-05-01 Thread forax
- Mail original - > De: "Stuart Marks" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Samedi 1 Mai 2021 00:42:10 > Objet: Re: ReversibleCollection proposal >> You did not really answer to the real question, why should i use >> ReversibleCollection instead of a Collection as

Integrated: JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with fastdebug

2021-05-01 Thread Andy Herrick
On Fri, 30 Apr 2021 20:19:25 GMT, Andy Herrick wrote: > JDK-8266129: tools/jpackage/windows/WinInstallerIconTest.java hangs with > fastdebug > > just disabling this test when vm.debug This pull request has now been integrated. Changeset: 5c083e85 Author:Andy Herrick URL:

RFR: 8266193: BasicJMapTest should include testHistoParallel methods

2021-05-01 Thread BuddyLiao
The testHistoParallel* method are not included in the BasicJMapTest's main() method. They should be included. - Commit messages: - 8266193: BasicJMapTest should include testHistoParallel methods Changes: https://git.openjdk.java.net/jdk/pull/3810/files Webrev:

Re: RFR: 8254598: StringDedupTable should use OopStorage

2021-05-01 Thread Kim Barrett
On Wed, 28 Apr 2021 06:44:58 GMT, Ioi Lam wrote: >> src/hotspot/share/gc/shared/stringdedup/stringDedupTable.cpp line 557: >> >>> 555: // non-latin1, and deduplicating if we find a match. For >>> deduplication we >>> 556: // only care if the arrays consist of the same sequence of

Re: RFR: 8254598: StringDedupTable should use OopStorage

2021-05-01 Thread Kim Barrett
On Sun, 25 Apr 2021 17:32:51 GMT, Zhengyu Gu wrote: >> Please review this change to the String Deduplication facility. It is being >> changed to use OopStorage to hold weak references to relevant objects, >> rather than bespoke data structures requiring dedicated processing phases by >>

Re: RFR: 8254598: StringDedupTable should use OopStorage

2021-05-01 Thread Kim Barrett
On Wed, 28 Apr 2021 00:29:23 GMT, Ioi Lam wrote: >> src/hotspot/share/classfile/stringTable.cpp line 784: >> >>> 782: SharedStringIterator iter(f); >>> 783: _shared_table.iterate(); >>> 784: } >> >> So with this change (somewhere below) do you no longer deduplicate strings >> from the

Re: RFR: 8254598: StringDedupTable should use OopStorage

2021-05-01 Thread Kim Barrett
On Tue, 27 Apr 2021 22:30:04 GMT, Coleen Phillimore wrote: >> Please review this change to the String Deduplication facility. It is being >> changed to use OopStorage to hold weak references to relevant objects, >> rather than bespoke data structures requiring dedicated processing phases by >>

Integrated: 8265356: need code example for getting canonical constructor of a Record

2021-05-01 Thread Tagir F . Valeev
On Sat, 17 Apr 2021 08:55:59 GMT, Tagir F. Valeev wrote: > I decided to show a complete static method in the example, so it could be > copied to user utility class as is. Not sure if it's reasonable to add > `assert cls.isRecord();` there. Also I don't know whether there's a > limitation on

Re: RFR: 8265356: need code example for getting canonical constructor of a Record [v2]

2021-05-01 Thread Tagir F . Valeev
On Sat, 24 Apr 2021 01:32:45 GMT, Tagir F. Valeev wrote: >> I decided to show a complete static method in the example, so it could be >> copied to user utility class as is. Not sure if it's reasonable to add >> `assert cls.isRecord();` there. Also I don't know whether there's a >> limitation

Re: RFR: 8265356: need code example for getting canonical constructor of a Record [v3]

2021-05-01 Thread Tagir F . Valeev
> I decided to show a complete static method in the example, so it could be > copied to user utility class as is. Not sure if it's reasonable to add > `assert cls.isRecord();` there. Also I don't know whether there's a > limitation on max characters in the sample code. Probable a line break in