On Tue, 11 May 2021 14:11:22 GMT, Harold Seigel wrote:
>> Can you check test/jdkjava/lang/Class/attributes/ClassAttributesTest.java?
>> It may minimally need a comment to be updated. That's the only additional
>> test that I could find in test/jdk.
>
> Hi Alan,
> Thanks for find this. I remove
On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Wed, 12 May 2021 21:03:27 GMT, Ioi Lam wrote:
>> This bug was discovered during the development of
>> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
>> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
>> would trigger the initializati
On Wed, 12 May 2021 22:20:53 GMT, Mandy Chung wrote:
>> How about the latest version (4cd981c)? I removed the `archivedClassLoaders`
>> argument; this also makes the callers simpler.
>
> Looks good to me.
This makes it simpler and much nicer - thank you!
-
PR: https://git.openjdk.
> Before we start to change every usage of String+String into String.concat,
> shouldn't the compiler be so smart to do that for us?
> Currently it compiles to invokedynamic if available and to using
> StringBuilder otherwise. Now why doesn't it compile to String.concat instead
> of StringBuilde
On Wed, 12 May 2021 15:07:37 GMT, Maurizio Cimadamore
wrote:
>> src/hotspot/share/runtime/sharedRuntime.hpp line 465:
>>
>>> 463: static void restore_native_result(MacroAssembler *_masm, BasicType
>>> ret_type, int frame_slots);
>>> 464:
>>> 465: static void move32_64(MacroAssembler* ma
On Wed, 12 May 2021 20:34:08 GMT, Alexey Semenyuk wrote:
> 8266162: Remove JPackage duplicate tests
Marked as reviewed by almatvee (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/4003
On Wed, 12 May 2021 16:28:54 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. This is to incorporate the
> latest language subtag registry definition into the JDK.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3998
Hi,
I gave this some thought the other day when looking at one of Sergey's
patches.
I'm no expert on javac but I think translating to String::concat is
likely to be a bit harder than it seems. It's not a static method, so
the left hand side must be non-null. This is something I believe javac
can
On Wed, 12 May 2021 16:10:24 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
On Wed, 12 May 2021 20:59:51 GMT, Ioi Lam wrote:
>> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 60:
>>
>>> 58: // Sets the ServicesCatalog for the specified loader using archived
>>> objects.
>>> 59: private static void setArchivedServicesCatalog(
>>> 60:
On Wed, 12 May 2021 14:53:39 GMT, Jorn Vernee wrote:
>> src/hotspot/cpu/x86/universalUpcallHandler_x86_64.cpp line 472:
>>
>>> 470: __ block_comment("} preserve_callee_saved_regs ");
>>> 471:
>>> 472: // TODO mxcsr
>>
>> Anything left to do with mxcsr?
>
> I guess this slipped through with
On Fri, 7 May 2021 08:28:43 GMT, Kim Barrett wrote:
>> Please review this change to the String Deduplication facility. It is being
>> changed to use OopStorage to hold weak references to relevant objects,
>> rather than bespoke data structures requiring dedicated processing phases by
>> supporti
On Wed, 12 May 2021 18:46:20 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> @AlanBateman comments
>
> src/java.base/share/classes/jdk/internal/loader/ClassLoaders.java line 60:
>
>> 58: // Sets t
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the initialization of the archived module graph in the wrong
> order.
Hello,
just being curious here:
Before we start to change every usage of String+String into String.concat,
shouldn't the compiler be so smart to do that for us?
Currently it compiles to invokedynamic if available and to using StringBuilder
otherwise. Now why doesn't it compile to String.concat i
8266162: Remove JPackage duplicate tests
-
Commit messages:
- 8266162: Remove JPackage duplicate tests
Changes: https://git.openjdk.java.net/jdk/pull/4003/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4003&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-826
I won’t have time to look at this today, might not be until over the weekend.
On May 12, 2021, at 2:07 PM, Mitsuru Kariya
mailto:github.com+2217224+kariya-mits...@openjdk.java.net>>
wrote:
Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
the following cases:
1. `po
On Wed, 12 May 2021 19:13:43 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Thanks Roger. Changed to fully qualifie
On Wed, 12 May 2021 19:13:43 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Thanks Roger. Changed to fully qualifie
On Tue, 11 May 2021 13:10:30 GMT, Aleksei Voitylov
wrote:
> Please review this PR which fixes the deadlock in ClassLoader between the two
> lock objects - a lock object associated with the class being loaded, and the
> ClassLoader.loadedLibraryNames hash map, locked during the native library
> Update module summary, add a few existing properties and features into the
> tables.
Joe Wang has updated the pull request incrementally with one additional commit
since the last revision:
Thanks Roger. Changed to fully qualified names. Also made them align left
instead of center
From the motivation section:
> So you want to invoke a method X in a library that later calls back into your
> code. In your callback you need some context, perhaps a transaction ID or
> some File instances. However, X provides no way to pass a reference through
> their code into your callback.
Scope locals have come together nicely.
I have some vague thoughts on the presentation of the JEP draft. There
are (at least) three intertwined things in the motivation:
- ThreadLocal (and ITL especially) were always compromises, and with
the advent of Loom, have become untenable -- but the
On Wed, 12 May 2021 18:23:26 GMT, Ioi Lam wrote:
>> This bug was discovered during the development of
>> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
>> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
>> would trigger the initializati
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the initialization of the archived module graph in the wrong
> order.
On Wed, 12 May 2021 05:51:14 GMT, Ioi Lam wrote:
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the initialization o
On Wed, 12 May 2021 15:48:16 GMT, Daniel Fuchs wrote:
> ParentLoggersTest.java has been (rarely) seen failing with "checkLoggers:
> getLoggerNames() returned unexpected loggers"
> The suspicion is that there might be some possible interaction with other
> tests running in the same VM. This test
Fix `SerialBlob.setBytes(long pos, byte[] bytes, int offset, int length)` in
the following cases:
1. `pos - 1 + bytes.length - offset > this.length() && pos - 1 + length <=
this.length()`
The original implementation throws `ArrayIndexOutOfBoundsException` but this
case should end successfull
On Wed, 12 May 2021 00:42:57 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add legacy property names table
The ne
On Wed, 12 May 2021 05:51:14 GMT, Ioi Lam wrote:
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the initialization o
Hi Stephen,
A useful enhancement.
Will you be posting a PR for the implementation?
It is frequently helpful to evaluate the CSR and the implementation
concurrently.
Thanks, Roger
On 5/10/21 1:06 AM, Aaron Scott-Boddendijk wrote:
Yes please.
I often have people ask how they should solve exa
Thank you for your quick reply and precise advice.
Once you have signed your OCA and have generated your proposed patch,
feel free to create your PR.
I already have signed the OCA, so I'll start with a PR for an open
issue, JDK-8153490.
Thanks,
On 2021-05-12 02:59, Lance Andersen wrote:
H
Please review the changes to the subject issue. This is to incorporate the
latest language subtag registry definition into the JDK.
-
Commit messages:
- Renaming the test case
- LSR 2021-05-11
- LSR 2021-03-05
- LSR 2021-02-23
- LSR 2020-12-18
Changes: https://git.openjdk.java.
On Tue, 11 May 2021 17:07:35 GMT, Ioi Lam wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/hotspot/share/oops/instanceMirrorKlass.inline.hpp line 65:
>
>> 63: // so when hand
On Tue, 11 May 2021 20:49:46 GMT, Mandy Chung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix GetModuleTest.java
>
> src/jdk.internal.vm.ci/share/classes/jdk.vm.ci.meta/src/jdk/vm/ci/meta/MetaUtil.java
> line
On Tue, 11 May 2021 14:13:49 GMT, Harold Seigel wrote:
>> Please review this large change to remove Unsafe::defineAnonymousClass().
>> The change removes dAC relevant code and changes a lot of tests. Many of
>> the changed tests need renaming. I hope to do this in a follow up RFE.
>> Some
> Please review this large change to remove Unsafe::defineAnonymousClass().
> The change removes dAC relevant code and changes a lot of tests. Many of the
> changed tests need renaming. I hope to do this in a follow up RFE. Some of
> the tests were modified to use hidden classes, others were
On Wed, 12 May 2021 15:48:16 GMT, Daniel Fuchs wrote:
> ParentLoggersTest.java has been (rarely) seen failing with "checkLoggers:
> getLoggerNames() returned unexpected loggers"
> The suspicion is that there might be some possible interaction with other
> tests running in the same VM. This test
ParentLoggersTest.java has been (rarely) seen failing with "checkLoggers:
getLoggerNames() returned unexpected loggers"
The suspicion is that there might be some possible interaction with other tests
running in the same VM. This test causes the LogManager to reparse its
configuration and should
On Fri, 7 May 2021 08:28:43 GMT, Kim Barrett wrote:
>> Please review this change to the String Deduplication facility. It is being
>> changed to use OopStorage to hold weak references to relevant objects,
>> rather than bespoke data structures requiring dedicated processing phases by
>> supporti
On Wed, 12 May 2021 13:57:21 GMT, Vladimir Ivanov wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Remove unused imports
>> * Fix broken javadoc after removal of @throws clauses
>> * Remove other `@Call
On Tue, 11 May 2021 13:28:16 GMT, Alan Bateman wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> library
On Wed, 12 May 2021 14:06:46 GMT, Vladimir Ivanov wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * Remove unused imports
>> * Fix broken javadoc after removal of @throws clauses
>> * Remove other `@Call
There's been considerable discussion about scope locals on the loom-dev list,
and it's now time to open this to a wider audience. This subject is important
because. although scope locals were motivated by the the needs of Loom, they
have many potential applications outside that project.
The draft
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
JEP 415: Context-specific Deserialization Filters extends the deserialization
filtering mechanisms with more flexible and customizable protections against
malicious deserialization. See JEP 415: https://openjdk.java.net/jeps/415.
The `java.io.ObjectInputFilter` and `java.io.ObjectInputStream` cl
On Mon, 10 May 2021 20:43:20 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-412 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjd
On Wed, 12 May 2021 11:00:25 GMT, Сергей Цыпанов
wrote:
>> src/java.base/share/classes/java/lang/Class.java line 4351:
>>
>>> 4349:
>>> 4350: if (isArray()) {
>>> 4351: return "[".concat(componentType.descriptorString());
>>
>> This could be optimized further for multi-dim
On Wed, 12 May 2021 09:59:32 GMT, Claes Redestad wrote:
>> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've
>> found out, that in a few of JDK core classes, e.g. in `j.l.Class`
>> expressions like `baseName.replace('.', '/') + '/' + name` are not compiled
>> into `invoke
On Thu, 22 Apr 2021 14:07:20 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've found
> out, that in a few of JDK core classes, e.g. in `j.l.Class` expressions like
> `baseName.replace('.', '/') + '/' + name` are not compiled into
> `invokedyn
Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 I've found
out, that in a few of JDK core classes, e.g. in `j.l.Class` expressions like
`baseName.replace('.', '/') + '/' + name` are not compiled into
`invokedynamic`-based code, but into one using `StringBuilder`. This happens
On Wed, 12 May 2021 05:51:14 GMT, Ioi Lam wrote:
> This bug was discovered during the development of
> [JDK-6824466](https://bugs.openjdk.java.net/browse/JDK-6824466): when CDS is
> enabled, if `BootLoader::loadClassOrNull` is called before `initPhase2`, it
> would trigger the initialization o
On 12/05/2021 14:41, Alan Bateman wrote:
On 12/05/2021 11:58, Jorn Vernee wrote:
Hi,
I see that the jar tool has validation logic for multi-release jars
that is triggered when creating or updating a jar that has a
versioned file as an input. I wanted to ask what people think about
the idea o
On 12/05/2021 11:58, Jorn Vernee wrote:
Hi,
I see that the jar tool has validation logic for multi-release jars
that is triggered when creating or updating a jar that has a versioned
file as an input. I wanted to ask what people think about the idea of
exposing this validation logic directly
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description of
> how
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 12 Mai 2021 03:03:33
> Objet: Re: [External] : Re: Collection::getAny discussion
> On 5/10/21 3:31 AM, Remi Forax wrote:
>> Thinking a little more about conflating "first" and "any".
>> I w
- Mail original -
> De: "Peter Levart"
> À: "Stuart Marks"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 12 Mai 2021 08:28:07
> Objet: Re: [External] : Re: ReversibleCollection proposal
> On 5/12/21 2:55 AM, Stuart Marks wrote:
>> As you point out, add() is kind of like addLast(), except wit
On Thu, 8 Apr 2021 18:51:21 GMT, Jorn Vernee wrote:
> This patch adds a `tableSwitch` combinator that can be used to switch over a
> set of method handles given an index, with a fallback in case the index is
> out of bounds, much like the `tableswitch` bytecode. Here is a description of
> how
- Mail original -
> De: "Stuart Marks"
> À: "Remi Forax"
> Cc: "core-libs-dev"
> Envoyé: Mercredi 12 Mai 2021 07:27:51
> Objet: Re: [External] : Re: ReversibleCollection proposal
>>> I'm certain that uses of RC/RS will be rare in the beginning, because they
>>> will
>>> be
>>> new, and
On Wed, 12 May 2021 10:38:11 GMT, Claes Redestad wrote:
> Something like -bm ss -f 20
Yes, I use SingleShotTime as the mode and 400 forks
-
PR: https://git.openjdk.java.net/jdk/pull/3903
Hi,
I see that the jar tool has validation logic for multi-release jars that
is triggered when creating or updating a jar that has a versioned file
as an input. I wanted to ask what people think about the idea of
exposing this validation logic directly under a --validate command line
flag as
On Wed, 12 May 2021 00:42:57 GMT, Joe Wang wrote:
>> Update module summary, add a few existing properties and features into the
>> tables.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add legacy property names table
Looks
On Thu, 6 May 2021 15:20:23 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and
> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class`
> expressions like
>
> String str = baseName.replace('.', '/') + '/' + name;
>
> are not
On Thu, 6 May 2021 15:20:23 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and
> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class`
> expressions like
>
> String str = baseName.replace('.', '/') + '/' + name;
>
> are not
On Thu, 6 May 2021 15:20:23 GMT, Сергей Цыпанов
wrote:
> Hello, from discussion in https://github.com/openjdk/jdk/pull/3464 and
> https://github.com/openjdk/jdk/pull/2212 it appears, that in `j.l.Class`
> expressions like
>
> String str = baseName.replace('.', '/') + '/' + name;
>
> are not
Hi Aleksei,
On 11/05/2021 11:19 pm, Aleksei Voitylov wrote:
Please review this PR which fixes the deadlock in ClassLoader between the two
lock objects - a lock object associated with the class being loaded, and the
ClassLoader.loadedLibraryNames hash map, locked during the native library load
67 matches
Mail list logo
