RFR: 8266559: XPathEvaluationResult.XPathResultType.NODESET maps to incorrect type

2021-05-28 Thread Joe Wang
Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping. Clarifies the supported types for the evaluateExpression methods. Other changes were javadoc tag usages, e.g. s/the code tag/{@code - Commit messages: - 8266559: XPathEvaluationResult.XPathResultType.NODES

Re: RFR: 8267569: java.io.File.equals contains misleading Javadoc [v2]

2021-05-28 Thread Brian Burkhalter
> Modify the specification of `java.io.File.equals` to clarify that equality is > based only on a comparison of abstract pathnames as opposed to the file > system objects that the `File`s represent. Brian Burkhalter has updated the pull request incrementally with one additional commit since the

RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS

2021-05-28 Thread Henry Jen
…d on macOS This patch simply round up the specified stack size to multiple of the system page size. Test is trivial, simply run java with -Xss option against following code. On MacOS, before the fix, running with `-Xss159k` and `-Xss160k` would get `7183` and `649` respectively. After fix, b

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v12]

2021-05-28 Thread Roger Riggs
On Fri, 28 May 2021 15:58:17 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits si

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v12]

2021-05-28 Thread Roger Riggs
On Fri, 28 May 2021 15:50:29 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits si

Integrated: 8267706: bin/idea.sh tries to use cygpath on WSL

2021-05-28 Thread Nikita Gubarkov
On Tue, 25 May 2021 16:37:30 GMT, Nikita Gubarkov wrote: > 8267706: bin/idea.sh tries to use cygpath on WSL This pull request has now been integrated. Changeset: 964bac9e Author:Nikita Gubarkov Committer: Alexey Ushakov URL: https://git.openjdk.java.net/jdk/commit/964bac9e38460df4

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v12]

2021-05-28 Thread Roger Riggs
On Fri, 28 May 2021 15:43:14 GMT, Daniel Fuchs wrote: >> Roger Riggs has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits si

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v12]

2021-05-28 Thread Brent Christian
On Wed, 26 May 2021 22:11:54 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >> https://openjdk.java.net/jeps/415

Re: Proposal for new interface: TimeSource

2021-05-28 Thread Naoto Sato
As I commented on the PR, the test needs to run in othervm mode: https://github.com/openjdk/jdk/pull/4016#issuecomment-844551175 --- a/test/jdk/java/time/test/TEST.properties +++ b/test/jdk/java/time/test/TEST.properties @@ -1,5 +1,5 @@ # java.time tests use TestNG TestNG.dirs = .. -othervm.di

Re: RFR: 8264859: Implement Context-Specific Deserialization Filters [v12]

2021-05-28 Thread Daniel Fuchs
On Wed, 26 May 2021 22:11:54 GMT, Roger Riggs wrote: >> JEP 415: Context-specific Deserialization Filters extends the >> deserialization filtering mechanisms with more flexible and customizable >> protections against malicious deserialization. See JEP 415: >> https://openjdk.java.net/jeps/415

Re: RFR: 8191441: (Process) add Readers and Writer access to java.lang.Process streams [v4]

2021-05-28 Thread Roger Riggs
On Thu, 27 May 2021 06:53:18 GMT, Alan Bateman wrote: > > Process is abstract. Is there any use for these new methods to be > > overridden? > > Perhaps they should be final. > > It's not clear to me that it is useful to extend Process outside of the JDK. > Testing, wrapping, ...? It feels like

Integrated: 8265309: com/sun/jndi/dns/ConfigTests/Timeout.java fails with "Address already in use" BindException

2021-05-28 Thread Aleksei Efimov
On Thu, 27 May 2021 15:02:01 GMT, Aleksei Efimov wrote: > Hi, > > `com/sun/jndi/dns/ConfigTests/Timeout.java ` was seen failing intermittently > with "Address already in use" `BindException`. The reason of this failure is > that `disconnect` call in JNDI `DnsClient` fails to rebind the datagra

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-28 Thread Jan Lahoda
On Thu, 27 May 2021 10:38:08 GMT, Maurizio Cimadamore wrote: >> Jan Lahoda has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - Post-merge fix - need to include jdk.internal.javac in the list of >> packages used

Re: RFR: 8265418: Clean-up redundant null-checks of Class.getPackageName() [v3]

2021-05-28 Thread Сергей Цыпанов
On Thu, 27 May 2021 11:19:24 GMT, Сергей Цыпанов wrote: >> As discussed in https://github.com/openjdk/jdk/pull/3464 we can clean-up >> null-checks remaining after >> [8142968](https://bugs.openjdk.java.net/browse/JDK-8142968) as >> Class.getPackageName() never returns null. > > Сергей Цыпанов

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v6]

2021-05-28 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v5]

2021-05-28 Thread Jan Lahoda
On Thu, 27 May 2021 18:28:13 GMT, Evgeny Mandrikov wrote: >>> > I've updated the code to produce better/more useful LineNumberTable for >>> > rule switches. >>> >>> @lahodaj I re-tested previous example and tested few others. Now everything >>> seems to be good with `LineNumberTable` entries +

Re: RFR: 8265418: Clean-up redundant null-checks of Class.getPackageName() [v3]

2021-05-28 Thread Alan Bateman
On Fri, 28 May 2021 06:41:51 GMT, Alan Bateman wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8265418: Compare package names with == instead of equals() > > I see this has been integrated but I have concerns tha

Re: RFR: 8265418: Clean-up redundant null-checks of Class.getPackageName() [v3]

2021-05-28 Thread Сергей Цыпанов
On Fri, 28 May 2021 06:41:51 GMT, Alan Bateman wrote: >> Сергей Цыпанов has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8265418: Compare package names with == instead of equals() > > I see this has been integrated but I have concerns tha