On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
On 2/06/2021 3:47 pm, Jaroslav Tulach wrote:
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
There doesn't seem to be much support for the complete changes in #4245. To get
at least something useful from that endeavor I have extracted the test for
existing behavior of `-XX:+Preserve
On Tue, 1 Jun 2021 09:30:40 GMT, Jaroslav Tulach
wrote:
> There doesn't seem to be much support for the complete changes in #4245. To
> get at least something useful from that endeavor I have extracted the test
> for existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it
> in
On 01/06/2021 22:28, John Rose wrote:
On Jun 1, 2021, at 7:02 AM, Brian Goetz
mailto:brian.go...@oracle.com>> wrote:
As Alan's archaeology discovered, this flag appears to be a leftover from the
original implementation, and I could find no signs of its usage.
Note to self and other reviewer
On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
This pull request has now b
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
> The JDK codebase re-created many variants of checkIndex(`grep -I -r
> 'cehckIndex' jdk/`). A notable variant is java.nio.Buffer.checkIndex, which
> annotated with @IntrinsicCandidate and it only has a corresponding C1
> intrinsic version.
>
> In fact, there is an utility method
> `jdk.intern
On Fri, 28 May 2021 00:54:21 GMT, Leonid Mesnik wrote:
>> Hi Leonid,
>>
>> What is EFH? Please update the bug and PR to explain.
>>
>> Thanks,
>> David
>
>> Hi Leonid,
>>
>> What is EFH? Please update the bug and PR to explain.
>>
>> Thanks,
>> David
>
> Updated summary to "Improve jtreg tes
> Currently `"VectorMask.eq()" `is not vectorized:
>
> public VectorMask eq(VectorMask m) {
> // FIXME: Generate good code here.
> return bOp(m, (i, a, b) -> a == b);
> }
>
> This can be implemented by calling `"xor(m.not())"` directly.
>
> The performance improved about
On Tue, 1 Jun 2021 16:29:58 GMT, Paul Sandoz wrote:
> Looks. Later we may want to consider pushing this down as an intrinsic,
> perhaps reusing `VectorSupport.compare`.
Thanks for your review @PaulSandoz ! Yes, reusing `VectorSupport.compare` is an
alternative way to do the vectorization.
---
On Fri, 28 May 2021 02:25:59 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> @lmesnik , how has this been tested?
@iignatev, thank you for your comments. I updated all of th
I'm fixing this along with a couple intertwined issues.
1. Add Map.Entry::copyOf as an idempotent copy operation.
2. Clarify that AbstractMap.SimpleImmutableEntry is itself unmodifiable (not
really immutable) but that subclasses can be modifiable.
3. Clarify some confusing, historical wording a
On Fri, 28 May 2021 02:20:04 GMT, Igor Ignatyev wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> spaces updated.
>
> test/failure_handler/Makefile line 41:
>
>> 39: CONF_DIR = src/share/conf
>> 40:
>> 41: JAVA_RE
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Leonid Mesnik has updated the pull request incrementally with one addi
On Wed, 2 Jun 2021 00:19:56 GMT, Jonathan Gibbons wrote:
>> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
>> probably need to check `realpath` availability in idea.sh and suggest
>> installing `coreutils` if it's not available
>
> @YaaZ I'm aware of the workaround, but t
On Thu, 20 May 2021 21:07:04 GMT, Gavin Bierman wrote:
> Hi all,
>
> Please review this patch to make the ConstantDesc hierarchy `sealed`, as was
> promised in its Javadoc, now that sealed classes are finalising in JDK 17.
>
> Thanks,
> Gavin
This pull request has now been integrated.
Chang
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Leonid Mesnik has updated the pull request incrementally with one addi
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Leonid Mesnik has updated the pull request incrementally with one addi
> EFH is improved to process cores and get mixed stack traces with jhsdb and
> native stack traces with gdb/lldb. It might be useful because hs_err doesn't
> contain info about all threads, sometimes it is even not generated.
Leonid Mesnik has updated the pull request incrementally with two addi
On Tue, 1 Jun 2021 22:20:25 GMT, Nikita Gubarkov
wrote:
>> The fix fails on a Mac, where `realpath` is not available by default.
>
> @jonathan-gibbons this can be fixed with `brew install coreutils`. We
> probably need to check `realpath` availability in idea.sh and suggest
> installing `coreu
On Wed, 26 May 2021 11:26:24 GMT, Andy Herrick wrote:
> JDK-8267598: jpackage removes system libraries from java.library.path
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/4203
On Tue, 1 Jun 2021 22:10:41 GMT, Jonathan Gibbons wrote:
>> Nikita Gubarkov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
>
> The fix fails on a Mac, where `realpath` is not availa
On Thu, 27 May 2021 17:45:40 GMT, Nikita Gubarkov
wrote:
>> 8267706: bin/idea.sh tries to use cygpath on WSL
>
> Nikita Gubarkov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8267706: Break long line in make/ide/idea/jdk/idea.gmk
The fi
On Tue, 1 Jun 2021 20:29:30 GMT, Joe Wang wrote:
>> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
>> Clarifies the supported types for the evaluateExpression methods.
>>
>> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
>
> Joe Wang has updated
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
Joe Wang has updated the pull request incrementally with one additional commit
On Jun 1, 2021, at 7:02 AM, Brian Goetz
mailto:brian.go...@oracle.com>> wrote:
As Alan's archaeology discovered, this flag appears to be a leftover from the
original implementation, and I could find no signs of its usage.
Note to self and other reviewers of future versions
of the JVMS: When you
On Tue, 1 Jun 2021 07:50:49 GMT, Jan Lahoda wrote:
>> This is a preview of a patch implementing JEP 406: Pattern Matching for
>> switch (Preview):
>> https://bugs.openjdk.java.net/browse/JDK-8213076
>>
>> The current draft of the specification is here:
>> http://cr.openjdk.java.net/~gbierman/je
Trivial changes to this non-normative document.
-
Commit messages:
- 8268077: java.util.List missing from Collections Framework Overview
Changes: https://git.openjdk.java.net/jdk/pull/4289/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4289&range=00
Issue: https://bu
On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
src/java.xml/share/classes/
On Sat, 29 May 2021 00:12:09 GMT, Joe Wang wrote:
> Makes a correction to XPathEvaluationResult.XPathResultType.NODESET mapping.
> Clarifies the supported types for the evaluateExpression methods.
>
> Other changes were javadoc tag usages, e.g. s/the code tag/{@code
Marked as reviewed by lance
JDK-8267598: jpackage removes system libraries from java.library.path
-
Commit messages:
- JDK-8267598: jpackage removes system libraries from java.library.path
- JDK-8267598: jpackage removes system libraries from java.library.path
- JDK-8267598: jpackage removes system libraries
On Mon, 24 May 2021 05:50:44 GMT, Jatin Bhateja wrote:
>> Current VectorAPI Java side implementation expresses rotateLeft and
>> rotateRight operation using following operations:-
>>
>> vec1 = lanewise(VectorOperators.LSHL, n)
>> vec2 = lanewise(VectorOperators.LSHR, n)
>> res = lan
On Tue, 1 Jun 2021 17:43:42 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated the
On Thu, 27 May 2021 16:14:38 GMT, Maxim Kartashev
wrote:
>> Character strings within JVM are produced and consumed in several formats.
>> Strings come from/to Java in the UTF8 format and POSIX APIs (like fprintf()
>> or dlopen()) consume strings also in UTF8. On Windows, however, the
>> situa
On 5/29/2021 12:20 AM, Jaroslav Tulach wrote:
This PR exposes runtime invisible annotations via `Class.getAnnotation` when
`-XX:+PreserveAllAnnotations` option is passed to the JVM.
Existing `-XX:+PreserveAllAnnotations` option can be very useful for code that
needs to access annotations with
I have created a JBS issue: https://bugs.openjdk.java.net/browse/JDK-8268077
> On 1 Jun 2021, at 18:56, Raffaello Giulietti
> wrote:
>
> Hi,
>
> can anybody take a look at this?
> I would do it myself but I don't have Author status to add an issue to the
> JBS.
>
> Should be a trivial change
> This PR contains API and implementation changes for [JEP-414 Vector API
> (Second Incubator)](https://openjdk.java.net/jeps/414), in preparation for
> when targeted.
>
> Enhancements are made to the API for the support of operations on characters,
> such as for UTF-8 character decoding. Speci
On Tue, 1 Jun 2021 17:43:42 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated the
On Tue, 1 Jun 2021 17:43:42 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated the
Hi,
can anybody take a look at this?
I would do it myself but I don't have Author status to add an issue to
the JBS.
Should be a trivial change.
Thanks
Raffaello
On 2021-05-30 18:03, Raffaello Giulietti wrote:
Hello,
seems like java.util.List is missing from the list in the "Collection
I
On Tue, 1 Jun 2021 17:43:42 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated the
On Tue, 25 May 2021 02:44:41 GMT, Yi Yang wrote:
>> Looks like now the test fails in the pre-submit tests?
>
> Thank you @veresov!
>
> I'm glad to have more comments from hotspot-compiler group.
>
> Later, I'd like to integrate it if there are no more comments/objections.
>
> Thanks!
> Yang
> Modify the specification of `java.io.File.equals` to clarify that equality is
> based only on a comparison of abstract pathnames as opposed to the file
> system objects that the `File`s represent.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the
> Methods are added to java.lang.Process to read and write characters and lines
> from and to a spawned Process.
> The Charset used to encode and decode characters to bytes can be specified or
> use the
> operating system native encoding as is available from the "native.encoding"
> system proper
> This PR contains the API and implementation changes for JEP-412 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/412
Maurizio Cimadamore has updated the pull request
On Sun, 30 May 2021 00:49:56 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Marked as reviewed by rriggs (
On Sun, 30 May 2021 00:49:56 GMT, Stephen Colebourne
wrote:
>> 8266846: Add java.time.InstantSource
>
> Stephen Colebourne has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8266846: Add java.time.InstantSource
Looks good to me.
---
On Mon, 31 May 2021 10:25:26 GMT, Xiaohong Gong wrote:
> Currently `"VectorMask.eq()" `is not vectorized:
>
> public VectorMask eq(VectorMask m) {
> // FIXME: Generate good code here.
> return bOp(m, (i, a, b) -> a == b);
> }
>
> This can be implemented by calling `"xor(
On Thu, 27 May 2021 14:31:59 GMT, Aleksei Voitylov
wrote:
>> Please review this PR which fixes the deadlock in ClassLoader between the
>> two lock objects - a lock object associated with the class being loaded, and
>> the ClassLoader.loadedLibraryNames hash map, locked during the native
>> li
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
On Tue, 1 Jun 2021 15:21:33 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e384
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28c9f9be7941a1
> The essential change for this JEP, incl
On Fri, 28 May 2021 05:47:11 GMT, David Holmes wrote:
> The core-libs folks have the experience/expertise with these character
> encoding issues so I will defer to them.
Naoto has agreed to look at this.
-
PR: https://git.openjdk.java.net/jdk/pull/4169
Since the discussion happened over the holiday weekend, I didn't get a
chance to respond until now, but I think that this came to a good
outcome. As Alan's archaeology discovered, this flag appears to be a
leftover from the original implementation, and I could find no signs of
its usage. We m
On Tue, 25 May 2021 16:53:28 GMT, Roger Riggs wrote:
>> Methods are added to java.lang.Process to read and write characters and
>> lines from and to a spawned Process.
>> The Charset used to encode and decode characters to bytes can be specified
>> or use the
>> operating system native encoding
On Fri, 28 May 2021 23:42:39 GMT, Brian Burkhalter wrote:
>> Modify the specification of `java.io.File.equals` to clarify that equality
>> is based only on a comparison of abstract pathnames as opposed to the file
>> system objects that the `File`s represent.
>
> Brian Burkhalter has updated th
On Mon, 31 May 2021 15:02:57 GMT, Weijun Wang wrote:
>> Please review this implementation of [JEP
>> 411](https://openjdk.java.net/jeps/411).
>>
>> The code change is divided into 3 commits. Please review them one by one.
>>
>> 1.
>> https://github.com/openjdk/jdk/commit/576161d15423f58281e38
On Tue, 25 May 2021 09:37:58 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
This pull request has now been integrate
There doesn't seem to be much support for the complete changes in #4245. To get
at least something useful from that endeavor I have extracted the test for
existing behavior of `-XX:+PreserveAllAnnotations` and I am offering it in this
pull request without any changes to the JVM behavior.
--
On Fri, 28 May 2021 12:56:39 GMT, Jaroslav Tulach
wrote:
> This PR exposes runtime invisible annotations via `Class.getAnnotation` when
> `-XX:+PreserveAllAnnotations` option is passed to the JVM.
>
> Existing `-XX:+PreserveAllAnnotations` option can be very useful for code
> that needs to ac
On Mon, 31 May 2021 12:02:13 GMT, Peter Levart wrote:
> A test could be constructed so that it would mimic the migration of an
> annotation from CLASS to RUNTIME retention
The test is ready for review in #4280 - I am closing this PR without
integration as the change of core-libs proposed here
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the switch expressions?
>
> Kind regards,
> Patrick
Patrick Concannon has updated the pull request with a new target base due to a
merge or a rebase. The
> This is a preview of a patch implementing JEP 406: Pattern Matching for
> switch (Preview):
> https://bugs.openjdk.java.net/browse/JDK-8213076
>
> The current draft of the specification is here:
> http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html
>
> A
64 matches
Mail list logo
