Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS [v5]

2021-06-06 Thread David Holmes
On Mon, 7 Jun 2021 03:22:18 GMT, Henry Jen wrote: > while some other Posix system might as explained in the man page What manpage? The POSIX specification for this does not allow for EINVAL being returned due to alignment issues. That is an extra constraint imposed by macOS and which makes

Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS [v5]

2021-06-06 Thread Henry Jen
On Mon, 7 Jun 2021 03:18:32 GMT, Henry Jen wrote: >> …d on macOS >> >> This patch simply round up the specified stack size to multiple of the >> system page size. >> >> Test is trivial, simply run java with -Xss option against following code. On >> MacOS, before the fix, running with

Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS [v5]

2021-06-06 Thread Henry Jen
> …d on macOS > > This patch simply round up the specified stack size to multiple of the system > page size. > > Test is trivial, simply run java with -Xss option against following code. On > MacOS, before the fix, running with `-Xss159k` and `-Xss160k` would get > `7183` and `649`

Re: RFR: 8236569: -Xss not multiple of 4K does not work for the main thread on macOS [v4]

2021-06-06 Thread David Holmes
On Sat, 5 Jun 2021 01:48:21 GMT, Henry Jen wrote: >> …d on macOS >> >> This patch simply round up the specified stack size to multiple of the >> system page size. >> >> Test is trivial, simply run java with -Xss option against following code. On >> MacOS, before the fix, running with

Re: RFR: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException [v2]

2021-06-06 Thread Joe Darcy
> Make explicit illegal argument cases of Class.arrayType. > > Please also review the corresponding CSR: > https://bugs.openjdk.java.net/browse/JDK-8268300 Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add missing ending newline.

RFR: 8268250: Class.arrayType() for a 255-d array throws undocumented IllegalArgumentException

2021-06-06 Thread Joe Darcy
Make explicit illegal argument cases of Class.arrayType. Please also review the corresponding CSR: https://bugs.openjdk.java.net/browse/JDK-8268300 - Commit messages: - Add test file. - Merge branch 'master' into 8268250 - 8268250: Class.arrayType() for a 255-d array throws

Re: RFR: 8195129: System.load() fails to load from unicode paths [v3]

2021-06-06 Thread David Holmes
On Fri, 4 Jun 2021 14:00:25 GMT, Maxim Kartashev wrote: >> Not an expert by my understanding is that the VM only deals with modified >> UTF-8, as does JNI. So the incoming string should be modified-UTF8 IMO and >> then converted to UTF16. >> >> That said, this is shared code being modified

Re: RFR: 8266598: Exception values for AnnotationTypeMismatchException are not always informative [v3]

2021-06-06 Thread Rafael Winterhalter
On Sat, 8 May 2021 09:51:46 GMT, Rafael Winterhalter wrote: >> This improves the messages that are provided by >> `AnnotationTypeMismatchException`s. The message provided by >> AnnotationTypeMismatchExceptions is deliberately undefined such that this >> should not break any contract. > >

Re: RFR: 8266766: Arrays of types that cannot be an annotation member do not yield exceptions

2021-06-06 Thread Rafael Winterhalter
On Fri, 7 May 2021 18:58:02 GMT, Rafael Winterhalter wrote: > If a type is changed from a type that can be a member of an annotation which > is used in an array, changing it to a type that cannot be an array member > will be treated as if the type is an annotation type. As a result, no >

RFR: 8268296: ScopedMemoryAccess build error with readonly filesystems

2021-06-06 Thread Liam Miller-Cushon
This change fixes a build error during the generation of `ScopedMemoryAccess.java` when the sources are readonly, by using `cat a > b` instead of `cp a b` to avoid propagating the permissions to the generated source. - Commit messages: - 8268296: ScopedMemoryAccess build error