Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v2]

2021-07-09 Thread Alexey Semenyuk
On Fri, 9 Jul 2021 17:59:35 GMT, Andy Herrick wrote: >> JDK-8269387: jpackage --add-launcher should have option to not create >> shortcuts for additional launchers > > Andy Herrick has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 6506405: Math.abs(float) is slow [v6]

2021-07-09 Thread Brian Burkhalter
> Please consider this change to make the `float` and `double` versions of > `java.lang.Math.abs()` branch-free. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 6506405: Clean up test - Changes: - all:

Integrated: Merge jdk17

2021-07-09 Thread Jesper Wilhelmsson
On Sat, 10 Jul 2021 00:17:07 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: ec975c6a Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/ec975c6a055688c014e709917dcfc340037e684f Stats: 691

Re: RFR: 6506405: Math.abs(float) is slow [v7]

2021-07-09 Thread Brian Burkhalter
On Fri, 9 Jul 2021 22:02:14 GMT, Joe Darcy wrote: >> Brian Burkhalter has refreshed the contents of this pull request, and >> previous commits have been removed. The incremental views will show >> differences compared to the previous content of the PR. > >

Re: RFR: 6506405: Math.abs(float) is slow [v7]

2021-07-09 Thread Joe Darcy
On Fri, 9 Jul 2021 21:30:22 GMT, Brian Burkhalter wrote: >> Please consider this change to make the `float` and `double` versions of >> `java.lang.Math.abs()` branch-free. > > Brian Burkhalter has refreshed the contents of this pull request, and > previous commits have been removed. The

Re: RFR: 8266936: Add a finalization JFR event

2021-07-09 Thread Brent Christian
On Thu, 8 Jul 2021 19:47:26 GMT, Markus Grönlund wrote: > Greetings, > > Object.finalize() was deprecated in JDK9. There is an ongoing effort to > replace and mitigate Object.finalize() uses in the JDK libraries; please see > https://bugs.openjdk.java.net/browse/JDK-8253568 for more

RFR: Merge jdk17

2021-07-09 Thread Jesper Wilhelmsson
Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8268826: Cleanup Override in Context-Specific Deserialization Filters - 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions - 8270151:

Re: RFR: 6506405: Math.abs(float) is slow [v8]

2021-07-09 Thread Brian Burkhalter
> Please consider this change to make the `float` and `double` versions of > `java.lang.Math.abs()` branch-free. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 6506405: More test cleanup - Changes: - all:

Re: RFR: 6506405: Math.abs(float) is slow [v7]

2021-07-09 Thread Brian Burkhalter
> Please consider this change to make the `float` and `double` versions of > `java.lang.Math.abs()` branch-free. Brian Burkhalter has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous

Re: RFR: 6506405: Math.abs(float) is slow [v5]

2021-07-09 Thread Brian Burkhalter
On Fri, 9 Jul 2021 13:54:39 GMT, Joe Darcy wrote: >> Brian Burkhalter has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 6506405: Add some tests > > test/jdk/java/lang/Math/AbsTests.java line 35: > >> 33: */ >> 34: public class AbsTests

Re: RFR: JDK-8269387: jpackage --add-launcher should have option to not create shortcuts for additional launchers [v2]

2021-07-09 Thread Andy Herrick
> JDK-8269387: jpackage --add-launcher should have option to not create > shortcuts for additional launchers Andy Herrick has updated the pull request incrementally with one additional commit since the last revision: JDK-8269387: jpackage --add-launcher should have option to not create

[jdk17] Integrated: 8268826: Cleanup Override in Context-Specific Deserialization Filters

2021-07-09 Thread Roger Riggs
On Wed, 16 Jun 2021 20:22:17 GMT, Roger Riggs wrote: > Remove the unnecessary special case "OVERRIDE" in jdk.serialFilterFactory > property. > Fix description in the example of a filter allowing platform classes. > Suppress some warnings about use of SecurityManager in tests. This pull request

Re: RFR: 8270056: Generated lambda class can not access protected static method of target class [v2]

2021-07-09 Thread Mandy Chung
On Fri, 9 Jul 2021 02:28:46 GMT, Yi Yang wrote: >> Generated lambda class can not access protected static method of the target >> class. The following exception is thrown when executing the attached >> reproducible program: >> >> >> Exception in thread "main" java.lang.IllegalAccessError:

Re: RFR: 6506405: Math.abs(float) is slow [v5]

2021-07-09 Thread Joe Darcy
On Thu, 8 Jul 2021 18:15:23 GMT, Brian Burkhalter wrote: >> Please consider this change to make the `float` and `double` versions of >> `java.lang.Math.abs()` branch-free. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > >

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v3]

2021-07-09 Thread Lance Andersen
Hi Jaikiran, On Jul 9, 2021, at 8:43 AM, Jaikiran Pai mailto:jai.forums2...@gmail.com>> wrote: On 05/07/21 10:52 am, Jaikiran Pai wrote: 4. I've never previously created a manual test case. The `LargeCompressedEntrySizeTest` in this PR is expected to be a manual test case (given how long it

[jdk17] RFR: 8269281: java/foreign/Test{Down,Up}call.java time out

2021-07-09 Thread Maurizio Cimadamore
After some more investigation, I have been able to at least partially reproduce on my Linux box. While I can't get to same slowdown as we're seeing in test machines, I did notice that in fastdebug mode, TestUpcall is a lot slower than in release mode. The underlying issue is that these tests

RFR: 8266936: Add a finalization JFR event

2021-07-09 Thread Markus Grönlund
Greetings, Object.finalize() was deprecated in JDK9. There is an ongoing effort to replace and mitigate Object.finalize() uses in the JDK libraries; please see https://bugs.openjdk.java.net/browse/JDK-8253568 for more information. We would also like to assist users in replacing and mitigating

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Matthias Baesken
On Fri, 9 Jul 2021 13:42:15 GMT, Severin Gehwolf wrote: > OK. Please also add a test on the hotspot side. You may want to add relevant > parts to `TestMisc.java`. Thanks for the suggestion, I will look into TestMisc.java . - PR: https://git.openjdk.java.net/jdk/pull/4518

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Severin Gehwolf
On Fri, 9 Jul 2021 11:35:34 GMT, Matthias Baesken wrote: > > This looks pretty good now. Looking forward to seeing container tests for > > this new code. > > Hi Severin , I did some adjustments following your suggestions. > I added docker based test coding for testing pids-limit (with limits

Re: RFR: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream [v3]

2021-07-09 Thread Jaikiran Pai
On 05/07/21 10:52 am, Jaikiran Pai wrote: 4. I've never previously created a manual test case. The `LargeCompressedEntrySizeTest` in this PR is expected to be a manual test case (given how long it might take to run on various different systems). The only difference between this test case

RFR: 8270160: Remove redundant bounds check from AbstractStringBuilder.charAt()

2021-07-09 Thread Сергей Цыпанов
`AbstractStringBuilder.charAt(int)` does bounds check before calling `charAt()` (for non-latin Strings): @Override public char charAt(int index) { checkIndex(index, count); if (isLatin1()) { return (char)(value[index] & 0xff); } return StringUTF16.charAt(value, index); }

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v2]

2021-07-09 Thread Matthias Baesken
On Tue, 29 Jun 2021 08:21:51 GMT, Severin Gehwolf wrote: > This looks pretty good now. Looking forward to seeing container tests for > this new code. Hi Severin , I did some adjustments following your suggestions. I added docker based test coding for testing pids-limit (with limits and also

Re: RFR: JDK-8266490: Extend the OSContainer API to support the pids controller of cgroups [v3]

2021-07-09 Thread Matthias Baesken
> Hello, please review this PR; it extend the OSContainer API in order to also > support the pids controller of cgroups. > > I noticed that unlike the other controllers "cpu", "cpuset", "cpuacct", > "memory" on some older Linux distros (SLES 12.1, RHEL 7.1) the pids > controller might not be

Re: RFR: 8268231: Aarch64: Use ldp in intrinsics for String.compareTo

2021-07-09 Thread Andrew Haley
On Thu, 8 Jul 2021 11:50:36 GMT, Wang Huang wrote: > Dear all, > Can you do me a favor to review this patch. This patch use `ldp` to > implement String.compareTo. > > * We add a JMH test case > * Here is the result of this test case > > Benchmark|(size)|